{"id":14211,"url":"https://patchwork.libcamera.org/api/patches/14211/?format=json","web_url":"https://patchwork.libcamera.org/patch/14211/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20211020154607.180161-5-jeanmichel.hautbois@ideasonboard.com>","date":"2021-10-20T15:45:58","name":"[libcamera-devel,v2,04/13] ipa: ipu3: awb: Change minimal green threshold value","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"3d815936ea89878f7c778ae2466e1a52f90847ed","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/people/75/?format=json","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/14211/mbox/","series":[{"id":2645,"url":"https://patchwork.libcamera.org/api/series/2645/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2645","date":"2021-10-20T15:45:54","name":"ipa: ipu3: Fix AGC bugs","version":2,"mbox":"https://patchwork.libcamera.org/series/2645/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/14211/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/14211/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 96B81C324E\n\tfor ;\n\tWed, 20 Oct 2021 15:46:22 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 24C8668F67;\n\tWed, 20 Oct 2021 17:46:20 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EE8DE6023A\n\tfor ;\n\tWed, 20 Oct 2021 17:46:13 +0200 (CEST)","from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:ce4b:1c5f:7302:b899])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AB3D83F6;\n\tWed, 20 Oct 2021 17:46:13 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"HqnMqL/V\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1634744773;\n\tbh=Pz0NTXrbv9zGzkgSSvnGR/+tUESSHcG6lnJnrkgMAv0=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=HqnMqL/VeJ10/dsds5FvYKPaz3n/MhqdSNcUMZl9zjjm2nPP5RmlT1oPiojVcJMK/\n\tvbW94bb6ymMmpPp9cVtnip4sHv5vftEdo/RQhSumYYd2JzppKBumps4bqRwxQjnqVo\n\tBd9G4UqSQxek2BlQLoq7OR0StIl/tj8naohA9nVo=","From":"Jean-Michel Hautbois ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 20 Oct 2021 17:45:58 +0200","Message-Id":"<20211020154607.180161-5-jeanmichel.hautbois@ideasonboard.com>","X-Mailer":"git-send-email 2.32.0","In-Reply-To":"<20211020154607.180161-1-jeanmichel.hautbois@ideasonboard.com>","References":"<20211020154607.180161-1-jeanmichel.hautbois@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 04/13] ipa: ipu3: awb: Change minimal\n\tgreen threshold value","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"When zones are used for the grey world algorithm, they are only\nconsidered if their average green value is at least 32/255 to exclude\nzones that are too dark and don't provide relevant colour information\n(on the opposite side of the spectrum, saturated regions are excluded by\nthe ImgU statistics engine).\n\nThe algorithm requires a minimal number of zones that meet this criteria\nin order to run. Now that we correct the black level, the 32/255 minimal\nvalue is a bit high and prevents the algorithm for running in low-light\nconditions. Lower the value to 16/255 to fix it.\n\nSigned-off-by: Jean-Michel Hautbois \nAcked-by: Kieran Bingham \nReviewed-by: Laurent Pinchart \n---\n src/ipa/ipu3/algorithms/awb.cpp | 8 +++++++-\n 1 file changed, 7 insertions(+), 1 deletion(-)","diff":"diff --git a/src/ipa/ipu3/algorithms/awb.cpp b/src/ipa/ipu3/algorithms/awb.cpp\nindex 62c72cce..1ffb431b 100644\n--- a/src/ipa/ipu3/algorithms/awb.cpp\n+++ b/src/ipa/ipu3/algorithms/awb.cpp\n@@ -17,7 +17,13 @@ namespace ipa::ipu3::algorithms {\n \n LOG_DEFINE_CATEGORY(IPU3Awb)\n \n-static constexpr uint32_t kMinGreenLevelInZone = 32;\n+/*\n+ * When zones are used for the grey world algorithm, they are only considered if\n+ * their average green value is at least 16/255 to exclude zones that are too\n+ * dark and don't provide relevant colour information (on the opposite side of\n+ * the spectrum, saturated regions are excluded by the ImgU statistics engine).\n+ */\n+static constexpr uint32_t kMinGreenLevelInZone = 16;\n \n /* Minimum proportion of cells counted within a zone for it to be relevant */\n static constexpr double kMinRelevantCellsRatio = 0.8;\n","prefixes":["libcamera-devel","v2","04/13"]}