[{"id":20396,"web_url":"https://patchwork.libcamera.org/comment/20396/","msgid":"","date":"2021-10-22T14:12:09","subject":"Re: [libcamera-devel] [PATCH v3 2/2] libcamera: request: Use\n\texternal CameraControlValidator","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Wed, Oct 20, 2021 at 02:33:53PM +0100, Kieran Bingham wrote:\n> Each Request is currently creating its own CameraControlValidator\n> using the Camera instance at construction.\n> \n> Now that the Camera exposes its own CameraControlValidator on its\n> private interface, use that one on all Requests.\n> \n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> include/libcamera/request.h | 1 -\n> src/libcamera/request.cpp | 10 +++-------\n> 2 files changed, 3 insertions(+), 8 deletions(-)\n> \n> diff --git a/include/libcamera/request.h b/include/libcamera/request.h\n> index 2d361c9d97dc..d16904e6b679 100644\n> --- a/include/libcamera/request.h\n> +++ b/include/libcamera/request.h\n> @@ -71,7 +71,6 @@ private:\n> \tbool completeBuffer(FrameBuffer *buffer);\n> \n> \tCamera *camera_;\n> -\tCameraControlValidator *validator_;\n> \tControlList *controls_;\n> \tControlList *metadata_;\n> \tBufferMap bufferMap_;\n> diff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp\n> index f95ce4db5eaa..17fefab7ad0e 100644\n> --- a/src/libcamera/request.cpp\n> +++ b/src/libcamera/request.cpp\n> @@ -17,6 +17,7 @@\n> #include \n> #include \n> \n> +#include \"libcamera/internal/camera.h\"\n> #include \"libcamera/internal/camera_controls.h\"\n> #include \"libcamera/internal/framebuffer.h\"\n> #include \"libcamera/internal/tracepoints.h\"\n> @@ -77,12 +78,8 @@ Request::Request(Camera *camera, uint64_t cookie)\n> \t: camera_(camera), sequence_(0), cookie_(cookie),\n> \t status_(RequestPending), cancelled_(false)\n> {\n> -\t/**\n> -\t * \\todo Should the Camera expose a validator instance, to avoid\n> -\t * creating a new instance for each request?\n> -\t */\n> -\tvalidator_ = new CameraControlValidator(camera);\n> -\tcontrols_ = new ControlList(controls::controls, validator_);\n> +\tcontrols_ = new ControlList(controls::controls,\n> +\t\t\t\t camera->_d()->validator());\n> \n> \t/**\n> \t * \\todo: Add a validator for metadata controls.\n> @@ -100,7 +97,6 @@ Request::~Request()\n> \n> \tdelete metadata_;\n> \tdelete controls_;\n> -\tdelete validator_;\n> }\n> \n> /**","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 12698BDB1C\n\tfor ;\n\tFri, 22 Oct 2021 14:12:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C70EB68F59;\n\tFri, 22 Oct 2021 16:12:30 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9D9456012A\n\tfor ;\n\tFri, 22 Oct 2021 16:12:29 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 37E0D51D;\n\tFri, 22 Oct 2021 16:12:29 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"U6lbenme\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1634911949;\n\tbh=Z5Bf+Sz/w9b/EN5/c+uYogm8bCkTkpbjzQkxJgFMmpY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=U6lbenmeoMm36/tr+aZjjGYAetvVHOvjVJvchJUPxIdHX6ASohaxwrYeXImyulDdN\n\tFuNG7wN6aTwNH2C/T2nfRD46GjYgAVZ4rZWwuslpb0NYoqqFaWmkM27A4EMmAyW9Bt\n\tBv7J/nCdxpQl+C0I5JeAUlV8wsrGs5s5MxCvBf+c=","Date":"Fri, 22 Oct 2021 17:12:09 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"","References":"<20211020133353.2500082-1-kieran.bingham@ideasonboard.com>\n\t<20211020133353.2500082-3-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20211020133353.2500082-3-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v3 2/2] libcamera: request: Use\n\texternal CameraControlValidator","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]