[{"id":20395,"web_url":"https://patchwork.libcamera.org/comment/20395/","msgid":"","date":"2021-10-22T14:11:48","subject":"Re: [libcamera-devel] [PATCH v3 1/2] libcamera: camera: Create a\n\tCameraControlValidator","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Wed, Oct 20, 2021 at 02:33:52PM +0100, Kieran Bingham wrote:\n> Create a Camera specific CameraControlValidator for the Camera instance.\n\ns/Camera specific/Camera-specific/\n\n> This will allow requests to use a single validor instance without having\n\ns/validor/validator/\n\n> to construct their own.\n> \n> Signed-off-by: Kieran Bingham \n> \n> ---\n> v3:\n> - Use a unique_ptr instead of deriving from the _o/O_PTRs\n> \n> v2:\n> - Use LIBCAMERA_O_PTR() instead of _o()\n> ---\n> include/libcamera/internal/camera.h | 6 ++++++\n> src/libcamera/camera.cpp | 7 +++++++\n> 2 files changed, 13 insertions(+)\n> \n> diff --git a/include/libcamera/internal/camera.h b/include/libcamera/internal/camera.h\n> index 1a08da0cedc4..f0baaea07bdc 100644\n> --- a/include/libcamera/internal/camera.h\n> +++ b/include/libcamera/internal/camera.h\n> @@ -17,6 +17,8 @@\n> \n> #include \n> \n> +#include \"libcamera/internal/camera_controls.h\"\n\nYou could forward-declare the CameraControlValidator class here.\n\nReviewed-by: Laurent Pinchart \n\n> +\n> namespace libcamera {\n> \n> class PipelineHandler;\n> @@ -38,6 +40,8 @@ public:\n> \n> \tuint32_t requestSequence_;\n> \n> +\tconst CameraControlValidator *validator() const { return validator_.get(); }\n> +\n> private:\n> \tenum State {\n> \t\tCameraAvailable,\n> @@ -64,6 +68,8 @@ private:\n> \n> \tbool disconnected_;\n> \tstd::atomic state_;\n> +\n> +\tstd::unique_ptr validator_;\n> };\n> \n> } /* namespace libcamera */\n> diff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\n> index 71809bcd36a3..f84cdc522d0d 100644\n> --- a/src/libcamera/camera.cpp\n> +++ b/src/libcamera/camera.cpp\n> @@ -366,6 +366,12 @@ Camera::Private::~Private()\n> * \\return The pipeline handler that created this camera\n> */\n> \n> +/**\n> + * \\fn Camera::Private::validator()\n> + * \\brief Retrieve the control validator related to this camera\n> + * \\return The control validator associated with this camera\n> + */\n> +\n> /**\n> * \\var Camera::Private::queuedRequests_\n> * \\brief The list of queued and not yet completed requests\n> @@ -665,6 +671,7 @@ Camera::Camera(std::unique_ptr d, const std::string &id,\n> {\n> \t_d()->id_ = id;\n> \t_d()->streams_ = streams;\n> +\t_d()->validator_ = std::make_unique(this);\n> }\n> \n> Camera::~Camera()","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B7449BDB1C\n\tfor ;\n\tFri, 22 Oct 2021 14:12:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F2EDF68F59;\n\tFri, 22 Oct 2021 16:12:09 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8524E6012A\n\tfor ;\n\tFri, 22 Oct 2021 16:12:08 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 016B489A;\n\tFri, 22 Oct 2021 16:12:07 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ZcBF2SnP\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1634911928;\n\tbh=GiCZy6OjN90XCivdQC9tu6g/J7us5xX3n1Xv22yFTlU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=ZcBF2SnPZ4tFDwVgIXN+X1nJRC0rZOBwVwG6iH/Ib6QblSeL4PrE3F8tK4aWKyzaW\n\tJ9ytP+t2maQ7/LwaZqwwPZMyAjSQfurxfjbEsCcQ9bJyzWyF05le+g2k3Ahq4gyAmO\n\tR3ifl+ReBYB5voeIROel0QNKvK1U2XAE2MBhgEq0=","Date":"Fri, 22 Oct 2021 17:11:48 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"","References":"<20211020133353.2500082-1-kieran.bingham@ideasonboard.com>\n\t<20211020133353.2500082-2-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20211020133353.2500082-2-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v3 1/2] libcamera: camera: Create a\n\tCameraControlValidator","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":20397,"web_url":"https://patchwork.libcamera.org/comment/20397/","msgid":"<163491233080.110963.6450229393199329972@Monstersaurus>","date":"2021-10-22T14:18:50","subject":"Re: [libcamera-devel] [PATCH v3 1/2] libcamera: camera: Create a\n\tCameraControlValidator","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart (2021-10-22 15:11:48)\n> Hi Kieran,\n> \n> Thank you for the patch.\n> \n> On Wed, Oct 20, 2021 at 02:33:52PM +0100, Kieran Bingham wrote:\n> > Create a Camera specific CameraControlValidator for the Camera instance.\n> \n> s/Camera specific/Camera-specific/\n> \n> > This will allow requests to use a single validor instance without having\n> \n> s/validor/validator/\n> \n> > to construct their own.\n> > \n> > Signed-off-by: Kieran Bingham \n> > \n> > ---\n> > v3:\n> > - Use a unique_ptr instead of deriving from the _o/O_PTRs\n> > \n> > v2:\n> > - Use LIBCAMERA_O_PTR() instead of _o()\n> > ---\n> > include/libcamera/internal/camera.h | 6 ++++++\n> > src/libcamera/camera.cpp | 7 +++++++\n> > 2 files changed, 13 insertions(+)\n> > \n> > diff --git a/include/libcamera/internal/camera.h b/include/libcamera/internal/camera.h\n> > index 1a08da0cedc4..f0baaea07bdc 100644\n> > --- a/include/libcamera/internal/camera.h\n> > +++ b/include/libcamera/internal/camera.h\n> > @@ -17,6 +17,8 @@\n> > \n> > #include \n> > \n> > +#include \"libcamera/internal/camera_controls.h\"\n> \n> You could forward-declare the CameraControlValidator class here.\n\nGood point. I'll update that, it saves the compiler from loading a whole\nfile to compile this one.\n\n> Reviewed-by: Laurent Pinchart \n> \n> > +\n> > namespace libcamera {\n> > \n> > class PipelineHandler;\n> > @@ -38,6 +40,8 @@ public:\n> > \n> > uint32_t requestSequence_;\n> > \n> > + const CameraControlValidator *validator() const { return validator_.get(); }\n> > +\n> > private:\n> > enum State {\n> > CameraAvailable,\n> > @@ -64,6 +68,8 @@ private:\n> > \n> > bool disconnected_;\n> > std::atomic state_;\n> > +\n> > + std::unique_ptr validator_;\n> > };\n> > \n> > } /* namespace libcamera */\n> > diff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\n> > index 71809bcd36a3..f84cdc522d0d 100644\n> > --- a/src/libcamera/camera.cpp\n> > +++ b/src/libcamera/camera.cpp\n> > @@ -366,6 +366,12 @@ Camera::Private::~Private()\n> > * \\return The pipeline handler that created this camera\n> > */\n> > \n> > +/**\n> > + * \\fn Camera::Private::validator()\n> > + * \\brief Retrieve the control validator related to this camera\n> > + * \\return The control validator associated with this camera\n> > + */\n> > +\n> > /**\n> > * \\var Camera::Private::queuedRequests_\n> > * \\brief The list of queued and not yet completed requests\n> > @@ -665,6 +671,7 @@ Camera::Camera(std::unique_ptr d, const std::string &id,\n> > {\n> > _d()->id_ = id;\n> > _d()->streams_ = streams;\n> > + _d()->validator_ = std::make_unique(this);\n> > }\n> > \n> > Camera::~Camera()\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5E5E1BF415\n\tfor ;\n\tFri, 22 Oct 2021 14:18:56 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B822768F59;\n\tFri, 22 Oct 2021 16:18:55 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A10176012A\n\tfor ;\n\tFri, 22 Oct 2021 16:18:53 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2E1E651D;\n\tFri, 22 Oct 2021 16:18:53 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"E9rur463\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1634912333;\n\tbh=+RlBX+7AHPTh+1j0sJP790aqTNmRDdMAJ4Qq1cYQCXg=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=E9rur463ZznQiC+dmhHZXiPWYUJzR6/xEJgDvcmMGE8m4Ne/ZpuCy3DYA7nLS+nuh\n\t1ZivUWpCT2wWYBZSx8NDfSTQLCIFxBFMDwBtHMypwSnM9KGJScw8QnWSkcaYACYXlm\n\t0zCWH3LU1VxxHxilaKQLcZxzU5sewdT9mPgTX+0A=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"","References":"<20211020133353.2500082-1-kieran.bingham@ideasonboard.com>\n\t<20211020133353.2500082-2-kieran.bingham@ideasonboard.com>\n\t","From":"Kieran Bingham ","To":"Laurent Pinchart ","Date":"Fri, 22 Oct 2021 15:18:50 +0100","Message-ID":"<163491233080.110963.6450229393199329972@Monstersaurus>","User-Agent":"alot/0.9.1","Subject":"Re: [libcamera-devel] [PATCH v3 1/2] libcamera: camera: Create a\n\tCameraControlValidator","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]