[{"id":198,"web_url":"https://patchwork.libcamera.org/comment/198/","msgid":"<20190103213453.GJ22790@bigcity.dyn.berto.se>","date":"2019-01-03T21:34:54","subject":"Re: [libcamera-devel] [PATCH 8/9] libcamera: pipeline_handler:\n\tRemove unneeded forward declaration","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your patch.\n\nOn 2019-01-03 03:31:09 +0200, Laurent Pinchart wrote:\n> There's no need to forward-declare the PipelineManagerFactory class.\n> Remove it.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/include/pipeline_handler.h | 1 -\n> 1 file changed, 1 deletion(-)\n> \n> diff --git a/src/libcamera/include/pipeline_handler.h b/src/libcamera/include/pipeline_handler.h\n> index 00568c7052c0..fdf8b8db2e0a 100644\n> --- a/src/libcamera/include/pipeline_handler.h\n> +++ b/src/libcamera/include/pipeline_handler.h\n> @@ -16,7 +16,6 @@\n> namespace libcamera {\n> \n> class DeviceEnumerator;\n> -class PipelineHandlerFactory;\n> \n> class PipelineHandler\n> {\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lf1-x144.google.com (mail-lf1-x144.google.com\n\t[IPv6:2a00:1450:4864:20::144])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8A12960B21\n\tfor ;\n\tThu, 3 Jan 2019 22:34:55 +0100 (CET)","by mail-lf1-x144.google.com with SMTP id u18so24133130lff.10\n\tfor ;\n\tThu, 03 Jan 2019 13:34:55 -0800 (PST)","from localhost (89-233-230-99.cust.bredband2.com. [89.233.230.99])\n\tby smtp.gmail.com with ESMTPSA id\n\tx24-v6sm13183321ljc.54.2019.01.03.13.34.54\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tThu, 03 Jan 2019 13:34:54 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=ur6FppxRnJOslToD0yMeTxg803gpJvki5fBq4KQnBKA=;\n\tb=t4vTAaJmYF/5Sw8LjbJq83HIuSdZh/oX+gRe//oKwyCmbJ66/4DYRXFZfOxd5vEVyI\n\tTtiKq/GD45Uf2rOHjThUBxHBUgZ5eBwr/EWWmdMhGrj3T9gRqt2+nYGrsrKyqJMAVp/i\n\tju3O/4XlkdE7xuGom+eMUnd9419MeKycbhJijZhN+82bEwT6//DzWhWsk9c6M3KRGDlz\n\tz4tBpcZwD79LxvwNOdC/zfc3LKVSW4K31rYK2FYSQcmAf4mPl7MG7SiBFebjVk6M6o0x\n\trWczENwyaSsNpMhqg5/JaBdWNUr2VnoZBOJYuuk0NiOoUjgW8x9kMIksFkpOODwEmo4d\n\trA1w==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=ur6FppxRnJOslToD0yMeTxg803gpJvki5fBq4KQnBKA=;\n\tb=Un27Q5oXnD+3qxCkkni7wv2lvFfu4qO8sf52ztZ9HQ4yuXzfj7LP/n49n+QnnYl4ge\n\tAhMNEuEeFxDV0dmwe+IVYEYtnQLw5kDg64OcuZklp51TGyyiP0BIf4J9uI3Y7pMb4nuE\n\tPIV+XZ1BuPFl+5W8+oHa2HxlZjbHGXUjltagaJWgv3fgUkIqKG+uiktcioodBXjqROOZ\n\tCSjv3kXogFVvgdAl7r/t1IUe7UUbFf90Xl8liujMYrYXAnxtncLxXjYJMsw1GOuyzTIa\n\tqqNXbTR2zY27lnawB0sDlj6lwrN1KAdI3uj4gxzvCLTguhIqm3drIKZ0xts/HLQocAH+\n\tbXmQ==","X-Gm-Message-State":"AA+aEWYpkWzdm7CGf6AqxGzXIkNwoxkLVHn2eI26vdxIMHJhCEDQeRoV\n\t4FWFvY9jAA8RE8pfmfxxIhOvPA==","X-Google-Smtp-Source":"AFSGD/WpqhKqlH3ZXjnTn7g97tn8RlN3KvAO3n6OGlLL6rc6BCiUCygeLLYM4c1IZ5wclEdgOdOxTw==","X-Received":"by 2002:a19:9904:: with SMTP id b4mr23298034lfe.95.1546551294874;\n\tThu, 03 Jan 2019 13:34:54 -0800 (PST)","Date":"Thu, 3 Jan 2019 22:34:54 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190103213453.GJ22790@bigcity.dyn.berto.se>","References":"<20190103013110.6849-1-laurent.pinchart@ideasonboard.com>\n\t<20190103013110.6849-8-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190103013110.6849-8-laurent.pinchart@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 8/9] libcamera: pipeline_handler:\n\tRemove unneeded forward declaration","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 03 Jan 2019 21:34:55 -0000"}}]