{"id":14195,"url":"https://patchwork.libcamera.org/api/patches/14195/?format=json","web_url":"https://patchwork.libcamera.org/patch/14195/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20211020110825.12902-3-david.plowman@raspberrypi.com>","date":"2021-10-20T11:08:20","name":"[libcamera-devel,v3,2/7] libcamera: Add ColorSpace fields to StreamConfiguration","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"721865036c40d698c5350fead92bdfdb95e63940","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/?format=json","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/14195/mbox/","series":[{"id":2641,"url":"https://patchwork.libcamera.org/api/series/2641/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2641","date":"2021-10-20T11:08:18","name":"Colour spaces","version":3,"mbox":"https://patchwork.libcamera.org/series/2641/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/14195/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/14195/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 217D2BDB1C\n\tfor ;\n\tWed, 20 Oct 2021 11:08:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 19D1768F5B;\n\tWed, 20 Oct 2021 13:08:32 +0200 (CEST)","from mail-wm1-x336.google.com (mail-wm1-x336.google.com\n\t[IPv6:2a00:1450:4864:20::336])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 23D7368F58\n\tfor ;\n\tWed, 20 Oct 2021 13:08:29 +0200 (CEST)","by mail-wm1-x336.google.com with SMTP id g2so18090148wme.4\n\tfor ;\n\tWed, 20 Oct 2021 04:08:29 -0700 (PDT)","from pi4-davidp.pitowers.org\n\t([2a00:1098:3142:14:1ce1:9965:4328:89c4])\n\tby smtp.gmail.com with ESMTPSA id\n\tf20sm1929654wmq.38.2021.10.20.04.08.28\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 20 Oct 2021 04:08:28 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"KmTrBTsC\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=nUVlWu72PlyE29kbK+yxhDq/7AfELhGkPOIcJt8NS14=;\n\tb=KmTrBTsC6CaK6kGd5df/WRSVJooLx48YzdvXVCrLYDvaIXElorwpCXtCTxvHsDZPLV\n\tsolbmWcxJifES77xHy0E7qfD7fqVKE5Tx9rC5VrHkaIB1IRyhGbeiH57AlDUvmLRlg9S\n\td7l83XMnywzBtQ//tlq10NqPLgQx1G/ua6uTWw2xbT6BILUkP6T9qbkTC8kyMAX+JYN9\n\tuZLKu1yxztYhBdakyDUfJfN1946phBF5g/CPSObEVfAJzfee6mEv4Xg5zJnyqpzWZpYg\n\tu/DQiPkEny7To0f2XxrCQuLovpaH7tcEa6CbjeLfn9LcbXmuBUnwrgkjmuA+P9CLodaS\n\tHFjQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=nUVlWu72PlyE29kbK+yxhDq/7AfELhGkPOIcJt8NS14=;\n\tb=e+2mvxgWD4z7e23oD3Tw0s4mq6nefxLn48kb+crIeR4hpsl2T+xWfRZ3sQCwTpokIA\n\tjlyXSUSndkKFpT14LcvKLDpf5LMLVSaWJuIiNtTGhqKhynVMGUf5I8nlemCslY13+v4y\n\tRkx/ud93oOSOdnZdv3Kz/Twh4WsR9qhODGQkyTI6dYGrSSC7LgKZkn1VXI7vcES3ctPW\n\t+bs4T1HLzLAy4kDjkyGZYJX8w3KVBRQyOGR5twDlb2ZsJOFuqIg0njhfzo4RB58YfZpq\n\tsuhuE/eua1BVy8bYjerOXdAalmdzMR3/MA0mt2o1C2T6omV3Z64eac4CHan+icsdbWjZ\n\tPaCw==","X-Gm-Message-State":"AOAM532u4eYF2XTjaYpp3C+6wLhTGAvaNGetaPUA4BbnxjhJynUFPJT5\n\tAqUYHbZlPKHGIXnn7Xb2QEeHhubFMjxOFQ==","X-Google-Smtp-Source":"ABdhPJz4Y1+1ud+c4h2HWUAtVPpVoEiOEs4Rm9WJ552WWh5awsREnIl3MfRvDkq4aCgd8P6pipVVqQ==","X-Received":"by 2002:adf:ca09:: with SMTP id\n\to9mr49890012wrh.303.1634728108715; \n\tWed, 20 Oct 2021 04:08:28 -0700 (PDT)","From":"David Plowman ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 20 Oct 2021 12:08:20 +0100","Message-Id":"<20211020110825.12902-3-david.plowman@raspberrypi.com>","X-Mailer":"git-send-email 2.20.1","In-Reply-To":"<20211020110825.12902-1-david.plowman@raspberrypi.com>","References":"<20211020110825.12902-1-david.plowman@raspberrypi.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v3 2/7] libcamera: Add ColorSpace fields\n\tto StreamConfiguration","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"This is so that applications can choose appropriate color spaces which\nwill then be passed down to the V4L2 devices.\n\nThere are two fields: the \"requestedColorSpace\" which is the one an\napplication wants, and the \"actualColorSpace\" which is what the\nunderlying hardware can deliver, and which is filled in by the\nvalidate() method.\n\nSigned-off-by: David Plowman \n---\n include/libcamera/stream.h | 4 ++++\n src/libcamera/stream.cpp | 25 +++++++++++++++++++++++++\n 2 files changed, 29 insertions(+)","diff":"diff --git a/include/libcamera/stream.h b/include/libcamera/stream.h\nindex 0c55e716..fe491ff5 100644\n--- a/include/libcamera/stream.h\n+++ b/include/libcamera/stream.h\n@@ -12,6 +12,7 @@\n #include \n #include \n \n+#include \n #include \n #include \n #include \n@@ -47,6 +48,9 @@ struct StreamConfiguration {\n \n \tunsigned int bufferCount;\n \n+\tColorSpace requestedColorSpace;\n+\tColorSpace actualColorSpace;\n+\n \tStream *stream() const { return stream_; }\n \tvoid setStream(Stream *stream) { stream_ = stream; }\n \tconst StreamFormats &formats() const { return formats_; }\ndiff --git a/src/libcamera/stream.cpp b/src/libcamera/stream.cpp\nindex b421e17e..1ddbbb8c 100644\n--- a/src/libcamera/stream.cpp\n+++ b/src/libcamera/stream.cpp\n@@ -329,6 +329,31 @@ StreamConfiguration::StreamConfiguration(const StreamFormats &formats)\n * \\brief Requested number of buffers to allocate for the stream\n */\n \n+/**\n+ * \\var StreamConfiguration::requestedColorSpace\n+ * \\brief The ColorSpace this stream should have\n+ *\n+ * The generateConfiguration method will generate reasonable default\n+ * values (ColorSpace::Jpeg for stills, ColorSpace::Rec709 for video and\n+ * ColorSpace::Raw for raw streams) but applications are free to overwrite\n+ * this value.\n+ */\n+\n+/**\n+ * \\var StreamConfiguration::actualColorSpace\n+ * \\brief The ColorSpace the will be used for this stream\n+ *\n+ * This field is filled in by CameraConfiguration::validate().\n+ * Normally this should match the requestedColorSpace, but it may differ\n+ * if the hardware does not support it.\n+ *\n+ * In general cameras may have different constraints here, for example,\n+ * they may require all output streams to share the same color space.\n+ * Sometimes the fields within this color space may report \"Undefined\"\n+ * values if the hardware drivers are going to use a color space that\n+ * is not recognised by the ColorSpace class.\n+ */\n+\n /**\n * \\fn StreamConfiguration::stream()\n * \\brief Retrieve the stream associated with the configuration\n","prefixes":["libcamera-devel","v3","2/7"]}