[{"id":20324,"web_url":"https://patchwork.libcamera.org/comment/20324/","msgid":"<66a4c5c3-e90c-8822-066f-203d8f7ca9f3@ideasonboard.com>","date":"2021-10-20T03:53:05","subject":"Re: [libcamera-devel] [PATCH] android: camera_device: Cleanup\n\theader includes","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Laurent,\n\nThank you for this patch\n\nOn 10/20/21 8:58 AM, Laurent Pinchart wrote:\n> camera_device.cpp doesn't use the PostProcessor class, the\n> post_processor.h header shouldn't be included. Removing it causes a\n> compilation failure as the CameraBuffer class is not defined anymore,\n> include camera_buffer.h instead.\n>\n> Signed-off-by: Laurent Pinchart \n\n\nI was carrying this change in my post-processor-async branch so,\n\nReviewed-by: Umang Jain \n\n> ---\n> src/android/camera_device.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index ea676409b474..806b40908e98 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -24,10 +24,10 @@\n> \n> #include \"system/graphics.h\"\n> \n> +#include \"camera_buffer.h\"\n> #include \"camera_hal_config.h\"\n> #include \"camera_ops.h\"\n> #include \"camera_request.h\"\n> -#include \"post_processor.h\"\n> \n> using namespace libcamera;\n> \n>\n> base-commit: a31c8f02b9965ebe5b7d4347e4316172e4b7e8d0","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 93668BF415\n\tfor ;\n\tWed, 20 Oct 2021 03:53:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1F20268F59;\n\tWed, 20 Oct 2021 05:53:12 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6AE0660125\n\tfor ;\n\tWed, 20 Oct 2021 05:53:10 +0200 (CEST)","from [192.168.1.106] (unknown [103.251.226.186])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7771C2A5;\n\tWed, 20 Oct 2021 05:53:09 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"MRDIpaKD\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1634701990;\n\tbh=HLoVTjofaRp0wrBSjoJwxPJbxC0fHRfCCeHSHVJ2KN8=;\n\th=Subject:To:References:From:Date:In-Reply-To:From;\n\tb=MRDIpaKDLAn+FzTkJIJzhhLAGqIZK55X4u+rpqUvohPMvDhX4qSlPMnwiV4+fDcIO\n\tvgFAj0B5NZXnnq3NmM04ST6AMhaH2pincVLI25pDqGC9YWO7EzgT4Sjjoao4+/IxfQ\n\tnZu08H/jXjCsfy5bFeFZVvA1reiQBZFgholL6rIk=","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20211020032858.21806-1-laurent.pinchart@ideasonboard.com>","From":"Umang Jain ","Message-ID":"<66a4c5c3-e90c-8822-066f-203d8f7ca9f3@ideasonboard.com>","Date":"Wed, 20 Oct 2021 09:23:05 +0530","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.10.2","MIME-Version":"1.0","In-Reply-To":"<20211020032858.21806-1-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"7bit","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH] android: camera_device: Cleanup\n\theader includes","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":20326,"web_url":"https://patchwork.libcamera.org/comment/20326/","msgid":"","date":"2021-10-20T04:03:35","subject":"Re: [libcamera-devel] [PATCH] android: camera_device: Cleanup\n\theader includes","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"content":"HI Laurent, thank you for the patch.\n\nOn Wed, Oct 20, 2021 at 12:53 PM Umang Jain wrote:\n>\n> Hi Laurent,\n>\n> Thank you for this patch\n>\n> On 10/20/21 8:58 AM, Laurent Pinchart wrote:\n> > camera_device.cpp doesn't use the PostProcessor class, the\n> > post_processor.h header shouldn't be included. Removing it causes a\n> > compilation failure as the CameraBuffer class is not defined anymore,\n> > include camera_buffer.h instead.\n> >\n> > Signed-off-by: Laurent Pinchart \n>\n>\n> I was carrying this change in my post-processor-async branch so,\n>\n> Reviewed-by: Umang Jain \n>\n\nReviewed-by: Hirokazu Honda \n\n> > ---\n> > src/android/camera_device.cpp | 2 +-\n> > 1 file changed, 1 insertion(+), 1 deletion(-)\n> >\n> > diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> > index ea676409b474..806b40908e98 100644\n> > --- a/src/android/camera_device.cpp\n> > +++ b/src/android/camera_device.cpp\n> > @@ -24,10 +24,10 @@\n> >\n> > #include \"system/graphics.h\"\n> >\n> > +#include \"camera_buffer.h\"\n> > #include \"camera_hal_config.h\"\n> > #include \"camera_ops.h\"\n> > #include \"camera_request.h\"\n> > -#include \"post_processor.h\"\n> >\n> > using namespace libcamera;\n> >\n> >\n> > base-commit: a31c8f02b9965ebe5b7d4347e4316172e4b7e8d0","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 47675BF415\n\tfor ;\n\tWed, 20 Oct 2021 04:03:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9693C68F59;\n\tWed, 20 Oct 2021 06:03:48 +0200 (CEST)","from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com\n\t[IPv6:2a00:1450:4864:20::52a])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 90E1560125\n\tfor ;\n\tWed, 20 Oct 2021 06:03:47 +0200 (CEST)","by mail-ed1-x52a.google.com with SMTP id g10so20578813edj.1\n\tfor ;\n\tTue, 19 Oct 2021 21:03:47 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"H4OID00U\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=7oEptMRlw9ZfQMkcR34PPObuyozy2BbaRE9kbzeDkgg=;\n\tb=H4OID00URJNblLve4Sg/mVPwmZSXztXRwGPbl5SbIZ5GY2JKpYEIpBddC9X6B2gNID\n\t5XOiv+kMaD9or1w+9jd5uRKebmomiqFczHnNNxkdC3Ng3Ewqe89qEALNX6gdwtKvE0kG\n\t2/iPlAPu32GLkRqB1d16FiyVN9V1efgqsOUAw=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=7oEptMRlw9ZfQMkcR34PPObuyozy2BbaRE9kbzeDkgg=;\n\tb=kUpizDInO7UVk0IL5JuopXwRUTfaeSbJCiar2qef5eypj9KMX9ByBUED4IIc8JgVNb\n\tGRO2JLkcLHEDoYkPQTa7os26uFUaoY9qyMOEXhUW/FK6tvGH/qL9SLdN6PWtt9Lc8Ac6\n\tNI/CYEn6crR13Vm1gklwWYdYFMTxgzJFUP7oBRwP41ncT3+J6+tcMlSWrfqC1nBN49N6\n\tpo/iTksVmSRgCKUOq2VcJycBTWcvS4E1K4PNxKYK4oyBt4mm20nMkFmJ4fS0fM5gK3hd\n\ttN+bJ0c1FafPAT3Z6O+AEFBB0x1kKIDibAcO3BS4djS0+CI+vPh2npskE9VtqZMKwTgc\n\tMgPw==","X-Gm-Message-State":"AOAM530nPtMTIyPzUBGHwYmEn0GyQRO3tmA3B/9KWg9TLGY9LUpwpsmz\n\tYabGFiISI6L8LxKkTK/bFfDB7c23+rMiPC8ne10k1A==","X-Google-Smtp-Source":"ABdhPJwLbXXuYi31UYIVlMpPvpFCq0QLwTMy9V6f8p7vGKPbkXCkqtaYMPWTQojfOP1UZ5KcG1p8bMJ42KAW35sGpvk=","X-Received":"by 2002:a05:6402:3554:: with SMTP id\n\tf20mr59509783edd.354.1634702626855; \n\tTue, 19 Oct 2021 21:03:46 -0700 (PDT)","MIME-Version":"1.0","References":"<20211020032858.21806-1-laurent.pinchart@ideasonboard.com>\n\t<66a4c5c3-e90c-8822-066f-203d8f7ca9f3@ideasonboard.com>","In-Reply-To":"<66a4c5c3-e90c-8822-066f-203d8f7ca9f3@ideasonboard.com>","From":"Hirokazu Honda ","Date":"Wed, 20 Oct 2021 13:03:35 +0900","Message-ID":"","To":"Umang Jain ","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH] android: camera_device: Cleanup\n\theader includes","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]