{"id":14187,"url":"https://patchwork.libcamera.org/api/patches/14187/?format=json","web_url":"https://patchwork.libcamera.org/patch/14187/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20211020032858.21806-1-laurent.pinchart@ideasonboard.com>","date":"2021-10-20T03:28:58","name":"[libcamera-devel] android: camera_device: Cleanup header includes","commit_ref":"f407027451bd5b031055e6fc1de0c29163bbe531","pull_url":null,"state":"accepted","archived":false,"hash":"81abee6f2be2a391b0ae6b6d8906a0d7d56c99ed","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/14187/mbox/","series":[{"id":2639,"url":"https://patchwork.libcamera.org/api/series/2639/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2639","date":"2021-10-20T03:28:58","name":"[libcamera-devel] android: camera_device: Cleanup header includes","version":1,"mbox":"https://patchwork.libcamera.org/series/2639/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/14187/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/14187/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2627CBDB1C\n\tfor ;\n\tWed, 20 Oct 2021 03:29:22 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7B9C568F59;\n\tWed, 20 Oct 2021 05:29:21 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6AB1C60125\n\tfor ;\n\tWed, 20 Oct 2021 05:29:20 +0200 (CEST)","from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DAA5A2A5\n\tfor ;\n\tWed, 20 Oct 2021 05:29:19 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"mzrK0D99\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1634700560;\n\tbh=0xj2zoJRpZp41TJb/ZvnjVlHD1W4HTD8YVVNPOch7sc=;\n\th=From:To:Subject:Date:From;\n\tb=mzrK0D99xnWefHh3C0RK4CnvQyRC9Dmbondk3+gEphu/iLfjDZJKx/DlX5NbN7jz5\n\tllf1EHUT6+TSC7KSwuq4/2lV+gEwacKklXaLsdjKGOi0CGWPmrGSbyN3XPOEcAGad3\n\tMB2fycNY32v38LfIv6+UoMC9+bH712sN6wjzHuXw=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 20 Oct 2021 06:28:58 +0300","Message-Id":"<20211020032858.21806-1-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.32.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH] android: camera_device: Cleanup header\n\tincludes","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"camera_device.cpp doesn't use the PostProcessor class, the\npost_processor.h header shouldn't be included. Removing it causes a\ncompilation failure as the CameraBuffer class is not defined anymore,\ninclude camera_buffer.h instead.\n\nSigned-off-by: Laurent Pinchart \n---\n src/android/camera_device.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\n\nbase-commit: a31c8f02b9965ebe5b7d4347e4316172e4b7e8d0","diff":"diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex ea676409b474..806b40908e98 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -24,10 +24,10 @@\n \n #include \"system/graphics.h\"\n \n+#include \"camera_buffer.h\"\n #include \"camera_hal_config.h\"\n #include \"camera_ops.h\"\n #include \"camera_request.h\"\n-#include \"post_processor.h\"\n \n using namespace libcamera;\n \n","prefixes":["libcamera-devel"]}