[{"id":20302,"web_url":"https://patchwork.libcamera.org/comment/20302/","msgid":"","date":"2021-10-19T11:49:34","subject":"Re: [libcamera-devel] [PATCH v2 12/12] android: camera_metadata:\n\tRename get() to getMetadata()","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"HiUmang,\n\nThank you for the patch.\n\nOn Tue, Oct 19, 2021 at 05:18:02PM +0530, Umang Jain wrote:\n> Rename CameraMetadata::get() to CameraMetadata::getMetadata()\n> to avoid confusion with std::unique_ptr::get() when CameraMetadata\n> is used with a std::unique_ptr.\n> \n> No functional changes intended in this patch.\n> \n> Signed-off-by: Umang Jain \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/android/camera_device.cpp | 9 +++++----\n> src/android/camera_metadata.cpp | 8 ++++----\n> src/android/camera_metadata.h | 4 ++--\n> 3 files changed, 11 insertions(+), 10 deletions(-)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index 0a2d3826..ea676409 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -440,7 +440,7 @@ void CameraDevice::setCallbacks(const camera3_callback_ops_t *callbacks)\n> \n> const camera_metadata_t *CameraDevice::getStaticMetadata()\n> {\n> -\treturn capabilities_.staticMetadata()->get();\n> +\treturn capabilities_.staticMetadata()->getMetadata();\n> }\n> \n> /*\n> @@ -450,7 +450,7 @@ const camera_metadata_t *CameraDevice::constructDefaultRequestSettings(int type)\n> {\n> \tauto it = requestTemplates_.find(type);\n> \tif (it != requestTemplates_.end())\n> -\t\treturn it->second->get();\n> +\t\treturn it->second->getMetadata();\n> \n> \t/* Use the capture intent matching the requested template type. */\n> \tstd::unique_ptr requestTemplate;\n> @@ -496,7 +496,7 @@ const camera_metadata_t *CameraDevice::constructDefaultRequestSettings(int type)\n> \t\t\t\t captureIntent);\n> \n> \trequestTemplates_[type] = std::move(requestTemplate);\n> -\treturn requestTemplates_[type]->get();\n> +\treturn requestTemplates_[type]->getMetadata();\n> }\n> \n> /*\n> @@ -1171,7 +1171,8 @@ void CameraDevice::sendCaptureResults()\n> \t\tcaptureResult.frame_number = descriptor->frameNumber_;\n> \n> \t\tif (descriptor->resultMetadata_)\n> -\t\t\tcaptureResult.result = descriptor->resultMetadata_->get();\n> +\t\t\tcaptureResult.result =\n> +\t\t\t\tdescriptor->resultMetadata_->getMetadata();\n> \n> \t\tstd::vector resultBuffers;\n> \t\tresultBuffers.reserve(descriptor->buffers_.size());\n> diff --git a/src/android/camera_metadata.cpp b/src/android/camera_metadata.cpp\n> index 075b6a22..b3e515d2 100644\n> --- a/src/android/camera_metadata.cpp\n> +++ b/src/android/camera_metadata.cpp\n> @@ -33,7 +33,7 @@ CameraMetadata::CameraMetadata(const camera_metadata_t *metadata)\n> }\n> \n> CameraMetadata::CameraMetadata(const CameraMetadata &other)\n> -\t: CameraMetadata(other.get())\n> +\t: CameraMetadata(other.getMetadata())\n> {\n> }\n> \n> @@ -51,7 +51,7 @@ CameraMetadata &CameraMetadata::operator=(const CameraMetadata &other)\n> \tif (metadata_)\n> \t\tfree_camera_metadata(metadata_);\n> \n> -\tmetadata_ = clone_camera_metadata(other.get());\n> +\tmetadata_ = clone_camera_metadata(other.getMetadata());\n> \tvalid_ = metadata_ != nullptr;\n> \n> \treturn *this;\n> @@ -220,12 +220,12 @@ bool CameraMetadata::updateEntry(uint32_t tag, const void *data, size_t count,\n> \treturn false;\n> }\n> \n> -camera_metadata_t *CameraMetadata::get()\n> +camera_metadata_t *CameraMetadata::getMetadata()\n> {\n> \treturn valid_ ? metadata_ : nullptr;\n> }\n> \n> -const camera_metadata_t *CameraMetadata::get() const\n> +const camera_metadata_t *CameraMetadata::getMetadata() const\n> {\n> \treturn valid_ ? metadata_ : nullptr;\n> }\n> diff --git a/src/android/camera_metadata.h b/src/android/camera_metadata.h\n> index 60be416c..8555c7c3 100644\n> --- a/src/android/camera_metadata.h\n> +++ b/src/android/camera_metadata.h\n> @@ -85,8 +85,8 @@ public:\n> \t\treturn updateEntry(tag, data, count, sizeof(T));\n> \t}\n> \n> -\tcamera_metadata_t *get();\n> -\tconst camera_metadata_t *get() const;\n> +\tcamera_metadata_t *getMetadata();\n> +\tconst camera_metadata_t *getMetadata() const;\n> \n> private:\n> \tbool resize(size_t count, size_t size);","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 665E8C324C\n\tfor ;\n\tTue, 19 Oct 2021 11:49:54 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2F4E268F59;\n\tTue, 19 Oct 2021 13:49:54 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A83EA604FE\n\tfor ;\n\tTue, 19 Oct 2021 13:49:52 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4011B12A;\n\tTue, 19 Oct 2021 13:49:52 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"KtShVj33\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1634644192;\n\tbh=8CE8sMD9LlPN6q4hNGMK67S9V9ifUIv9KRWgyCojcbk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=KtShVj33YUf6sNnvqP1YT8yPvL5SpowAwaqhvGhvpBJupYBlt6tSubE6KgLXQPcG3\n\tq9kvB/anTPOw15oiK7M7Zcd1W0T/lLODu4EqW2I34Q7fgoL1LDNm8jUeQxxyswwF93\n\t5aRfKqPoRGtNxVOCCTJI6RopCFlmt8OSxmqeZDlk=","Date":"Tue, 19 Oct 2021 14:49:34 +0300","From":"Laurent Pinchart ","To":"Umang Jain ","Message-ID":"","References":"<20211019114802.665980-1-umang.jain@ideasonboard.com>\n\t<20211019114802.665980-13-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20211019114802.665980-13-umang.jain@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 12/12] android: camera_metadata:\n\tRename get() to getMetadata()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":20304,"web_url":"https://patchwork.libcamera.org/comment/20304/","msgid":"<20211019120123.teolse365a7m5mbx@uno.localdomain>","date":"2021-10-19T12:01:23","subject":"Re: [libcamera-devel] [PATCH v2 12/12] android: camera_metadata:\n\tRename get() to getMetadata()","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Umang,\n\nOn Tue, Oct 19, 2021 at 05:18:02PM +0530, Umang Jain wrote:\n> Rename CameraMetadata::get() to CameraMetadata::getMetadata()\n> to avoid confusion with std::unique_ptr::get() when CameraMetadata\n> is used with a std::unique_ptr.\n>\n> No functional changes intended in this patch.\n\nThanks :)\n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n>\n> Signed-off-by: Umang Jain \n> ---\n> src/android/camera_device.cpp | 9 +++++----\n> src/android/camera_metadata.cpp | 8 ++++----\n> src/android/camera_metadata.h | 4 ++--\n> 3 files changed, 11 insertions(+), 10 deletions(-)\n>\n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index 0a2d3826..ea676409 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -440,7 +440,7 @@ void CameraDevice::setCallbacks(const camera3_callback_ops_t *callbacks)\n>\n> const camera_metadata_t *CameraDevice::getStaticMetadata()\n> {\n> -\treturn capabilities_.staticMetadata()->get();\n> +\treturn capabilities_.staticMetadata()->getMetadata();\n> }\n>\n> /*\n> @@ -450,7 +450,7 @@ const camera_metadata_t *CameraDevice::constructDefaultRequestSettings(int type)\n> {\n> \tauto it = requestTemplates_.find(type);\n> \tif (it != requestTemplates_.end())\n> -\t\treturn it->second->get();\n> +\t\treturn it->second->getMetadata();\n>\n> \t/* Use the capture intent matching the requested template type. */\n> \tstd::unique_ptr requestTemplate;\n> @@ -496,7 +496,7 @@ const camera_metadata_t *CameraDevice::constructDefaultRequestSettings(int type)\n> \t\t\t\t captureIntent);\n>\n> \trequestTemplates_[type] = std::move(requestTemplate);\n> -\treturn requestTemplates_[type]->get();\n> +\treturn requestTemplates_[type]->getMetadata();\n> }\n>\n> /*\n> @@ -1171,7 +1171,8 @@ void CameraDevice::sendCaptureResults()\n> \t\tcaptureResult.frame_number = descriptor->frameNumber_;\n>\n> \t\tif (descriptor->resultMetadata_)\n> -\t\t\tcaptureResult.result = descriptor->resultMetadata_->get();\n> +\t\t\tcaptureResult.result =\n> +\t\t\t\tdescriptor->resultMetadata_->getMetadata();\n>\n> \t\tstd::vector resultBuffers;\n> \t\tresultBuffers.reserve(descriptor->buffers_.size());\n> diff --git a/src/android/camera_metadata.cpp b/src/android/camera_metadata.cpp\n> index 075b6a22..b3e515d2 100644\n> --- a/src/android/camera_metadata.cpp\n> +++ b/src/android/camera_metadata.cpp\n> @@ -33,7 +33,7 @@ CameraMetadata::CameraMetadata(const camera_metadata_t *metadata)\n> }\n>\n> CameraMetadata::CameraMetadata(const CameraMetadata &other)\n> -\t: CameraMetadata(other.get())\n> +\t: CameraMetadata(other.getMetadata())\n> {\n> }\n>\n> @@ -51,7 +51,7 @@ CameraMetadata &CameraMetadata::operator=(const CameraMetadata &other)\n> \tif (metadata_)\n> \t\tfree_camera_metadata(metadata_);\n>\n> -\tmetadata_ = clone_camera_metadata(other.get());\n> +\tmetadata_ = clone_camera_metadata(other.getMetadata());\n> \tvalid_ = metadata_ != nullptr;\n>\n> \treturn *this;\n> @@ -220,12 +220,12 @@ bool CameraMetadata::updateEntry(uint32_t tag, const void *data, size_t count,\n> \treturn false;\n> }\n>\n> -camera_metadata_t *CameraMetadata::get()\n> +camera_metadata_t *CameraMetadata::getMetadata()\n> {\n> \treturn valid_ ? metadata_ : nullptr;\n> }\n>\n> -const camera_metadata_t *CameraMetadata::get() const\n> +const camera_metadata_t *CameraMetadata::getMetadata() const\n> {\n> \treturn valid_ ? metadata_ : nullptr;\n> }\n> diff --git a/src/android/camera_metadata.h b/src/android/camera_metadata.h\n> index 60be416c..8555c7c3 100644\n> --- a/src/android/camera_metadata.h\n> +++ b/src/android/camera_metadata.h\n> @@ -85,8 +85,8 @@ public:\n> \t\treturn updateEntry(tag, data, count, sizeof(T));\n> \t}\n>\n> -\tcamera_metadata_t *get();\n> -\tconst camera_metadata_t *get() const;\n> +\tcamera_metadata_t *getMetadata();\n> +\tconst camera_metadata_t *getMetadata() const;\n>\n> private:\n> \tbool resize(size_t count, size_t size);\n> --\n> 2.31.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4F1F5BF415\n\tfor ;\n\tTue, 19 Oct 2021 12:00:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B285368F59;\n\tTue, 19 Oct 2021 14:00:34 +0200 (CEST)","from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net\n\t[217.70.183.195])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 238A3604FE\n\tfor ;\n\tTue, 19 Oct 2021 14:00:34 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 9164F60010;\n\tTue, 19 Oct 2021 12:00:33 +0000 (UTC)"],"Date":"Tue, 19 Oct 2021 14:01:23 +0200","From":"Jacopo Mondi ","To":"Umang Jain ","Message-ID":"<20211019120123.teolse365a7m5mbx@uno.localdomain>","References":"<20211019114802.665980-1-umang.jain@ideasonboard.com>\n\t<20211019114802.665980-13-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20211019114802.665980-13-umang.jain@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 12/12] android: camera_metadata:\n\tRename get() to getMetadata()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":20312,"web_url":"https://patchwork.libcamera.org/comment/20312/","msgid":"","date":"2021-10-20T02:17:17","subject":"Re: [libcamera-devel] [PATCH v2 12/12] android: camera_metadata:\n\tRename get() to getMetadata()","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"content":"Hi Umang, thank you for the patch.\n\nOn Tue, Oct 19, 2021 at 9:00 PM Jacopo Mondi wrote:\n>\n> Hi Umang,\n>\n> On Tue, Oct 19, 2021 at 05:18:02PM +0530, Umang Jain wrote:\n> > Rename CameraMetadata::get() to CameraMetadata::getMetadata()\n> > to avoid confusion with std::unique_ptr::get() when CameraMetadata\n> > is used with a std::unique_ptr.\n> >\n> > No functional changes intended in this patch.\n>\n\nReviewed-by: Hirokazu Honda \n\n> Thanks :)\n>\n> Reviewed-by: Jacopo Mondi \n>\n> Thanks\n> j\n>\n> >\n> > Signed-off-by: Umang Jain \n> > ---\n> > src/android/camera_device.cpp | 9 +++++----\n> > src/android/camera_metadata.cpp | 8 ++++----\n> > src/android/camera_metadata.h | 4 ++--\n> > 3 files changed, 11 insertions(+), 10 deletions(-)\n> >\n> > diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> > index 0a2d3826..ea676409 100644\n> > --- a/src/android/camera_device.cpp\n> > +++ b/src/android/camera_device.cpp\n> > @@ -440,7 +440,7 @@ void CameraDevice::setCallbacks(const camera3_callback_ops_t *callbacks)\n> >\n> > const camera_metadata_t *CameraDevice::getStaticMetadata()\n> > {\n> > - return capabilities_.staticMetadata()->get();\n> > + return capabilities_.staticMetadata()->getMetadata();\n> > }\n> >\n> > /*\n> > @@ -450,7 +450,7 @@ const camera_metadata_t *CameraDevice::constructDefaultRequestSettings(int type)\n> > {\n> > auto it = requestTemplates_.find(type);\n> > if (it != requestTemplates_.end())\n> > - return it->second->get();\n> > + return it->second->getMetadata();\n> >\n> > /* Use the capture intent matching the requested template type. */\n> > std::unique_ptr requestTemplate;\n> > @@ -496,7 +496,7 @@ const camera_metadata_t *CameraDevice::constructDefaultRequestSettings(int type)\n> > captureIntent);\n> >\n> > requestTemplates_[type] = std::move(requestTemplate);\n> > - return requestTemplates_[type]->get();\n> > + return requestTemplates_[type]->getMetadata();\n> > }\n> >\n> > /*\n> > @@ -1171,7 +1171,8 @@ void CameraDevice::sendCaptureResults()\n> > captureResult.frame_number = descriptor->frameNumber_;\n> >\n> > if (descriptor->resultMetadata_)\n> > - captureResult.result = descriptor->resultMetadata_->get();\n> > + captureResult.result =\n> > + descriptor->resultMetadata_->getMetadata();\n> >\n> > std::vector resultBuffers;\n> > resultBuffers.reserve(descriptor->buffers_.size());\n> > diff --git a/src/android/camera_metadata.cpp b/src/android/camera_metadata.cpp\n> > index 075b6a22..b3e515d2 100644\n> > --- a/src/android/camera_metadata.cpp\n> > +++ b/src/android/camera_metadata.cpp\n> > @@ -33,7 +33,7 @@ CameraMetadata::CameraMetadata(const camera_metadata_t *metadata)\n> > }\n> >\n> > CameraMetadata::CameraMetadata(const CameraMetadata &other)\n> > - : CameraMetadata(other.get())\n> > + : CameraMetadata(other.getMetadata())\n> > {\n> > }\n> >\n> > @@ -51,7 +51,7 @@ CameraMetadata &CameraMetadata::operator=(const CameraMetadata &other)\n> > if (metadata_)\n> > free_camera_metadata(metadata_);\n> >\n> > - metadata_ = clone_camera_metadata(other.get());\n> > + metadata_ = clone_camera_metadata(other.getMetadata());\n> > valid_ = metadata_ != nullptr;\n> >\n> > return *this;\n> > @@ -220,12 +220,12 @@ bool CameraMetadata::updateEntry(uint32_t tag, const void *data, size_t count,\n> > return false;\n> > }\n> >\n> > -camera_metadata_t *CameraMetadata::get()\n> > +camera_metadata_t *CameraMetadata::getMetadata()\n> > {\n> > return valid_ ? metadata_ : nullptr;\n> > }\n> >\n> > -const camera_metadata_t *CameraMetadata::get() const\n> > +const camera_metadata_t *CameraMetadata::getMetadata() const\n> > {\n> > return valid_ ? metadata_ : nullptr;\n> > }\n> > diff --git a/src/android/camera_metadata.h b/src/android/camera_metadata.h\n> > index 60be416c..8555c7c3 100644\n> > --- a/src/android/camera_metadata.h\n> > +++ b/src/android/camera_metadata.h\n> > @@ -85,8 +85,8 @@ public:\n> > return updateEntry(tag, data, count, sizeof(T));\n> > }\n> >\n> > - camera_metadata_t *get();\n> > - const camera_metadata_t *get() const;\n> > + camera_metadata_t *getMetadata();\n> > + const camera_metadata_t *getMetadata() const;\n> >\n> > private:\n> > bool resize(size_t count, size_t size);\n> > --\n> > 2.31.0\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6C10DBF415\n\tfor ;\n\tWed, 20 Oct 2021 02:17:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E2FB868F59;\n\tWed, 20 Oct 2021 04:17:28 +0200 (CEST)","from mail-ed1-x534.google.com (mail-ed1-x534.google.com\n\t[IPv6:2a00:1450:4864:20::534])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2E76860125\n\tfor ;\n\tWed, 20 Oct 2021 04:17:28 +0200 (CEST)","by mail-ed1-x534.google.com with SMTP id y12so22165453eda.4\n\tfor ;\n\tTue, 19 Oct 2021 19:17:28 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"iqCVHQtw\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=58Yy4jJ7URGuBLlX6dhSK2gh+jMkSo/YS/TtF0sMNrQ=;\n\tb=iqCVHQtwZh4Ji6j7/AHJaMGiQEqjxn1E8TN64aNpDABULkRnyZ+28bhHkhJQqvnhML\n\t3lvM7UuOJuknwdYu7MdSX700YQfQ7kdl0png7qyeRC4OHV87nxGqPyE1j/kp4IFI+/di\n\tmAst5Ed1PCpAET393FG8AavEHWtNXiPLuu2mQ=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=58Yy4jJ7URGuBLlX6dhSK2gh+jMkSo/YS/TtF0sMNrQ=;\n\tb=41Mcs+RI2oGMPiSN9DIxx+y9i7KwHOKrWUk3/BoY87iQlKdZsMChs/Zd9EfN8RluHZ\n\tPzsjucyt2xA1xrDI8+C8VSaRB5TS6oFKmDB/m7COE81rd1sgCYthLmH0usITaSKfSfnI\n\t3kt6NnJcZcbHEf8cipmYvIAbQmSmCAN0qa2JMtLdBCjnVEoHyeVggx59xlbz46DXpvuM\n\ttdhmQGIY+RKy64kLy1klKL0Lui7yHt4L6S/kqbqJP2ZE3kwgi0pYplUg+mFYyPlKZc+C\n\t0cLiSy4ODg5XRzX+uHDGLdLjENbxbzkZ4v4PcEZ5PqytL+Yv2JjLn93B9AsMnQGgku0I\n\tiX1A==","X-Gm-Message-State":"AOAM530es0pw2InYj7RzNOYZm2QUTzIicy3VYWgAeWIekRHiQyYjtVGY\n\tpuWwGpfDFnR0wg5jram0Ybk16xaqCIA5e3epkx0Kog==","X-Google-Smtp-Source":"ABdhPJxu+/rc5o2FMICpqAFyKQPsAemB0/DVsuu08KbLhNp4VO+6IGprYpo9KRJ0JySy/Zz9MKrEYGI63C2mMPFPs+A=","X-Received":"by 2002:a17:906:4fd6:: with SMTP id\n\ti22mr41706718ejw.92.1634696247752; \n\tTue, 19 Oct 2021 19:17:27 -0700 (PDT)","MIME-Version":"1.0","References":"<20211019114802.665980-1-umang.jain@ideasonboard.com>\n\t<20211019114802.665980-13-umang.jain@ideasonboard.com>\n\t<20211019120123.teolse365a7m5mbx@uno.localdomain>","In-Reply-To":"<20211019120123.teolse365a7m5mbx@uno.localdomain>","From":"Hirokazu Honda ","Date":"Wed, 20 Oct 2021 11:17:17 +0900","Message-ID":"","To":"Jacopo Mondi ","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH v2 12/12] android: camera_metadata:\n\tRename get() to getMetadata()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]