{"id":14185,"url":"https://patchwork.libcamera.org/api/patches/14185/?format=json","web_url":"https://patchwork.libcamera.org/patch/14185/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20211019114802.665980-12-umang.jain@ideasonboard.com>","date":"2021-10-19T11:48:01","name":"[libcamera-devel,v2,11/12] android: camera_stream: Define explicit move constructor and destructors","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"f8cbfe77841e5c7c7182ee4725ea120101dd4891","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/?format=json","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"delegate":{"id":12,"url":"https://patchwork.libcamera.org/api/users/12/?format=json","username":"uajain","first_name":"Umang","last_name":"Jain","email":"umang.jain@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/patch/14185/mbox/","series":[{"id":2638,"url":"https://patchwork.libcamera.org/api/series/2638/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2638","date":"2021-10-19T11:47:50","name":"android: Overhaul request handling","version":2,"mbox":"https://patchwork.libcamera.org/series/2638/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/14185/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/14185/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 44B62C324C\n\tfor ;\n\tTue, 19 Oct 2021 11:48:36 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0788368F59;\n\tTue, 19 Oct 2021 13:48:36 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A83C668F5B\n\tfor ;\n\tTue, 19 Oct 2021 13:48:34 +0200 (CEST)","from perceval.ideasonboard.com (unknown [103.251.226.98])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 244E512A;\n\tTue, 19 Oct 2021 13:48:32 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"G4fc48JF\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1634644114;\n\tbh=+2iv9AcdAop1GHr1p6p2XOkrbZvLF8eoj0tQrRjYMdw=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=G4fc48JFscvLkTjJsxLP8D2mFTg0GrvkvEZUqdLi5z6m3fvRY49Q0hib4Ayc8epM1\n\tMNIS8nn0jh7p8ct2Mx7qE20EDz7ASz9lwSSvaMUaihtwjSigepS4IpRWowd2KcH3RL\n\tCTiqj9ShWiWMePl+dbGxtmmoKAKBs+S+ZtbSeraA=","From":"Umang Jain ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 19 Oct 2021 17:18:01 +0530","Message-Id":"<20211019114802.665980-12-umang.jain@ideasonboard.com>","X-Mailer":"git-send-email 2.31.1","In-Reply-To":"<20211019114802.665980-1-umang.jain@ideasonboard.com>","References":"<20211019114802.665980-1-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 11/12] android: camera_stream: Define\n\texplicit move constructor and destructors","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"From: Laurent Pinchart \n\nThere's no need for the move constructor and the destructor to be\ninline. Define them explicitly, with default implementations. This\nallows usage of the CameraStream class without a complete definition of\nthe PostProcessor class.\n\nSigned-off-by: Laurent Pinchart \nReviewed-by: Umang Jain\nReviewed-by: Jacopo Mondi \n---\n src/android/camera_stream.cpp | 4 ++++\n src/android/camera_stream.h | 2 ++\n 2 files changed, 6 insertions(+)","diff":"diff --git a/src/android/camera_stream.cpp b/src/android/camera_stream.cpp\nindex 8e6ccb83..f44a2717 100644\n--- a/src/android/camera_stream.cpp\n+++ b/src/android/camera_stream.cpp\n@@ -56,6 +56,10 @@ CameraStream::CameraStream(CameraDevice *const cameraDevice,\n {\n }\n \n+CameraStream::CameraStream(CameraStream &&other) = default;\n+\n+CameraStream::~CameraStream() = default;\n+\n const StreamConfiguration &CameraStream::configuration() const\n {\n \treturn config_->at(index_);\ndiff --git a/src/android/camera_stream.h b/src/android/camera_stream.h\nindex 85064268..f242336e 100644\n--- a/src/android/camera_stream.h\n+++ b/src/android/camera_stream.h\n@@ -112,6 +112,8 @@ public:\n \tCameraStream(CameraDevice *const cameraDevice,\n \t\t libcamera::CameraConfiguration *config, Type type,\n \t\t camera3_stream_t *camera3Stream, unsigned int index);\n+\tCameraStream(CameraStream &&other);\n+\t~CameraStream();\n \n \tType type() const { return type_; }\n \tcamera3_stream_t *camera3Stream() const { return camera3Stream_; }\n","prefixes":["libcamera-devel","v2","11/12"]}