{"id":14181,"url":"https://patchwork.libcamera.org/api/patches/14181/?format=json","web_url":"https://patchwork.libcamera.org/patch/14181/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20211019114802.665980-8-umang.jain@ideasonboard.com>","date":"2021-10-19T11:47:57","name":"[libcamera-devel,v2,07/12] android: camera_stream: Return non-const pointer from camera3Stream()","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"0200e72e6386c2a7e84491248b6329cc548c65e1","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/?format=json","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"delegate":{"id":12,"url":"https://patchwork.libcamera.org/api/users/12/?format=json","username":"uajain","first_name":"Umang","last_name":"Jain","email":"umang.jain@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/patch/14181/mbox/","series":[{"id":2638,"url":"https://patchwork.libcamera.org/api/series/2638/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2638","date":"2021-10-19T11:47:50","name":"android: Overhaul request handling","version":2,"mbox":"https://patchwork.libcamera.org/series/2638/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/14181/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/14181/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 34948C324C\n\tfor ;\n\tTue, 19 Oct 2021 11:48:28 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F396F68F59;\n\tTue, 19 Oct 2021 13:48:27 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0988368F61\n\tfor ;\n\tTue, 19 Oct 2021 13:48:26 +0200 (CEST)","from perceval.ideasonboard.com (unknown [103.251.226.98])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9AB4912A;\n\tTue, 19 Oct 2021 13:48:24 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"wqEfb5i+\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1634644105;\n\tbh=1Y9oMUkhXf/KjCa3O8v3E2sUSMaJmgiLRBg9i2QDTig=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=wqEfb5i+yPWtyDPt9P3MZq2M8vKZSjI1YODgeC3N38uuV35gLTbDGmO55VYwEw/AA\n\tm1TJZRlXUdn9gef88k9jCUzLkkYmZUXXsOj+cWM5Z+zeImbjC20mLLXERMxy22qSOQ\n\tdjeUjWlFJlzZpXi6xvYcskoinbYqrk851i0totzI=","From":"Umang Jain ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 19 Oct 2021 17:17:57 +0530","Message-Id":"<20211019114802.665980-8-umang.jain@ideasonboard.com>","X-Mailer":"git-send-email 2.31.1","In-Reply-To":"<20211019114802.665980-1-umang.jain@ideasonboard.com>","References":"<20211019114802.665980-1-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 07/12] android: camera_stream: Return\n\tnon-const pointer from camera3Stream()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"From: Laurent Pinchart \n\nThe camera3_stream_t instances are used to interact with the camera\nservice, whose API uses non-const pointers. Replace the const reference\nreturned by CameraStream::camera3Stream() with a non-const pointer. It\nturns out that nobody calls this function, but new users will be\nintroduced in subsequent commits.\n\nSigned-off-by: Laurent Pinchart \nReviewed-by: Jacopo Mondi \nReviewed-by: Hirokazu Honda \n---\n src/android/camera_stream.h | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/android/camera_stream.h b/src/android/camera_stream.h\nindex 197bd995..85064268 100644\n--- a/src/android/camera_stream.h\n+++ b/src/android/camera_stream.h\n@@ -114,7 +114,7 @@ public:\n \t\t camera3_stream_t *camera3Stream, unsigned int index);\n \n \tType type() const { return type_; }\n-\tconst camera3_stream_t &camera3Stream() const { return *camera3Stream_; }\n+\tcamera3_stream_t *camera3Stream() const { return camera3Stream_; }\n \tconst libcamera::StreamConfiguration &configuration() const;\n \tlibcamera::Stream *stream() const;\n \n","prefixes":["libcamera-devel","v2","07/12"]}