[{"id":20279,"web_url":"https://patchwork.libcamera.org/comment/20279/","msgid":"<20211018164010.ybqnqffbv7pq2zws@uno.localdomain>","date":"2021-10-18T16:40:10","subject":"Re: [libcamera-devel] [PATCH 11/11] android: camera_stream: Define\n\texplicit move constructor and destructors","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n\nOn Mon, Oct 18, 2021 at 06:59:23PM +0530, Umang Jain wrote:\n> From: Laurent Pinchart \n>\n> There's no need for the move constructor and the destructor to be\n> inline. Define them explicitly, with default implementations. This\n\nWere they inline ? Or rather implicitly defiend ?\n\n> allows usage of the CameraStream class without a complete definition of\n> the PostProcessor class.\n>\n> Signed-off-by: Laurent Pinchart \n\nAnd saves a bit of space too probably!\n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> src/android/camera_stream.cpp | 4 ++++\n> src/android/camera_stream.h | 2 ++\n> 2 files changed, 6 insertions(+)\n>\n> diff --git a/src/android/camera_stream.cpp b/src/android/camera_stream.cpp\n> index 8e6ccb83..f44a2717 100644\n> --- a/src/android/camera_stream.cpp\n> +++ b/src/android/camera_stream.cpp\n> @@ -56,6 +56,10 @@ CameraStream::CameraStream(CameraDevice *const cameraDevice,\n> {\n> }\n>\n> +CameraStream::CameraStream(CameraStream &&other) = default;\n> +\n> +CameraStream::~CameraStream() = default;\n> +\n> const StreamConfiguration &CameraStream::configuration() const\n> {\n> \treturn config_->at(index_);\n> diff --git a/src/android/camera_stream.h b/src/android/camera_stream.h\n> index 85064268..f242336e 100644\n> --- a/src/android/camera_stream.h\n> +++ b/src/android/camera_stream.h\n> @@ -112,6 +112,8 @@ public:\n> \tCameraStream(CameraDevice *const cameraDevice,\n> \t\t libcamera::CameraConfiguration *config, Type type,\n> \t\t camera3_stream_t *camera3Stream, unsigned int index);\n> +\tCameraStream(CameraStream &&other);\n> +\t~CameraStream();\n>\n> \tType type() const { return type_; }\n> \tcamera3_stream_t *camera3Stream() const { return camera3Stream_; }\n> --\n> 2.31.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 07B49C323E\n\tfor ;\n\tMon, 18 Oct 2021 16:39:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8A4B568F59;\n\tMon, 18 Oct 2021 18:39:23 +0200 (CEST)","from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net\n\t[217.70.183.198])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7C4B668F56\n\tfor ;\n\tMon, 18 Oct 2021 18:39:22 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 14194C000D;\n\tMon, 18 Oct 2021 16:39:21 +0000 (UTC)"],"Date":"Mon, 18 Oct 2021 18:40:10 +0200","From":"Jacopo Mondi ","To":"Umang Jain ","Message-ID":"<20211018164010.ybqnqffbv7pq2zws@uno.localdomain>","References":"<20211018132923.476242-1-umang.jain@ideasonboard.com>\n\t<20211018132923.476242-12-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20211018132923.476242-12-umang.jain@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 11/11] android: camera_stream: Define\n\texplicit move constructor and destructors","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":20282,"web_url":"https://patchwork.libcamera.org/comment/20282/","msgid":"","date":"2021-10-18T17:36:44","subject":"Re: [libcamera-devel] [PATCH 11/11] android: camera_stream: Define\n\texplicit move constructor and destructors","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn Mon, Oct 18, 2021 at 06:40:10PM +0200, Jacopo Mondi wrote:\n> On Mon, Oct 18, 2021 at 06:59:23PM +0530, Umang Jain wrote:\n> > From: Laurent Pinchart \n> >\n> > There's no need for the move constructor and the destructor to be\n> > inline. Define them explicitly, with default implementations. This\n> \n> Were they inline ? Or rather implicitly defiend ?\n\nBoth,\n\n\"If no user-declared constructors of any kind are provided for a class\ntype (struct, class, or union), the compiler will always declare a\ndefault constructor as an inline public member of its class.\"\n\n(https://en.cppreference.com/w/cpp/language/default_constructor)\n\n> > allows usage of the CameraStream class without a complete definition of\n> > the PostProcessor class.\n> >\n> > Signed-off-by: Laurent Pinchart \n> \n> And saves a bit of space too probably!\n> \n> Reviewed-by: Jacopo Mondi \n> \n> > ---\n> > src/android/camera_stream.cpp | 4 ++++\n> > src/android/camera_stream.h | 2 ++\n> > 2 files changed, 6 insertions(+)\n> >\n> > diff --git a/src/android/camera_stream.cpp b/src/android/camera_stream.cpp\n> > index 8e6ccb83..f44a2717 100644\n> > --- a/src/android/camera_stream.cpp\n> > +++ b/src/android/camera_stream.cpp\n> > @@ -56,6 +56,10 @@ CameraStream::CameraStream(CameraDevice *const cameraDevice,\n> > {\n> > }\n> >\n> > +CameraStream::CameraStream(CameraStream &&other) = default;\n> > +\n> > +CameraStream::~CameraStream() = default;\n> > +\n> > const StreamConfiguration &CameraStream::configuration() const\n> > {\n> > \treturn config_->at(index_);\n> > diff --git a/src/android/camera_stream.h b/src/android/camera_stream.h\n> > index 85064268..f242336e 100644\n> > --- a/src/android/camera_stream.h\n> > +++ b/src/android/camera_stream.h\n> > @@ -112,6 +112,8 @@ public:\n> > \tCameraStream(CameraDevice *const cameraDevice,\n> > \t\t libcamera::CameraConfiguration *config, Type type,\n> > \t\t camera3_stream_t *camera3Stream, unsigned int index);\n> > +\tCameraStream(CameraStream &&other);\n> > +\t~CameraStream();\n> >\n> > \tType type() const { return type_; }\n> > \tcamera3_stream_t *camera3Stream() const { return camera3Stream_; }","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AE002C324C\n\tfor ;\n\tMon, 18 Oct 2021 17:37:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1B1F068F59;\n\tMon, 18 Oct 2021 19:37:03 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9A21868F56\n\tfor ;\n\tMon, 18 Oct 2021 19:37:01 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0ECAE8C6;\n\tMon, 18 Oct 2021 19:37:00 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"dqhfFNQP\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1634578621;\n\tbh=EY+81XE2HMSsQPuHNklYUzzRYh/AMul98L8QzUf3FLI=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=dqhfFNQP3S/KaLAQBAu0YnL5LFUVuKuAOB6clkDV1sKTlmFJn/eN76aZT3vDtUAiP\n\t6G+6+pLf3B9nodXQOn9JfUKniZDGU9XO9sf1AK0zpDrW7kkPRp8iCTqB8NmWMYMnTA\n\ttul0lD6cPCZIvOWvzWrwvZCJFcGzbGkH3Vg8vB3A=","Date":"Mon, 18 Oct 2021 20:36:44 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Message-ID":"","References":"<20211018132923.476242-1-umang.jain@ideasonboard.com>\n\t<20211018132923.476242-12-umang.jain@ideasonboard.com>\n\t<20211018164010.ybqnqffbv7pq2zws@uno.localdomain>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20211018164010.ybqnqffbv7pq2zws@uno.localdomain>","Subject":"Re: [libcamera-devel] [PATCH 11/11] android: camera_stream: Define\n\texplicit move constructor and destructors","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":20297,"web_url":"https://patchwork.libcamera.org/comment/20297/","msgid":"","date":"2021-10-19T10:56:47","subject":"Re: [libcamera-devel] [PATCH 11/11] android: camera_stream: Define\n\texplicit move constructor and destructors","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 10/18/21 6:59 PM, Umang Jain wrote:\n> From: Laurent Pinchart \n>\n> There's no need for the move constructor and the destructor to be\n> inline. Define them explicitly, with default implementations. This\n> allows usage of the CameraStream class without a complete definition of\n> the PostProcessor class.\n>\n> Signed-off-by: Laurent Pinchart \n\n\nReviewed-by: Umang Jain\n\n> ---\n> src/android/camera_stream.cpp | 4 ++++\n> src/android/camera_stream.h | 2 ++\n> 2 files changed, 6 insertions(+)\n>\n> diff --git a/src/android/camera_stream.cpp b/src/android/camera_stream.cpp\n> index 8e6ccb83..f44a2717 100644\n> --- a/src/android/camera_stream.cpp\n> +++ b/src/android/camera_stream.cpp\n> @@ -56,6 +56,10 @@ CameraStream::CameraStream(CameraDevice *const cameraDevice,\n> {\n> }\n> \n> +CameraStream::CameraStream(CameraStream &&other) = default;\n> +\n> +CameraStream::~CameraStream() = default;\n> +\n> const StreamConfiguration &CameraStream::configuration() const\n> {\n> \treturn config_->at(index_);\n> diff --git a/src/android/camera_stream.h b/src/android/camera_stream.h\n> index 85064268..f242336e 100644\n> --- a/src/android/camera_stream.h\n> +++ b/src/android/camera_stream.h\n> @@ -112,6 +112,8 @@ public:\n> \tCameraStream(CameraDevice *const cameraDevice,\n> \t\t libcamera::CameraConfiguration *config, Type type,\n> \t\t camera3_stream_t *camera3Stream, unsigned int index);\n> +\tCameraStream(CameraStream &&other);\n> +\t~CameraStream();\n> \n> \tType type() const { return type_; }\n> \tcamera3_stream_t *camera3Stream() const { return camera3Stream_; }","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5AF2CC324C\n\tfor ;\n\tTue, 19 Oct 2021 10:56:53 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 28A1568F59;\n\tTue, 19 Oct 2021 12:56:53 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5F565604FE\n\tfor ;\n\tTue, 19 Oct 2021 12:56:51 +0200 (CEST)","from [192.168.1.106] (unknown [103.251.226.98])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C65E912A\n\tfor ;\n\tTue, 19 Oct 2021 12:56:50 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"u0vG1xW4\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1634641011;\n\tbh=p8Q6q08mXbbn2cxRlvEzCP+ALKNrerUc0z3p2DtBWkU=;\n\th=Subject:From:To:References:Date:In-Reply-To:From;\n\tb=u0vG1xW48P/WyYOK+cdGopafjD1P1elvQihKUYRl+hsHu9ksFc+xRaeFKADwUB54T\n\t8SuhmAGyYPzkMBazmAk+8fZalVlLu1pUmHh2DCQ4Lg2o0zHv7cP3bet94WOJCGBWEb\n\tnPNbnv5khEVizu8GZtrBJU65Dc/HlYbfr5iTHzck=","From":"Umang Jain ","To":"libcamera-devel@lists.libcamera.org","References":"<20211018132923.476242-1-umang.jain@ideasonboard.com>\n\t<20211018132923.476242-12-umang.jain@ideasonboard.com>","Message-ID":"","Date":"Tue, 19 Oct 2021 16:26:47 +0530","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.10.2","MIME-Version":"1.0","In-Reply-To":"<20211018132923.476242-12-umang.jain@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"7bit","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH 11/11] android: camera_stream: Define\n\texplicit move constructor and destructors","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]