[{"id":20276,"web_url":"https://patchwork.libcamera.org/comment/20276/","msgid":"<20211018163229.cpkmxes7mjza4utf@uno.localdomain>","date":"2021-10-18T16:32:29","subject":"Re: [libcamera-devel] [PATCH 07/11] android: camera_stream: Return\n\tnon-const pointer from camera3Stream()","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi laurent,\n\nOn Mon, Oct 18, 2021 at 06:59:19PM +0530, Umang Jain wrote:\n> From: Laurent Pinchart \n>\n> The camera3_stream_t instances are used to interact with the camera\n> service, whose API uses non-const pointers. Replace the const reference\n> returned by CameraStream::camera3Stream() with a non-const pointer. It\n> turns out that nobody calls this function, but new users will be\n> introduced in subsequent commits.\n>\n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> src/android/camera_stream.h | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/src/android/camera_stream.h b/src/android/camera_stream.h\n> index 197bd995..85064268 100644\n> --- a/src/android/camera_stream.h\n> +++ b/src/android/camera_stream.h\n> @@ -114,7 +114,7 @@ public:\n> \t\t camera3_stream_t *camera3Stream, unsigned int index);\n>\n> \tType type() const { return type_; }\n> -\tconst camera3_stream_t &camera3Stream() const { return *camera3Stream_; }\n> +\tcamera3_stream_t *camera3Stream() const { return camera3Stream_; }\n> \tconst libcamera::StreamConfiguration &configuration() const;\n> \tlibcamera::Stream *stream() const;\n>\n> --\n> 2.31.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C9D59C323E\n\tfor ;\n\tMon, 18 Oct 2021 16:31:43 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A49C168F59;\n\tMon, 18 Oct 2021 18:31:43 +0200 (CEST)","from relay12.mail.gandi.net (relay12.mail.gandi.net\n\t[217.70.178.232])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 993AB68F56\n\tfor ;\n\tMon, 18 Oct 2021 18:31:41 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby relay12.mail.gandi.net (Postfix) with ESMTPSA id 3EC8A200007;\n\tMon, 18 Oct 2021 16:31:41 +0000 (UTC)"],"Date":"Mon, 18 Oct 2021 18:32:29 +0200","From":"Jacopo Mondi ","To":"Umang Jain ","Message-ID":"<20211018163229.cpkmxes7mjza4utf@uno.localdomain>","References":"<20211018132923.476242-1-umang.jain@ideasonboard.com>\n\t<20211018132923.476242-8-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20211018132923.476242-8-umang.jain@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 07/11] android: camera_stream: Return\n\tnon-const pointer from camera3Stream()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":20293,"web_url":"https://patchwork.libcamera.org/comment/20293/","msgid":"","date":"2021-10-19T04:51:49","subject":"Re: [libcamera-devel] [PATCH 07/11] android: camera_stream: Return\n\tnon-const pointer from camera3Stream()","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"content":"Hi Umang and Laurent, thank you for the patch.\n\nOn Tue, Oct 19, 2021 at 1:31 AM Jacopo Mondi wrote:\n>\n> Hi laurent,\n>\n> On Mon, Oct 18, 2021 at 06:59:19PM +0530, Umang Jain wrote:\n> > From: Laurent Pinchart \n> >\n> > The camera3_stream_t instances are used to interact with the camera\n> > service, whose API uses non-const pointers. Replace the const reference\n> > returned by CameraStream::camera3Stream() with a non-const pointer. It\n> > turns out that nobody calls this function, but new users will be\n> > introduced in subsequent commits.\n> >\n> > Signed-off-by: Laurent Pinchart \n>\n\nReviewed-by: Hirokazu Honda \n\n> Reviewed-by: Jacopo Mondi \n>\n> Thanks\n> j\n>\n> > ---\n> > src/android/camera_stream.h | 2 +-\n> > 1 file changed, 1 insertion(+), 1 deletion(-)\n> >\n> > diff --git a/src/android/camera_stream.h b/src/android/camera_stream.h\n> > index 197bd995..85064268 100644\n> > --- a/src/android/camera_stream.h\n> > +++ b/src/android/camera_stream.h\n> > @@ -114,7 +114,7 @@ public:\n> > camera3_stream_t *camera3Stream, unsigned int index);\n> >\n> > Type type() const { return type_; }\n> > - const camera3_stream_t &camera3Stream() const { return *camera3Stream_; }\n> > + camera3_stream_t *camera3Stream() const { return camera3Stream_; }\n> > const libcamera::StreamConfiguration &configuration() const;\n> > libcamera::Stream *stream() const;\n> >\n> > --\n> > 2.31.0\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D72B7C324C\n\tfor ;\n\tTue, 19 Oct 2021 04:52:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6192E68F5A;\n\tTue, 19 Oct 2021 06:52:02 +0200 (CEST)","from mail-ed1-x532.google.com (mail-ed1-x532.google.com\n\t[IPv6:2a00:1450:4864:20::532])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C68BE60126\n\tfor ;\n\tTue, 19 Oct 2021 06:52:00 +0200 (CEST)","by mail-ed1-x532.google.com with SMTP id y12so8250770eda.4\n\tfor ;\n\tMon, 18 Oct 2021 21:52:00 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"dyGssM+9\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=56WAigF26emKUIsrrBEqyu0T8WisWzUQHWkFJyJNdcQ=;\n\tb=dyGssM+9DLyt8TH+16rx4O62mVX9KPhhtrPdB8JPmzFUYn8mzgDE1TkgYNB1Ach5da\n\tsCp725rO3BvryAMeOA7XMCUxb7N6xz30QJADm6yQWmFhu1qqBQrCiXAU5+KHwXeN+m8G\n\tIWY/IvtgjGjx349vYmU4XjqKn+9W0Trx0PcL4=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=56WAigF26emKUIsrrBEqyu0T8WisWzUQHWkFJyJNdcQ=;\n\tb=6c9bOe3mhU+pQskfK/NHjt22Ya71u14URkWU4gefNSHv2yhfitJXGXXiE4yNqT7uXw\n\tAJVy9vhRdgg6JJifi3eFXPEGi5zL1sAChqcaFGo6t1rb+andI7YE8EqKDuGfLvVuf1sF\n\tQo2DXnu9ubvCB8tj0JhQ+TPafBc5bxcxcEkjDiiOTkh5aTK/mxc4G+hnMAIw8T9FR8xT\n\tdWXlP/yeyPyZ/IkcwpDF+nczk0p2Sn/e7CYmjCbUUOoNJMAP+B+SPS0dcOGzn6tAXnuh\n\t/ztDxCTxiPtllrojUWTvW4bTJ52Lm96+OZUrvmh2/Pz+QaLTh6U/+kiev7jmbCcxhpBd\n\t7NCQ==","X-Gm-Message-State":"AOAM53054gaKVjSFYusmf4y5aUtM833OqIm9Kqhuh8mxP0gjA/6ci4yC\n\tEX+cBTVUD5hkmdnY1nXrOSwZFJyF+0ZuyevZumNEzA==","X-Google-Smtp-Source":"ABdhPJz7XJvqIaOlK4xO/Y6r4cbYgHuzd/N9j33Sq+63dG3zYsOBfSmnLA5cT30Q+V/fyhoSNVaM3iXx21kIP8Eqg7E=","X-Received":"by 2002:a17:906:c44b:: with SMTP id\n\tck11mr34770044ejb.559.1634619120499; \n\tMon, 18 Oct 2021 21:52:00 -0700 (PDT)","MIME-Version":"1.0","References":"<20211018132923.476242-1-umang.jain@ideasonboard.com>\n\t<20211018132923.476242-8-umang.jain@ideasonboard.com>\n\t<20211018163229.cpkmxes7mjza4utf@uno.localdomain>","In-Reply-To":"<20211018163229.cpkmxes7mjza4utf@uno.localdomain>","From":"Hirokazu Honda ","Date":"Tue, 19 Oct 2021 13:51:49 +0900","Message-ID":"","To":"Jacopo Mondi ","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH 07/11] android: camera_stream: Return\n\tnon-const pointer from camera3Stream()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]