{"id":14159,"url":"https://patchwork.libcamera.org/api/patches/14159/?format=json","web_url":"https://patchwork.libcamera.org/patch/14159/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20211015170232.1146000-1-fontaine.fabrice@gmail.com>","date":"2021-10-15T17:02:32","name":"[libcamera-devel] src/ipa/raspberrypi/raspberrypi.cpp: drop constexpr for division","commit_ref":null,"pull_url":null,"state":"rejected","archived":false,"hash":"acc54b8d78b2b56b32ad3e48539580ac43d1831f","submitter":{"id":22,"url":"https://patchwork.libcamera.org/api/people/22/?format=json","name":"Fabrice Fontaine","email":"fontaine.fabrice@gmail.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/14159/mbox/","series":[{"id":2634,"url":"https://patchwork.libcamera.org/api/series/2634/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2634","date":"2021-10-15T17:02:32","name":"[libcamera-devel] src/ipa/raspberrypi/raspberrypi.cpp: drop constexpr for division","version":1,"mbox":"https://patchwork.libcamera.org/series/2634/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/14159/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/14159/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id ADD9BC323E\n\tfor ;\n\tFri, 15 Oct 2021 17:03:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EE2F168F4C;\n\tFri, 15 Oct 2021 19:03:48 +0200 (CEST)","from mail-wr1-x435.google.com (mail-wr1-x435.google.com\n\t[IPv6:2a00:1450:4864:20::435])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6CC0768546\n\tfor ;\n\tFri, 15 Oct 2021 19:03:47 +0200 (CEST)","by mail-wr1-x435.google.com with SMTP id y3so27727928wrl.1\n\tfor ;\n\tFri, 15 Oct 2021 10:03:47 -0700 (PDT)","from kali.home (lfbn-ren-1-1732-95.w86-253.abo.wanadoo.fr.\n\t[86.253.44.95]) by smtp.gmail.com with ESMTPSA id\n\t25sm11103859wmo.18.2021.10.15.10.03.46\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 15 Oct 2021 10:03:46 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"dz7LMoou\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n\th=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=se3vj5OP9K26Z5z9tfTTWup2/I/ja7b2Clsz+l5kkoQ=;\n\tb=dz7LMoou8EHb+luHeD+FgsFBsSwaEyN16d8fh48A5Pznxdy51jk2gIfrNVYGWADwdZ\n\t7mBseJzeHCwScTk9hraRMnaFkwnqRtSWcLM+WWsWLVHdaf9jPImGcrsUY3maimEQq06K\n\taFLNzf+F5MFj6ONG1P+DZFZ2TNICi6XezI1uBd8YPGuG22F3BhajZ5lPUkoO3d34EQot\n\tbULLOvqPPjow+oZE6l0WHc3wEU8iCkiOTMEAt2T1QlKoVzJvXPEl8DLRBYvXGGm4dJdm\n\tNCkSkMejHlw5QSC2KgWcEAvDCQc0miuZ7MX8nqtvNTGtSsqNGzjkjrIjrr63kYVrI/AV\n\txkOg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=se3vj5OP9K26Z5z9tfTTWup2/I/ja7b2Clsz+l5kkoQ=;\n\tb=YKmEkcEfpnXUKs1vmVcpVSWCoagIkxjREEkmRG6H4IKJySBZyOyRzjYBjsiABbHg0v\n\tcL0KOLuk9XF66b7GsJ0bFUBa91st+OVlm4GJlhCdATeoMcF4vqKZuPy2U7g11BqfN8Tc\n\tYUtgyoDLiREeIza8DqPEH4nrjWnxIDAqHS67NkDKl262ZHGIwvie/OwFAbjXZeRp4nmR\n\tVF07HrsnYD/XsmoAxr5PJfJYalh6CxXVOe1qR/Vsx8r2d5fgJyxv7Jr8SWG16J2uCVzV\n\t2p9fHJoBgXNVqkG4R4g9Xk+4InbKhUm44gU63MV09JPZRsA9aYrA48rCU9u42hN12dvj\n\tvDhA==","X-Gm-Message-State":"AOAM5304ALWZDfoWr+yuKf21Tis8lrYIIO3asKso0xsfswwFZ89EvkUQ\n\tfSMmgxAnMQR25+2VnO7FcypSPdpiQmg=","X-Google-Smtp-Source":"ABdhPJwwCcq01mB2vrlJJ6is23vv90kD1yk9bVZ8UQAQRg+Sy7lbk8z23pPsBjgtyimw9bEaHx+g1A==","X-Received":"by 2002:adf:ba0d:: with SMTP id\n\to13mr15479414wrg.339.1634317426807; \n\tFri, 15 Oct 2021 10:03:46 -0700 (PDT)","From":"Fabrice Fontaine ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 15 Oct 2021 19:02:32 +0200","Message-Id":"<20211015170232.1146000-1-fontaine.fabrice@gmail.com>","X-Mailer":"git-send-email 2.33.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH] src/ipa/raspberrypi/raspberrypi.cpp: drop\n\tconstexpr for division","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Fabrice Fontaine ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"For an unknown reason, build fails with some embedded toolchains since\ncommit 92b8ccc42a0f3ad323c79bde3c132d6956011239 on:\n\nIn file included from ../include/libcamera/base/log.h:10,\n from ../src/ipa/raspberrypi/raspberrypi.cpp:18:\n../src/ipa/raspberrypi/raspberrypi.cpp:64:53: in 'constexpr' expansion of 'std::chrono::operator/, double>(std::literals::chrono_literals::operator\"\"s(1.0e+0l), 3.0e+1)'\n/home/buildroot/autobuild/instance-2/output-1/host/opt/ext-toolchain/powerpc64-buildroot-linux-gnu/include/c++/9.3.0/chrono:502:32: error: '(1.0e+0l / 3.0e+1)' is not a constant expression\n 502 | return __cd(__cd(__d).count() / __s);\n../src/ipa/raspberrypi/raspberrypi.cpp:73:56: in 'constexpr' expansion of 'std::chrono::operator/, double>(std::literals::chrono_literals::operator\"\"s(1.0e+0l), 6.0e+1)'\n/home/buildroot/autobuild/instance-2/output-1/host/opt/ext-toolchain/powerpc64-buildroot-linux-gnu/include/c++/9.3.0/chrono:502:32: error: '(1.0e+0l / 6.0e+1)' is not a constant expression\n\nSo drop constexpr for both divisions to fix this build failure.\n\nFixes:\n - http://autobuild.buildroot.org/results/49caebe7ef7e3d63de49e78d5d6839dd0aedf10c\n\nSigned-off-by: Fabrice Fontaine \n---\n src/ipa/raspberrypi/raspberrypi.cpp | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp\nindex fed82e22..8ffb7092 100644\n--- a/src/ipa/raspberrypi/raspberrypi.cpp\n+++ b/src/ipa/raspberrypi/raspberrypi.cpp\n@@ -61,7 +61,7 @@ using utils::Duration;\n /* Configure the sensor with these values initially. */\n constexpr double defaultAnalogueGain = 1.0;\n constexpr Duration defaultExposureTime = 20.0ms;\n-constexpr Duration defaultMinFrameDuration = 1.0s / 30.0;\n+Duration defaultMinFrameDuration = 1.0s / 30.0;\n constexpr Duration defaultMaxFrameDuration = 250.0s;\n \n /*\n@@ -70,7 +70,7 @@ constexpr Duration defaultMaxFrameDuration = 250.0s;\n * we rate-limit the controller Prepare() and Process() calls to lower than or\n * equal to this rate.\n */\n-constexpr Duration controllerMinFrameDuration = 1.0s / 60.0;\n+Duration controllerMinFrameDuration = 1.0s / 60.0;\n \n LOG_DEFINE_CATEGORY(IPARPI)\n \n","prefixes":["libcamera-devel"]}