{"id":14126,"url":"https://patchwork.libcamera.org/api/patches/14126/?format=json","web_url":"https://patchwork.libcamera.org/patch/14126/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20211013154125.133419-11-jeanmichel.hautbois@ideasonboard.com>","date":"2021-10-13T15:41:22","name":"[libcamera-devel,10/13] ipa: ipu3: agc: Introduce previous exposure value","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"9b5a547cc0e353f9e01ff5e01c41c0b148df5e3a","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/people/75/?format=json","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/14126/mbox/","series":[{"id":2623,"url":"https://patchwork.libcamera.org/api/series/2623/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2623","date":"2021-10-13T15:41:13","name":"ipa: ipu3: Fix AGC bugs","version":1,"mbox":"https://patchwork.libcamera.org/series/2623/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/14126/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/14126/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6A28ABDC71\n\tfor ;\n\tWed, 13 Oct 2021 15:41:44 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2AACF68F5F;\n\tWed, 13 Oct 2021 17:41:44 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9D54068F4B\n\tfor ;\n\tWed, 13 Oct 2021 17:41:32 +0200 (CEST)","from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:3857:aa01:4281:bd9f])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3E2FD1AD5;\n\tWed, 13 Oct 2021 17:41:32 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"fpGqkOI2\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1634139692;\n\tbh=kVqzedrZRQ6Fc9v5wRPlD02jnMR+kecn3jojmTD75Yo=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=fpGqkOI2fKaJidNvyVqrG0TzKQarB5MjMYBuE9rdC6H2CZORbrQZ6CK+FrCNnPvG6\n\t+JPSPKCXL0qudMsL9H5NDPt3zcqC01iGkXSqLCmUHYeejIElsHDyfAKXT083sqysCg\n\tZzaabs7GgW6tEfacRw2wKZukcnt96PoP3lkMB+sk=","From":"Jean-Michel Hautbois ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 13 Oct 2021 17:41:22 +0200","Message-Id":"<20211013154125.133419-11-jeanmichel.hautbois@ideasonboard.com>","X-Mailer":"git-send-email 2.30.2","In-Reply-To":"<20211013154125.133419-1-jeanmichel.hautbois@ideasonboard.com>","References":"<20211013154125.133419-1-jeanmichel.hautbois@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 10/13] ipa: ipu3: agc: Introduce previous\n\texposure value","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"We need to calculate the gain on the previous exposure value calculated.\nThis value needs to be updated after each process call, initialised to\n0s.\n\nSigned-off-by: Jean-Michel Hautbois \n---\n src/ipa/ipu3/algorithms/agc.cpp | 8 ++++++--\n src/ipa/ipu3/algorithms/agc.h | 1 +\n 2 files changed, 7 insertions(+), 2 deletions(-)","diff":"diff --git a/src/ipa/ipu3/algorithms/agc.cpp b/src/ipa/ipu3/algorithms/agc.cpp\nindex bd28998a..7efe0907 100644\n--- a/src/ipa/ipu3/algorithms/agc.cpp\n+++ b/src/ipa/ipu3/algorithms/agc.cpp\n@@ -46,7 +46,8 @@ static constexpr double kEvGainTarget = 0.5;\n Agc::Agc()\n \t: frameCount_(0), lastFrame_(0), iqMean_(0.0), lineDuration_(0s),\n \t minExposureLines_(0), maxExposureLines_(0), filteredExposure_(0s),\n-\t filteredExposureNoDg_(0s), currentExposure_(0s), currentExposureNoDg_(0s)\n+\t filteredExposureNoDg_(0s), currentExposure_(0s),\n+\t currentExposureNoDg_(0s), prevExposureValue(0s)\n {\n }\n \n@@ -145,7 +146,7 @@ void Agc::lockExposureGain(uint32_t &exposure, double &analogueGain)\n \t\t\t\t << \" Gain \" << analogueGain\n \t\t\t\t << \" Needed ev gain \" << evGain;\n \n-\t\tcurrentExposure_ = currentExposureNoDg_ * evGain;\n+\t\tcurrentExposure_ = prevExposureValue * evGain;\n \t\tDuration maxTotalExposure = kMaxShutterSpeed * kMaxGain;\n \t\tcurrentExposure_ = std::min(currentExposure_, maxTotalExposure);\n \t\tLOG(IPU3Agc, Debug) << \"Target total exposure \" << currentExposure_\n@@ -182,6 +183,9 @@ void Agc::lockExposureGain(uint32_t &exposure, double &analogueGain)\n \n \t\texposure = shutterTime / lineDuration_;\n \t\tanalogueGain = stepGain;\n+\n+\t\t/* Update the exposure value for the next process call */\n+\t\tprevExposureValue = shutterTime * analogueGain;\n \t}\n \tlastFrame_ = frameCount_;\n }\ndiff --git a/src/ipa/ipu3/algorithms/agc.h b/src/ipa/ipu3/algorithms/agc.h\nindex 7605ab39..32817c4f 100644\n--- a/src/ipa/ipu3/algorithms/agc.h\n+++ b/src/ipa/ipu3/algorithms/agc.h\n@@ -51,6 +51,7 @@ private:\n \tDuration filteredExposureNoDg_;\n \tDuration currentExposure_;\n \tDuration currentExposureNoDg_;\n+\tDuration prevExposureValue;\n \n \tuint32_t stride_;\n };\n","prefixes":["libcamera-devel","10/13"]}