[{"id":20138,"web_url":"https://patchwork.libcamera.org/comment/20138/","msgid":"<163403759542.2943484.8980345041563824249@Monstersaurus>","date":"2021-10-12T11:19:55","subject":"Re: [libcamera-devel] [PATCH] libcamera: media_device: Print link\n\tinformation when setup fails","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart (2021-10-12 02:09:32)\n> When setting up a link fails, the error message doesn't specify which\n> link is being acted on. This makes debugging more difficult than it\n> should be. Improve the message by printing the link information.\n> \n\nReviewed-by: Kieran Bingham \n\n> Signed-off-by: Laurent Pinchart \n> ---\n> src/libcamera/media_device.cpp | 6 +++++-\n> 1 file changed, 5 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/media_device.cpp b/src/libcamera/media_device.cpp\n> index ccaf039ba7a9..aa93da75c593 100644\n> --- a/src/libcamera/media_device.cpp\n> +++ b/src/libcamera/media_device.cpp\n> @@ -803,7 +803,11 @@ int MediaDevice::setupLink(const MediaLink *link, unsigned int flags)\n> if (ret) {\n> ret = -errno;\n> LOG(MediaDevice, Error)\n> - << \"Failed to setup link: \"\n> + << \"Failed to setup link \"\n> + << source->entity()->name() << \"[\"\n> + << source->index() << \"] -> \"\n> + << sink->entity()->name() << \"[\"\n> + << sink->index() << \"]: \"\n> << strerror(-ret);\n> return ret;\n> }\n> \n> base-commit: fa7a95bf32c6a8ee87b67159d4238cbc8e6dc3a9\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 93953C323E\n\tfor ;\n\tTue, 12 Oct 2021 11:20:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 01C1E68F4F;\n\tTue, 12 Oct 2021 13:20:01 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3275968F4C\n\tfor ;\n\tTue, 12 Oct 2021 13:19:59 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B1C60F1;\n\tTue, 12 Oct 2021 13:19:58 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"haoqoqkM\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1634037598;\n\tbh=ejKrBY+Ucw17mXN04DmkPMoJ+/lb7Eue9AxpT7AylpU=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=haoqoqkMyg2EdRk3LKfN6WEuP0/RsTMFO7U8aI6pMvTbtC+3su71f7Yx1dt04YDDv\n\tcKOc4TgqAUNkOV0tZlO6qiv5+iXNZ/YeQI22PSwVC/90cn4zuoBVpDGzNwIO0eokaa\n\taq1UyKYutv9rYC1he0LPeGCWZBHKmtlYAP82bpJs=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20211012010932.15873-1-laurent.pinchart@ideasonboard.com>","References":"<20211012010932.15873-1-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham ","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Tue, 12 Oct 2021 12:19:55 +0100","Message-ID":"<163403759542.2943484.8980345041563824249@Monstersaurus>","User-Agent":"alot/0.9.1","Subject":"Re: [libcamera-devel] [PATCH] libcamera: media_device: Print link\n\tinformation when setup fails","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]