[{"id":20139,"web_url":"https://patchwork.libcamera.org/comment/20139/","msgid":"<163403810238.2943484.6590279991222011904@Monstersaurus>","date":"2021-10-12T11:28:22","subject":"Re: [libcamera-devel] [PATCH] libcamera: v4l2_subdevice: Set format\n\tfield to V4L2_FIELD_NONE","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart (2021-10-12 01:13:25)\n> libcamera doesn't support interlaced formats, set the field to\n> V4L2_FIELD_NONE explicitly instead of relying on drivers to interpret\n> V4L2_FIELD_ANY the way we want it.\n> \n\nAnd what about v4l2_videodevice.cpp: Ah it's already there.\n\nReviewed-by: Kieran Bingham \n\n> Signed-off-by: Laurent Pinchart \n> ---\n> src/libcamera/v4l2_subdevice.cpp | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/src/libcamera/v4l2_subdevice.cpp b/src/libcamera/v4l2_subdevice.cpp\n> index 8fe5e45b31ee..023e2328893d 100644\n> --- a/src/libcamera/v4l2_subdevice.cpp\n> +++ b/src/libcamera/v4l2_subdevice.cpp\n> @@ -425,6 +425,7 @@ int V4L2Subdevice::setFormat(unsigned int pad, V4L2SubdeviceFormat *format,\n> subdevFmt.format.width = format->size.width;\n> subdevFmt.format.height = format->size.height;\n> subdevFmt.format.code = format->mbus_code;\n> + subdevFmt.format.field = V4L2_FIELD_NONE;\n> \n> int ret = ioctl(VIDIOC_SUBDEV_S_FMT, &subdevFmt);\n> if (ret) {\n> \n> base-commit: fa7a95bf32c6a8ee87b67159d4238cbc8e6dc3a9\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 20F88BDC71\n\tfor ;\n\tTue, 12 Oct 2021 11:28:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5418A68F4F;\n\tTue, 12 Oct 2021 13:28:26 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 17CD868F4C\n\tfor ;\n\tTue, 12 Oct 2021 13:28:25 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AB086F1;\n\tTue, 12 Oct 2021 13:28:24 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"uBej2Tem\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1634038104;\n\tbh=YCky5Tj1J46OEuAgBx4ahsJvFmlobb9APKy1GqxuEfE=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=uBej2Tem1Kh3QYrO8gXYkXMrZ7mkvS6/hBjaSVxuosD6aMMLxjJzpKKqH8VothcAT\n\turbiCaH4mURpBcwEvdDmdjB6AauK/89vhVWrWMHFsMRhFQhoc2q6tXi3ocLzwy8lbS\n\tZ7lBX2tNDyIvic6MSVybhvFmza7nnBCbTqrhVOWs=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20211012001325.1952-1-laurent.pinchart@ideasonboard.com>","References":"<20211012001325.1952-1-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham ","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Tue, 12 Oct 2021 12:28:22 +0100","Message-ID":"<163403810238.2943484.6590279991222011904@Monstersaurus>","User-Agent":"alot/0.9.1","Subject":"Re: [libcamera-devel] [PATCH] libcamera: v4l2_subdevice: Set format\n\tfield to V4L2_FIELD_NONE","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]