[{"id":20159,"web_url":"https://patchwork.libcamera.org/comment/20159/","msgid":"","date":"2021-10-13T01:41:23","subject":"Re: [libcamera-devel] [PATCH v3 12/16] android: Filter preview\n\tstreams on FPS","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Mon, Oct 11, 2021 at 05:11:50PM +0200, Jacopo Mondi wrote:\n> Register as preview streams only streams capable of producing at least\n> 30 FPS.\n> \n> This requirement comes from inspecting the existing HAL implementation\n> on Intel IPU3 platform.\n> \n> Signed-off-by: Jacopo Mondi \n> Reviewed-by: Paul Elder \n> Reviewed-by: Umang Jain \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/android/camera_capabilities.cpp | 22 ++++++++++++++++++++++\n> 1 file changed, 22 insertions(+)\n> \n> diff --git a/src/android/camera_capabilities.cpp b/src/android/camera_capabilities.cpp\n> index ddba1bbbea85..a281be646696 100644\n> --- a/src/android/camera_capabilities.cpp\n> +++ b/src/android/camera_capabilities.cpp\n> @@ -1268,6 +1268,23 @@ int CameraCapabilities::initializeStaticMetadata()\n> \tstd::vector availableStreamConfigurations;\n> \tavailableStreamConfigurations.reserve(streamConfigurations_.size() * 4);\n> \tfor (const auto &entry : streamConfigurations_) {\n> +\t\t/*\n> +\t\t * Filter out YUV streams not capable of running at 30 FPS.\n> +\t\t *\n> +\t\t * This requirement comes from CTS RecordingTest failures most\n> +\t\t * probably related to a requirement of the camcoder video\n> +\t\t * recording profile. Inspecting the Intel IPU3 HAL\n> +\t\t * implementation confirms this but no reference has been found\n> +\t\t * in the metadata documentation.\n> +\t\t *\n> +\t\t * Calculate FPS as CTS does: see\n> +\t\t * Camera2SurfaceViewTestCase.java:getSuitableFpsRangeForDuration()\n> +\t\t */\n> +\t\tunsigned int fps = static_cast\n> +\t\t\t\t (floor(1e9 / entry.minFrameDurationNsec + 0.05f));\n> +\t\tif (entry.androidFormat != HAL_PIXEL_FORMAT_BLOB && fps < 30)\n> +\t\t\tcontinue;\n> +\n> \t\tavailableStreamConfigurations.push_back(entry.androidFormat);\n> \t\tavailableStreamConfigurations.push_back(entry.resolution.width);\n> \t\tavailableStreamConfigurations.push_back(entry.resolution.height);\n> @@ -1280,6 +1297,11 @@ int CameraCapabilities::initializeStaticMetadata()\n> \tstd::vector minFrameDurations;\n> \tminFrameDurations.reserve(streamConfigurations_.size() * 4);\n> \tfor (const auto &entry : streamConfigurations_) {\n> +\t\tunsigned int fps = static_cast\n> +\t\t\t\t (floor(1e9 / entry.minFrameDurationNsec + 0.05f));\n> +\t\tif (entry.androidFormat != HAL_PIXEL_FORMAT_BLOB && fps < 30)\n> +\t\t\tcontinue;\n> +\n> \t\tminFrameDurations.push_back(entry.androidFormat);\n> \t\tminFrameDurations.push_back(entry.resolution.width);\n> \t\tminFrameDurations.push_back(entry.resolution.height);","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C69AFC323E\n\tfor ;\n\tWed, 13 Oct 2021 01:41:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 386EC68F4F;\n\tWed, 13 Oct 2021 03:41:40 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5A6FF6012B\n\tfor ;\n\tWed, 13 Oct 2021 03:41:38 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B73BF291;\n\tWed, 13 Oct 2021 03:41:37 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"LGvcpy45\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1634089297;\n\tbh=YIRl02r5OldkSIdDPhIgmaiXfB0EmLPyAfZFoe1+gq0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=LGvcpy45XpmbzlpZN3sPH/fwwNI2LcnQJ5DKNzVuQ3t0d4jqx6kXzp8Spt0Sc01fX\n\tV4s+Ob/h+wyqG8VfkB8PbaHyCp+FxWNR+1rwVeZAa6POanc0c8YBpzoNG6iUr5lcT1\n\tifqlAL6kf5EgqmRnFCqtLeOTW2JROODYFicJMQMY=","Date":"Wed, 13 Oct 2021 04:41:23 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Message-ID":"","References":"<20211011151154.72856-1-jacopo@jmondi.org>\n\t<20211011151154.72856-13-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20211011151154.72856-13-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH v3 12/16] android: Filter preview\n\tstreams on FPS","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]