{"id":14093,"url":"https://patchwork.libcamera.org/api/patches/14093/?format=json","web_url":"https://patchwork.libcamera.org/patch/14093/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20211011151154.72856-10-jacopo@jmondi.org>","date":"2021-10-11T15:11:47","name":"[libcamera-devel,v3,09/16] android: capabilities: Use per-configuration durations","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"bd429a39acad7e802b50fabda1e1a438f4b4bd80","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/14093/mbox/","series":[{"id":2613,"url":"https://patchwork.libcamera.org/api/series/2613/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2613","date":"2021-10-11T15:11:38","name":"IPU3 control info update and HAL frame durations","version":3,"mbox":"https://patchwork.libcamera.org/series/2613/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/14093/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/14093/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8B66EC3243\n\tfor ;\n\tMon, 11 Oct 2021 15:11:21 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5F14768F66;\n\tMon, 11 Oct 2021 17:11:21 +0200 (CEST)","from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net\n\t[217.70.183.196])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C23D468F5A\n\tfor ;\n\tMon, 11 Oct 2021 17:11:19 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby relay4-d.mail.gandi.net (Postfix) with ESMTPSA id B6067E0003;\n\tMon, 11 Oct 2021 15:11:18 +0000 (UTC)"],"From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 11 Oct 2021 17:11:47 +0200","Message-Id":"<20211011151154.72856-10-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.33.0","In-Reply-To":"<20211011151154.72856-1-jacopo@jmondi.org>","References":"<20211011151154.72856-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v3 09/16] android: capabilities: Use\n\tper-configuration durations","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Use the per-configuration stream durations as collected during\ninitializeStreamConfigurations() to populate the\nANDROID_SCALER_AVAILABLE_STREAM_CONFIGURATIONS_OUTPUT static metadata.\n\nSigned-off-by: Jacopo Mondi \nReviewed-by: Paul Elder \nReviewed-by: Umang Jain \nReviewed-by: Laurent Pinchart \n---\n src/android/camera_capabilities.cpp | 21 +++++++++------------\n 1 file changed, 9 insertions(+), 12 deletions(-)","diff":"diff --git a/src/android/camera_capabilities.cpp b/src/android/camera_capabilities.cpp\nindex a8eec2a77a7b..7bcc63ca3a80 100644\n--- a/src/android/camera_capabilities.cpp\n+++ b/src/android/camera_capabilities.cpp\n@@ -1280,19 +1280,16 @@ int CameraCapabilities::initializeStaticMetadata()\n \tstaticMetadata_->addEntry(ANDROID_SCALER_AVAILABLE_STALL_DURATIONS,\n \t\t\t\t availableStallDurations);\n \n-\t/* Use the minimum frame duration for all the YUV/RGB formats. */\n-\tif (minFrameDurationNsec > 0) {\n-\t\tstd::vector minFrameDurations;\n-\t\tminFrameDurations.reserve(streamConfigurations_.size() * 4);\n-\t\tfor (const auto &entry : streamConfigurations_) {\n-\t\t\tminFrameDurations.push_back(entry.androidFormat);\n-\t\t\tminFrameDurations.push_back(entry.resolution.width);\n-\t\t\tminFrameDurations.push_back(entry.resolution.height);\n-\t\t\tminFrameDurations.push_back(minFrameDurationNsec);\n-\t\t}\n-\t\tstaticMetadata_->addEntry(ANDROID_SCALER_AVAILABLE_MIN_FRAME_DURATIONS,\n-\t\t\t\t\t minFrameDurations);\n+\tstd::vector minFrameDurations;\n+\tminFrameDurations.reserve(streamConfigurations_.size() * 4);\n+\tfor (const auto &entry : streamConfigurations_) {\n+\t\tminFrameDurations.push_back(entry.androidFormat);\n+\t\tminFrameDurations.push_back(entry.resolution.width);\n+\t\tminFrameDurations.push_back(entry.resolution.height);\n+\t\tminFrameDurations.push_back(entry.minFrameDurationNsec);\n \t}\n+\tstaticMetadata_->addEntry(ANDROID_SCALER_AVAILABLE_MIN_FRAME_DURATIONS,\n+\t\t\t\t minFrameDurations);\n \n \tuint8_t croppingType = ANDROID_SCALER_CROPPING_TYPE_CENTER_ONLY;\n \tstaticMetadata_->addEntry(ANDROID_SCALER_CROPPING_TYPE, croppingType);\n","prefixes":["libcamera-devel","v3","09/16"]}