{"id":14091,"url":"https://patchwork.libcamera.org/api/patches/14091/?format=json","web_url":"https://patchwork.libcamera.org/patch/14091/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20211011151154.72856-8-jacopo@jmondi.org>","date":"2021-10-11T15:11:45","name":"[libcamera-devel,v3,07/16] android: capabilities: Initialize camera state when building properties","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"02e68a89657e766b86d92fea6b8acf69c933516c","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/14091/mbox/","series":[{"id":2613,"url":"https://patchwork.libcamera.org/api/series/2613/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2613","date":"2021-10-11T15:11:38","name":"IPU3 control info update and HAL frame durations","version":3,"mbox":"https://patchwork.libcamera.org/series/2613/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/14091/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/14091/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6E1C0C323E\n\tfor ;\n\tMon, 11 Oct 2021 15:11:20 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E8A8268F5E;\n\tMon, 11 Oct 2021 17:11:19 +0200 (CEST)","from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net\n\t[217.70.183.196])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 606996012B\n\tfor ;\n\tMon, 11 Oct 2021 17:11:17 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 62D15E000D;\n\tMon, 11 Oct 2021 15:11:16 +0000 (UTC)"],"From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 11 Oct 2021 17:11:45 +0200","Message-Id":"<20211011151154.72856-8-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.33.0","In-Reply-To":"<20211011151154.72856-1-jacopo@jmondi.org>","References":"<20211011151154.72856-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v3 07/16] android: capabilities:\n\tInitialize camera state when building properties","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Now that building the list of supported stream configuration requires\napplying a configuration to the Camera, re-initialize the camera\ncontrols by applying a configuration generated for the Viewfinder stream\nrole before building the list of static metadata.\n\nSigned-off-by: Jacopo Mondi \nReviewed-by: Paul Elder \nReviewed-by: Umang Jain \nReviewed-by: Laurent Pinchart \n---\n src/android/camera_capabilities.cpp | 28 +++++++++++++++++++++++++---\n 1 file changed, 25 insertions(+), 3 deletions(-)","diff":"diff --git a/src/android/camera_capabilities.cpp b/src/android/camera_capabilities.cpp\nindex cfe0a1ad93e6..b69c9f1025b7 100644\n--- a/src/android/camera_capabilities.cpp\n+++ b/src/android/camera_capabilities.cpp\n@@ -394,11 +394,14 @@ int CameraCapabilities::initialize(std::shared_ptr camera,\n \t}\n \n \tret = initializeStreamConfigurations();\n-\tcamera_->release();\n-\tif (ret)\n+\tif (ret) {\n+\t\tcamera_->release();\n \t\treturn ret;\n+\t}\n \n-\treturn initializeStaticMetadata();\n+\tret = initializeStaticMetadata();\n+\tcamera_->release();\n+\treturn ret;\n }\n \n std::vector\n@@ -685,6 +688,25 @@ int CameraCapabilities::initializeStaticMetadata()\n \t\treturn -EINVAL;\n \t}\n \n+\t/*\n+\t * Generate and apply a new configuration for the Viewfinder role to\n+\t * collect control limits and properties from a known state.\n+\t */\n+\tstd::unique_ptr cameraConfig =\n+\t\tcamera_->generateConfiguration({ StreamRole::Viewfinder });\n+\tif (!cameraConfig) {\n+\t\tLOG(HAL, Error) << \"Failed to generate camera configuration\";\n+\t\tstaticMetadata_.reset();\n+\t\treturn -ENODEV;\n+\t}\n+\n+\tint ret = camera_->configure(cameraConfig.get());\n+\tif (ret) {\n+\t\tLOG(HAL, Error) << \"Failed to initialize the camera state\";\n+\t\tstaticMetadata_.reset();\n+\t\treturn ret;\n+\t}\n+\n \tconst ControlInfoMap &controlsInfo = camera_->controls();\n \tconst ControlList &properties = camera_->properties();\n \n","prefixes":["libcamera-devel","v3","07/16"]}