[{"id":20097,"web_url":"https://patchwork.libcamera.org/comment/20097/","msgid":"","date":"2021-10-07T10:35:57","subject":"Re: [libcamera-devel] [PATCH 2/2] android: camera_stream: Fix error\n\tmessage for buffer creation","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"content":"Hi Umang, thank you for the patch.\n\nOn Thu, Oct 7, 2021 at 6:39 PM Umang Jain wrote:\n>\n> From: Laurent Pinchart \n>\n> Creating a CameraBuffer instance doesn't map memory. Fix the error\n> message accordingly.\n>\n> Signed-off-by: Laurent Pinchart \n> Reviewed-by: Umang Jain \n> Signed-off-by: Umang Jain \n\nReviewed-by: Hirokazu Honda \n\n> ---\n> src/android/camera_stream.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/src/android/camera_stream.cpp b/src/android/camera_stream.cpp\n> index db8d854b..3b96d2e9 100644\n> --- a/src/android/camera_stream.cpp\n> +++ b/src/android/camera_stream.cpp\n> @@ -171,7 +171,7 @@ int CameraStream::process(const FrameBuffer &source,\n> CameraBuffer dest(*camera3Dest.buffer, output.pixelFormat, output.size,\n> PROT_READ | PROT_WRITE);\n> if (!dest.isValid()) {\n> - LOG(HAL, Error) << \"Failed to map android blob buffer\";\n> + LOG(HAL, Error) << \"Failed to create destination buffer\";\n> return -EINVAL;\n> }\n>\n> --\n> 2.31.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8AA29C323E\n\tfor ;\n\tThu, 7 Oct 2021 10:36:09 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4B40C691B6;\n\tThu, 7 Oct 2021 12:36:09 +0200 (CEST)","from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com\n\t[IPv6:2a00:1450:4864:20::52b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8DD29691AD\n\tfor ;\n\tThu, 7 Oct 2021 12:36:07 +0200 (CEST)","by mail-ed1-x52b.google.com with SMTP id x7so20625359edd.6\n\tfor ;\n\tThu, 07 Oct 2021 03:36:07 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"LjF2ND3c\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=CVCL7tI6ual10n7M93Xso1tusxnaga4iBmu8GD95HDQ=;\n\tb=LjF2ND3c9cizWJESG+WeH/QnZGD9CqxUjyOTmzrhME5JSrBzD8yemhGGk6h2TYfc7q\n\teYG4zuUEUdGVd43FPs1oTmjJZD5J2tpZlzEgo0G1NG1OpdvoVA5ghcK1XsbfKSes+KN5\n\tsYxQbSnU3V2AohE4zoslwNl+vkmf1dwJlMRwg=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=CVCL7tI6ual10n7M93Xso1tusxnaga4iBmu8GD95HDQ=;\n\tb=zb/vCcgnbzd9xyXocY4GoHKcaKQ92tiSpbx8Olb8W7zog33ZNvEfylbLFVDZQL9fjw\n\tOhQJ3C6d94rdSo2vmSvCj+mBteacqrj/O+1gJ97uobJ+b2rfJ8Ky+F8BwdOnAy20l06y\n\tv0Q4EKjdHE6nTEsm+YMnSJzdRYf4BkhVZ0gMKnu4OmbK/OeI+noBk5B3pUXm3oSmYU1w\n\tBhdfp6kBr+uEySz08PHaMNwIvjzGzx+MhcsqGGl5pizhMCIegydpY9OMf/CgEpzxMBjB\n\tbLxlCDMBs2nF0tF4gHjr1Dl/86fQidJgoyVixGoWw+KLyY2QPYYzoYVvVhiwr+0ocNm2\n\tJLDg==","X-Gm-Message-State":"AOAM530vTPo8iAJElHK6XWbsXWdV02ALzDcoIE4t8pk5IPyqbIozJhzo\n\tKhUqxRRBj9p96+WdYa6ahgw3LTaxpNu53JmjHF4WQGUU9tY=","X-Google-Smtp-Source":"ABdhPJz145MwjCc64SLp5iTjrzyZRcZyOCN/U21mQWfMaXk+ZreVHlAEdHfiShb6Yx3gvVvKbm1q4iyGaqULRI8SFvc=","X-Received":"by 2002:a17:906:3adb:: with SMTP id\n\tz27mr4602327ejd.291.1633602967250; \n\tThu, 07 Oct 2021 03:36:07 -0700 (PDT)","MIME-Version":"1.0","References":"<20211007093937.121357-1-umang.jain@ideasonboard.com>\n\t<20211007093937.121357-2-umang.jain@ideasonboard.com>","In-Reply-To":"<20211007093937.121357-2-umang.jain@ideasonboard.com>","From":"Hirokazu Honda ","Date":"Thu, 7 Oct 2021 19:35:57 +0900","Message-ID":"","To":"Umang Jain ","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH 2/2] android: camera_stream: Fix error\n\tmessage for buffer creation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":20106,"web_url":"https://patchwork.libcamera.org/comment/20106/","msgid":"<20211011102345.3yr5sqtbql3kq5fn@uno.localdomain>","date":"2021-10-11T10:23:45","subject":"Re: [libcamera-devel] [PATCH 2/2] android: camera_stream: Fix error\n\tmessage for buffer creation","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"On Thu, Oct 07, 2021 at 03:09:37PM +0530, Umang Jain wrote:\n> From: Laurent Pinchart \n>\n> Creating a CameraBuffer instance doesn't map memory. Fix the error\n> message accordingly.\n>\n> Signed-off-by: Laurent Pinchart \n> Reviewed-by: Umang Jain \n> Signed-off-by: Umang Jain \n\nReviewed-by: Jacopo Mondi \n\n\n> ---\n> src/android/camera_stream.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/src/android/camera_stream.cpp b/src/android/camera_stream.cpp\n> index db8d854b..3b96d2e9 100644\n> --- a/src/android/camera_stream.cpp\n> +++ b/src/android/camera_stream.cpp\n> @@ -171,7 +171,7 @@ int CameraStream::process(const FrameBuffer &source,\n> \tCameraBuffer dest(*camera3Dest.buffer, output.pixelFormat, output.size,\n> \t\t\t PROT_READ | PROT_WRITE);\n> \tif (!dest.isValid()) {\n> -\t\tLOG(HAL, Error) << \"Failed to map android blob buffer\";\n> +\t\tLOG(HAL, Error) << \"Failed to create destination buffer\";\n> \t\treturn -EINVAL;\n> \t}\n>\n> --\n> 2.31.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 41BAEBDC71\n\tfor ;\n\tMon, 11 Oct 2021 10:22:58 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 205E66027F;\n\tMon, 11 Oct 2021 12:22:58 +0200 (CEST)","from relay11.mail.gandi.net (relay11.mail.gandi.net\n\t[217.70.178.231])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E0D666012B\n\tfor ;\n\tMon, 11 Oct 2021 12:22:56 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby relay11.mail.gandi.net (Postfix) with ESMTPSA id 79D63100006;\n\tMon, 11 Oct 2021 10:22:56 +0000 (UTC)"],"Date":"Mon, 11 Oct 2021 12:23:45 +0200","From":"Jacopo Mondi ","To":"Umang Jain ","Message-ID":"<20211011102345.3yr5sqtbql3kq5fn@uno.localdomain>","References":"<20211007093937.121357-1-umang.jain@ideasonboard.com>\n\t<20211007093937.121357-2-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20211007093937.121357-2-umang.jain@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 2/2] android: camera_stream: Fix error\n\tmessage for buffer creation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]