{"id":14069,"url":"https://patchwork.libcamera.org/api/patches/14069/?format=json","web_url":"https://patchwork.libcamera.org/patch/14069/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20211007072147.1289490-3-hanlinchen@chromium.org>","date":"2021-10-07T07:21:47","name":"[libcamera-devel,v2,3/3] ipu3: Apply shading adapter as part of AIQ::run2a()","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"1fc76f057479bbfbe744bbb04d60e2409baef59b","submitter":{"id":98,"url":"https://patchwork.libcamera.org/api/people/98/?format=json","name":"Hanlin Chen","email":"hanlinchen@chromium.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/14069/mbox/","series":[{"id":2606,"url":"https://patchwork.libcamera.org/api/series/2606/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2606","date":"2021-10-07T07:21:45","name":"[libcamera-devel,v2,1/3] ipu3: Remove the usage of SharedItemPool","version":2,"mbox":"https://patchwork.libcamera.org/series/2606/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/14069/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/14069/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C774CC323E\n\tfor ;\n\tThu, 7 Oct 2021 07:22:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 87A7D691BD;\n\tThu, 7 Oct 2021 09:22:18 +0200 (CEST)","from mail-pg1-x544.google.com (mail-pg1-x544.google.com\n\t[IPv6:2607:f8b0:4864:20::544])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0AA6569189\n\tfor ;\n\tThu, 7 Oct 2021 09:22:17 +0200 (CEST)","by mail-pg1-x544.google.com with SMTP id h3so4840918pgb.7\n\tfor ;\n\tThu, 07 Oct 2021 00:22:16 -0700 (PDT)","from localhost ([2401:fa00:1:10:db0a:f55:d7cb:95ae])\n\tby smtp.gmail.com with UTF8SMTPSA id\n\tt28sm8227975pfq.158.2021.10.07.00.22.14\n\t(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n\tThu, 07 Oct 2021 00:22:15 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"eT6muaGE\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=JUPdGar9kUJMjHrK5iHzWnm1VLkae7BcpyAAR4GhvVc=;\n\tb=eT6muaGEq6ET4W+CdWQ/E+nfui4A5iv2V7987gyZfGPLIhCi66GVhhhVHVCKIxMCfS\n\tV7vaXwE6TZnVzdKHLUarX3CYrYwVSjWI8YtvxPh61NoEtrAKTTtoobZF1zJAvpJmlBdY\n\t/rqMlfI8WYt3kh6ylfj9gtsbJUojTekkXm4AA=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=JUPdGar9kUJMjHrK5iHzWnm1VLkae7BcpyAAR4GhvVc=;\n\tb=F+k1v3UbG5KNPa5T9nUO6TvFNvpS7P6a+LN42iWv3A1ljQgT75K1P7Cgrqef+KaIuw\n\t0xPXSGL6w2BIbuRQccXnS0IL9F/QipOicvmO21flVb+AY9fSItghapqv5RU0ETHSY+5k\n\tjvcJEpnM4k/iy39Q5i38dSVxDzzlWZwjJQ0/RpJW8v2XOwRhlTxgk8EOxsqORrnlYu6W\n\tQeIGyXU2km6qUnzJSPWlccQsd0spWB+/Hdqh/2kRteE0XXsQhLvjlKcnT0fkBcpZsWum\n\tSTUPEC8Yr74EJX7fKyFajsJX7r+LhaenMDMX85qCmv0g8oCDEdTGY5nFuwWU8Jq2yOXE\n\tw2FQ==","X-Gm-Message-State":"AOAM530Po2yqsbg2OuptoWCO+mxXLpVkcHdui+8BnOwzKmHTtC1jNzYn\n\tCPI2dg9XYobbPfQsC2N9DbBzy1TD/8l/ZHSUz04=","X-Google-Smtp-Source":"ABdhPJwjNVj7kuXDuvlR3Sm4cfHlrT18/OGJ2FYL5KFeq2PKWcjzNJUanvpFlboFOM48mP6qZt7iRA==","X-Received":"by 2002:a62:7904:0:b0:44c:ca08:1956 with SMTP id\n\tu4-20020a627904000000b0044cca081956mr250175pfc.47.1633591335327; \n\tThu, 07 Oct 2021 00:22:15 -0700 (PDT)","From":"Han-Lin Chen ","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 7 Oct 2021 15:21:47 +0800","Message-Id":"<20211007072147.1289490-3-hanlinchen@chromium.org>","X-Mailer":"git-send-email 2.33.0.882.g93a45727a2-goog","In-Reply-To":"<20211007072147.1289490-1-hanlinchen@chromium.org>","References":"<20211007072147.1289490-1-hanlinchen@chromium.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 3/3] ipu3: Apply shading adapter as\n\tpart of AIQ::run2a()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Apply shading adapter to correct lens shading for both camera.\n\nSigned-off-by: Han-Lin Chen \n---\n aiq/aiq.cpp | 3 +++\n aiq/aiq_input_parameters.cpp | 12 ++++++++++++\n 2 files changed, 15 insertions(+)","diff":"diff --git a/aiq/aiq.cpp b/aiq/aiq.cpp\nindex 708e9d6..24c61cb 100644\n--- a/aiq/aiq.cpp\n+++ b/aiq/aiq.cpp\n@@ -154,6 +154,9 @@ int AIQ::run2a(unsigned int frame, AiqInputParameters ¶ms,\n \tparams.paParams.exposure_params = results.ae()->exposures[0].exposure;\n \tparameterAdapterRun(params.paParams, results);\n \n+\tparams.saParams.awb_results = results.awb();\n+\tshadingAdapterRun(params.saParams, results);\n+\n \tafRun(params.afParams, results);\n \n \treturn 0;\ndiff --git a/aiq/aiq_input_parameters.cpp b/aiq/aiq_input_parameters.cpp\nindex 8a53849..36e2b07 100644\n--- a/aiq/aiq_input_parameters.cpp\n+++ b/aiq/aiq_input_parameters.cpp\n@@ -89,6 +89,15 @@ int AiqInputParameters::configure(const IPAConfigInfo &configInfo)\n \t/* Guess from hal-configs-nautilus/files/camera3_profiles.xml#263 */\n \tsensorDescriptor.coarse_integration_time_max_margin = 10;\n \n+\tsensorFrameParams.horizontal_crop_offset = 0;\n+\tsensorFrameParams.vertical_crop_offset = 0;\n+\tsensorFrameParams.cropped_image_width = configInfo.sensorInfo.analogCrop.width;\n+\tsensorFrameParams.cropped_image_height = configInfo.sensorInfo.analogCrop.height;\n+\tsensorFrameParams.horizontal_scaling_numerator = 1;\n+\tsensorFrameParams.horizontal_scaling_denominator = 1;\n+\tsensorFrameParams.vertical_scaling_numerator = 1;\n+\tsensorFrameParams.vertical_scaling_denominator = 1;\n+\n \treturn 0;\n }\n \n@@ -165,6 +174,9 @@ void AiqInputParameters::setAeAwbAfDefaults()\n \tgbceParams.tone_map_level = ia_aiq_tone_map_level_default;\n \tgbceParams.frame_use = ia_aiq_frame_use_still;\n \tgbceParams.ev_shift = 0;\n+\n+\t/* SA Params */\n+\tsaParams.frame_use = ia_aiq_frame_use_still;\n }\n \n } /* namespace ipa::ipu3::aiq */\n","prefixes":["libcamera-devel","v2","3/3"]}