[{"id":20063,"web_url":"https://patchwork.libcamera.org/comment/20063/","msgid":"","date":"2021-10-05T09:58:09","subject":"Re: [libcamera-devel] [PATCH] android: camera_stream: Set right\n\tformat for processor output buffer","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Hiro,\n\nThank you for the patch.\n\nOn Tue, Oct 05, 2021 at 06:27:57PM +0900, Hirokazu Honda wrote:\n> CameraStream always sets the format of processor output buffer to\n> MJPEG. This fixes the issue.\n> \n> Signed-off-by: Hirokazu Honda \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/android/camera_stream.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/android/camera_stream.cpp b/src/android/camera_stream.cpp\n> index e80f842d..db8d854b 100644\n> --- a/src/android/camera_stream.cpp\n> +++ b/src/android/camera_stream.cpp\n> @@ -168,7 +168,7 @@ int CameraStream::process(const FrameBuffer &source,\n> \t * separate thread.\n> \t */\n> \tconst StreamConfiguration &output = configuration();\n> -\tCameraBuffer dest(*camera3Dest.buffer, formats::MJPEG, output.size,\n> +\tCameraBuffer dest(*camera3Dest.buffer, output.pixelFormat, output.size,\n> \t\t\t PROT_READ | PROT_WRITE);\n> \tif (!dest.isValid()) {\n> \t\tLOG(HAL, Error) << \"Failed to map android blob buffer\";","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7FE05C3243\n\tfor ;\n\tTue, 5 Oct 2021 09:58:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F200B691B8;\n\tTue, 5 Oct 2021 11:58:18 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0935F691B6\n\tfor ;\n\tTue, 5 Oct 2021 11:58:17 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 775D625B;\n\tTue, 5 Oct 2021 11:58:16 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"UuOLL5gL\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1633427896;\n\tbh=P2bJHcWEKKeAG1Fn5siS+F6BBWaEQ0lp7XukMlNRqZM=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=UuOLL5gLOxyNCBSYcWGigQsW0jGl8y+lqR9gntCo0ebEHLykoav13RdQBoOzQZRlk\n\t8hvYOVJDdEjzfvtFAx/BajO27Fv5cQApi1PVaDvCqVQOU0dOtqkiq/wl1rJXSf06F+\n\tnnSXP4vC/kYMBAtLIvtrnmBiUoSIS7pBsuOxxxnM=","Date":"Tue, 5 Oct 2021 12:58:09 +0300","From":"Laurent Pinchart ","To":"Hirokazu Honda ","Message-ID":"","References":"<20211005092757.747697-1-hiroh@chromium.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20211005092757.747697-1-hiroh@chromium.org>","Subject":"Re: [libcamera-devel] [PATCH] android: camera_stream: Set right\n\tformat for processor output buffer","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":20072,"web_url":"https://patchwork.libcamera.org/comment/20072/","msgid":"<16ca1a81-d12c-4159-4dfe-f2818244bfa0@ideasonboard.com>","date":"2021-10-05T17:30:02","subject":"Re: [libcamera-devel] [PATCH] android: camera_stream: Set right\n\tformat for processor output buffer","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hello,\n\nThanks for  the patch.\n\nOn 10/5/21 2:57 PM, Hirokazu Honda wrote:\n> CameraStream always sets the format of processor output buffer to\n> MJPEG. This fixes the issue.\n>\n> Signed-off-by: Hirokazu Honda \n\n\nReviewed-by: Umang Jain \n\nI'll push the patch in sometime.\n\n> ---\n> src/android/camera_stream.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/src/android/camera_stream.cpp b/src/android/camera_stream.cpp\n> index e80f842d..db8d854b 100644\n> --- a/src/android/camera_stream.cpp\n> +++ b/src/android/camera_stream.cpp\n> @@ -168,7 +168,7 @@ int CameraStream::process(const FrameBuffer &source,\n> \t * separate thread.\n> \t */\n> \tconst StreamConfiguration &output = configuration();\n> -\tCameraBuffer dest(*camera3Dest.buffer, formats::MJPEG, output.size,\n> +\tCameraBuffer dest(*camera3Dest.buffer, output.pixelFormat, output.size,\n> \t\t\t PROT_READ | PROT_WRITE);\n> \tif (!dest.isValid()) {\n> \t\tLOG(HAL, Error) << \"Failed to map android blob buffer\";","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CCC1BC3243\n\tfor ;\n\tTue, 5 Oct 2021 17:30:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 480A3691B7;\n\tTue, 5 Oct 2021 19:30:10 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 47AB0684C6\n\tfor ;\n\tTue, 5 Oct 2021 19:30:08 +0200 (CEST)","from [192.168.1.106] (unknown [103.251.226.203])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DC64B25B;\n\tTue, 5 Oct 2021 19:30:06 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"H5xCO5R4\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1633455007;\n\tbh=ImV00Ux+XoivhjD+NkaLmPRfq2fObpmUsLOcDGaRB9M=;\n\th=Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=H5xCO5R4ESImFi5F88w/s3L9y5eMWZhgKfx3H1sIBcjTN7/vcZbd9Q8/5FXfJmCvS\n\tu2dW8tmtzyJCvJtVdlWAMev1Ry/3eWTAYk+mepBFaTs2/H3u09OOtA7mXEwvT6WPz2\n\tcMQdmvpCaLKpfeaZq1Cuf15Z48INj1kTfVZwp9Yk=","To":"Hirokazu Honda , libcamera-devel@lists.libcamera.org","References":"<20211005092757.747697-1-hiroh@chromium.org>","From":"Umang Jain ","Message-ID":"<16ca1a81-d12c-4159-4dfe-f2818244bfa0@ideasonboard.com>","Date":"Tue, 5 Oct 2021 23:00:02 +0530","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.10.2","MIME-Version":"1.0","In-Reply-To":"<20211005092757.747697-1-hiroh@chromium.org>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"8bit","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH] android: camera_stream: Set right\n\tformat for processor output buffer","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]