[{"id":1892,"web_url":"https://patchwork.libcamera.org/comment/1892/","msgid":"<20190613155914.73hzkbavikju3xmk@uno.localdomain>","date":"2019-06-13T15:59:14","subject":"Re: [libcamera-devel] [PATCH v2 09/16] libcamera: v4l2_device: Add\n\tenumeration of pixelformats and frame sizes","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Niklas,\n\nOn Wed, Jun 12, 2019 at 02:43:52AM +0200, Niklas Söderlund wrote:\n> Add methods to enumerate pixelformats and frame sizes from a v4l2\n> device. The interface is similar to how V4L2Subdevice enumerates mbus\n> codes and frame sizes.\n>\n> Signed-off-by: Niklas Söderlund \n> ---\n> src/libcamera/include/v4l2_device.h | 5 ++\n> src/libcamera/v4l2_device.cpp | 110 ++++++++++++++++++++++++++++\n> 2 files changed, 115 insertions(+)\n>\n> diff --git a/src/libcamera/include/v4l2_device.h b/src/libcamera/include/v4l2_device.h\n> index bdecc087fe5afae0..1a67850ac4c1088f 100644\n> --- a/src/libcamera/include/v4l2_device.h\n> +++ b/src/libcamera/include/v4l2_device.h\n> @@ -16,6 +16,7 @@\n> #include \n> #include \n>\n> +#include \"formats.h\"\n> #include \"log.h\"\n>\n> namespace libcamera {\n> @@ -132,6 +133,7 @@ public:\n>\n> \tint getFormat(V4L2DeviceFormat *format);\n> \tint setFormat(V4L2DeviceFormat *format);\n> +\tImageFormats formats();\n>\n> \tint exportBuffers(BufferPool *pool);\n> \tint importBuffers(BufferPool *pool);\n> @@ -163,6 +165,9 @@ private:\n> \tint createPlane(Buffer *buffer, unsigned int plane,\n> \t\t\tunsigned int length);\n>\n> +\tstd::vector enumPixelformats();\n> +\tstd::vector enumSizes(unsigned int pixelFormat);\n> +\n> \tBuffer *dequeueBuffer();\n> \tvoid bufferAvailable(EventNotifier *notifier);\n>\n> diff --git a/src/libcamera/v4l2_device.cpp b/src/libcamera/v4l2_device.cpp\n> index 0821bd75fb428766..202680d8632a4dd1 100644\n> --- a/src/libcamera/v4l2_device.cpp\n> +++ b/src/libcamera/v4l2_device.cpp\n> @@ -634,6 +634,29 @@ int V4L2Device::setFormatSingleplane(V4L2DeviceFormat *format)\n> \treturn 0;\n> }\n>\n> +/**\n> + * \\brief Enumerate all pixelformats and frame sizes\n> + *\n> + * Enumerate all pixelformats and frame sizes supported by the video device.\n\npixel formats\n\n> + *\n> + * \\return A list of the supported device formats\n> + */\n> +ImageFormats V4L2Device::formats()\n> +{\n> +\tImageFormats formats;\n> +\n> +\tfor (unsigned int pixelformat : enumPixelformats()) {\n> +\t\tif (formats.addFormat(pixelformat, enumSizes(pixelformat))) {\n> +\t\t\tLOG(V4L2, Error)\n> +\t\t\t\t<< \"Could not add sizes for pixel format \"\n> +\t\t\t\t<< pixelformat;\n> +\t\t\treturn {};\n> +\t\t}\n> +\t}\n> +\n> +\treturn formats;\n> +}\n> +\n> int V4L2Device::requestBuffers(unsigned int count)\n> {\n> \tstruct v4l2_requestbuffers rb = {};\n> @@ -763,6 +786,93 @@ int V4L2Device::createPlane(Buffer *buffer, unsigned int planeIndex,\n> \treturn 0;\n> }\n>\n> +std::vector V4L2Device::enumPixelformats()\n> +{\n> +\tstd::vector formats;\n> +\tint ret;\n> +\n> +\tfor (unsigned int index = 0; ; index++) {\n> +\t\tstruct v4l2_fmtdesc pixelformatEnum = {};\n> +\t\tpixelformatEnum.index = index;\n> +\t\tpixelformatEnum.type = bufferType_;\n> +\n> +\t\tret = ioctl(fd_, VIDIOC_ENUM_FMT, &pixelformatEnum);\n> +\t\tif (ret)\n> +\t\t\tbreak;\n> +\n> +\t\tformats.push_back(pixelformatEnum.pixelformat);\n> +\t}\n> +\n> +\tif (ret && errno != EINVAL) {\n> +\t\tret = -errno;\n> +\t\tLOG(V4L2, Error)\n> +\t\t\t<< \"Unable to enumerate pixelformats: \"\n> +\t\t\t<< strerror(-ret);\n> +\t\treturn {};\n> +\t}\n> +\n> +\treturn formats;\n> +}\n> +\n> +std::vector V4L2Device::enumSizes(unsigned int pixelFormat)\n> +{\n> +\tstd::vector sizes;\n> +\tint ret;\n> +\n> +\tfor (unsigned int index = 0;; index++) {\n> +\t\tstruct v4l2_frmsizeenum frameSize = {};\n> +\t\tframeSize.index = index;\n> +\t\tframeSize.pixel_format = pixelFormat;\n> +\n> +\t\tret = ioctl(fd_, VIDIOC_ENUM_FRAMESIZES, &frameSize);\n> +\t\tif (ret)\n> +\t\t\tbreak;\n> +\n> +\t\tif (index != 0 &&\n> +\t\t frameSize.type != V4L2_FRMSIZE_TYPE_DISCRETE) {\n> +\t\t\tLOG(V4L2, Error)\n> +\t\t\t\t<< \"Non-zero index for non discrete type\";\n> +\t\t\treturn {};\n> +\t\t}\n\nThis happens if the driver is out of specification, and as you know\nthis NEVER EVER happens. Joking aside, I would drop this check, true\nit doesn't hurt though...\n\n\n\n> +\n> +\t\tswitch (frameSize.type) {\n> +\t\tcase V4L2_FRMSIZE_TYPE_DISCRETE:\n> +\t\t\tsizes.emplace_back(frameSize.discrete.width,\n> +\t\t\t\t\t frameSize.discrete.height);\n> +\t\t\tbreak;\n> +\t\tcase V4L2_FRMSIZE_TYPE_CONTINUOUS:\n> +\t\t\tsizes.emplace_back(frameSize.stepwise.min_width,\n> +\t\t\t\t\t frameSize.stepwise.min_height,\n> +\t\t\t\t\t frameSize.stepwise.max_width,\n> +\t\t\t\t\t frameSize.stepwise.max_height);\n> +\t\t\tbreak;\n> +\t\tcase V4L2_FRMSIZE_TYPE_STEPWISE:\n> +\t\t\tsizes.emplace_back(frameSize.stepwise.min_width,\n> +\t\t\t\t\t frameSize.stepwise.min_height,\n> +\t\t\t\t\t frameSize.stepwise.max_width,\n> +\t\t\t\t\t frameSize.stepwise.max_height,\n> +\t\t\t\t\t frameSize.stepwise.step_width,\n> +\t\t\t\t\t frameSize.stepwise.step_height);\n> +\t\t\tbreak;\n> +\t\tdefault:\n> +\t\t\tLOG(V4L2, Error)\n> +\t\t\t\t<< \"Unknown VIDIOC_ENUM_FRAMESIZES type \"\n\n\"type: \"\n\nMinors apart\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n> +\t\t\t\t<< frameSize.type;\n> +\t\t\treturn {};\n> +\t\t}\n> +\t}\n> +\n> +\tif (ret && errno != EINVAL) {\n> +\t\tret = -errno;\n> +\t\tLOG(V4L2, Error)\n> +\t\t\t<< \"Unable to enumerate frame sizes: \"\n> +\t\t\t<< strerror(-ret);\n> +\t\treturn {};\n> +\t}\n> +\n> +\treturn sizes;\n> +}\n> +\n> /**\n> * \\brief Import the externally allocated \\a pool of buffers\n> * \\param[in] pool BufferPool of buffers to import\n> --\n> 2.21.0\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net\n\t[217.70.183.198])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BBE1861B25\n\tfor ;\n\tThu, 13 Jun 2019 17:58:01 +0200 (CEST)","from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 39278C0003;\n\tThu, 13 Jun 2019 15:58:00 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","Date":"Thu, 13 Jun 2019 17:59:14 +0200","From":"Jacopo Mondi ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190613155914.73hzkbavikju3xmk@uno.localdomain>","References":"<20190612004359.15772-1-niklas.soderlund@ragnatech.se>\n\t<20190612004359.15772-10-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"irdu3yrakqrveidt\"","Content-Disposition":"inline","In-Reply-To":"<20190612004359.15772-10-niklas.soderlund@ragnatech.se>","User-Agent":"NeoMutt/20180716","Subject":"Re: [libcamera-devel] [PATCH v2 09/16] libcamera: v4l2_device: Add\n\tenumeration of pixelformats and frame sizes","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 13 Jun 2019 15:58:01 -0000"}}]