[{"id":20058,"web_url":"https://patchwork.libcamera.org/comment/20058/","msgid":"","date":"2021-10-05T09:45:09","subject":"Re: [libcamera-devel] [RFC PATCH 5/6] lc-compliance: Remove using\n\tnamespace in header files","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Hiro,\n\nThank you for the patch.\n\nOn Tue, Oct 05, 2021 at 04:31:13PM +0900, Hirokazu Honda wrote:\n> \"using namespace\" in a header file propagates the namespace to\n> the files including the header file. So it should be avoided.\n> This removes \"using namespace\" in header files in lc-compliance.\n> \n> Signed-off-by: Hirokazu Honda \n> ---\n> src/lc-compliance/environment.cpp | 2 +-\n> src/lc-compliance/environment.h | 8 +++-----\n> 2 files changed, 4 insertions(+), 6 deletions(-)\n> \n> diff --git a/src/lc-compliance/environment.cpp b/src/lc-compliance/environment.cpp\n> index 9e24b5e3..f4583c8e 100644\n> --- a/src/lc-compliance/environment.cpp\n> +++ b/src/lc-compliance/environment.cpp\n> @@ -13,7 +13,7 @@ Environment *Environment::get()\n> \treturn &instance;\n> }\n> \n> -void Environment::setup(CameraManager *cm, std::string cameraId)\n> +void Environment::setup(libcamera::CameraManager *cm, std::string cameraId)\n\nHow about adding 'using namespace libcamera' in this file for\nconsistency ? I can change this when applying if desired.\n\nReviewed-by: Laurent Pinchart \n\n> {\n> \tcm_ = cm;\n> \tcameraId_ = cameraId;\n> diff --git a/src/lc-compliance/environment.h b/src/lc-compliance/environment.h\n> index 1c7d9a55..ba308732 100644\n> --- a/src/lc-compliance/environment.h\n> +++ b/src/lc-compliance/environment.h\n> @@ -9,23 +9,21 @@\n> \n> #include \n> \n> -using namespace libcamera;\n> -\n> class Environment\n> {\n> public:\n> \tstatic Environment *get();\n> \n> -\tvoid setup(CameraManager *cm, std::string cameraId);\n> +\tvoid setup(libcamera::CameraManager *cm, std::string cameraId);\n> \n> \tconst std::string &cameraId() const { return cameraId_; }\n> -\tCameraManager *cm() const { return cm_; }\n> +\tlibcamera::CameraManager *cm() const { return cm_; }\n> \n> private:\n> \tEnvironment() = default;\n> \n> \tstd::string cameraId_;\n> -\tCameraManager *cm_;\n> +\tlibcamera::CameraManager *cm_;\n> };\n> \n> #endif /* __LC_COMPLIANCE_ENVIRONMENT_H__ */","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 02C89BDC71\n\tfor ;\n\tTue, 5 Oct 2021 09:45:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C4BCA691B9;\n\tTue, 5 Oct 2021 11:45:17 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 63AFC684C6\n\tfor ;\n\tTue, 5 Oct 2021 11:45:16 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id F145525B;\n\tTue, 5 Oct 2021 11:45:15 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"cuX/xhWv\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1633427116;\n\tbh=AO2SZlUF1jQ1sLIzgDw3ZKWdgCPeQhC/R1vWBL4pIiI=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=cuX/xhWvqwhrCJAwPJX14tXnKKVK2HH8dQoiFnpbDR4eIyatkbAk8a42/ydrTBh69\n\td7a9qQrb8Zdfc5BhAa+JSM6xjqzK0HsWMArD21c7gqEykLZjp6zlDaV5zfuvuohiw9\n\t6iFxB1ZvflgEqu5pDKAm9mF6jEthtbR4qvpanUr4=","Date":"Tue, 5 Oct 2021 12:45:09 +0300","From":"Laurent Pinchart ","To":"Hirokazu Honda ","Message-ID":"","References":"<20211005073114.3997303-1-hiroh@chromium.org>\n\t<20211005073114.3997303-6-hiroh@chromium.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20211005073114.3997303-6-hiroh@chromium.org>","Subject":"Re: [libcamera-devel] [RFC PATCH 5/6] lc-compliance: Remove using\n\tnamespace in header files","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":20066,"web_url":"https://patchwork.libcamera.org/comment/20066/","msgid":"","date":"2021-10-05T10:26:25","subject":"Re: [libcamera-devel] [RFC PATCH 5/6] lc-compliance: Remove using\n\tnamespace in header files","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"content":"Hi Laurent,\n\nOn Tue, Oct 5, 2021 at 6:45 PM Laurent Pinchart\n wrote:\n>\n> Hi Hiro,\n>\n> Thank you for the patch.\n>\n> On Tue, Oct 05, 2021 at 04:31:13PM +0900, Hirokazu Honda wrote:\n> > \"using namespace\" in a header file propagates the namespace to\n> > the files including the header file. So it should be avoided.\n> > This removes \"using namespace\" in header files in lc-compliance.\n> >\n> > Signed-off-by: Hirokazu Honda \n> > ---\n> > src/lc-compliance/environment.cpp | 2 +-\n> > src/lc-compliance/environment.h | 8 +++-----\n> > 2 files changed, 4 insertions(+), 6 deletions(-)\n> >\n> > diff --git a/src/lc-compliance/environment.cpp b/src/lc-compliance/environment.cpp\n> > index 9e24b5e3..f4583c8e 100644\n> > --- a/src/lc-compliance/environment.cpp\n> > +++ b/src/lc-compliance/environment.cpp\n> > @@ -13,7 +13,7 @@ Environment *Environment::get()\n> > return &instance;\n> > }\n> >\n> > -void Environment::setup(CameraManager *cm, std::string cameraId)\n> > +void Environment::setup(libcamera::CameraManager *cm, std::string cameraId)\n>\n> How about adding 'using namespace libcamera' in this file for\n> consistency ? I can change this when applying if desired.\n>\n\nI did so because this file is small enough.\nPlease feel free to do so if you prefer.\n\nThanks,\n-Hiro\n\n> Reviewed-by: Laurent Pinchart \n>\n> > {\n> > cm_ = cm;\n> > cameraId_ = cameraId;\n> > diff --git a/src/lc-compliance/environment.h b/src/lc-compliance/environment.h\n> > index 1c7d9a55..ba308732 100644\n> > --- a/src/lc-compliance/environment.h\n> > +++ b/src/lc-compliance/environment.h\n> > @@ -9,23 +9,21 @@\n> >\n> > #include \n> >\n> > -using namespace libcamera;\n> > -\n> > class Environment\n> > {\n> > public:\n> > static Environment *get();\n> >\n> > - void setup(CameraManager *cm, std::string cameraId);\n> > + void setup(libcamera::CameraManager *cm, std::string cameraId);\n> >\n> > const std::string &cameraId() const { return cameraId_; }\n> > - CameraManager *cm() const { return cm_; }\n> > + libcamera::CameraManager *cm() const { return cm_; }\n> >\n> > private:\n> > Environment() = default;\n> >\n> > std::string cameraId_;\n> > - CameraManager *cm_;\n> > + libcamera::CameraManager *cm_;\n> > };\n> >\n> > #endif /* __LC_COMPLIANCE_ENVIRONMENT_H__ */\n>\n> --\n> Regards,\n>\n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id ABCFCC3243\n\tfor ;\n\tTue, 5 Oct 2021 10:26:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 70F12691BA;\n\tTue, 5 Oct 2021 12:26:40 +0200 (CEST)","from mail-ed1-x533.google.com (mail-ed1-x533.google.com\n\t[IPv6:2a00:1450:4864:20::533])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 766DD684C6\n\tfor ;\n\tTue, 5 Oct 2021 12:26:39 +0200 (CEST)","by mail-ed1-x533.google.com with SMTP id x7so74166485edd.6\n\tfor ;\n\tTue, 05 Oct 2021 03:26:39 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"Xgf39w/F\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=hwFApqV2BQetcoWy9SrLo3GAV1O6z6g0uOXN4BWs870=;\n\tb=Xgf39w/FkWrpdU80UHu3ImvGyuAKwJXDTpfHnJY8pEfyKS/P+D7KsTzsoNEuLpCpyr\n\tuM43Mhq32VckeE2N6OLJdj2Lij7QHq4/CZVEAZB9Y9HCiVQrN6kTezdIm/qUkLHcytNp\n\tHA2NO2Lhp9ecDXRiFyvEEkUQL3w7u7jzEwBDk=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=hwFApqV2BQetcoWy9SrLo3GAV1O6z6g0uOXN4BWs870=;\n\tb=2U3iySgKjU2eXLLuh6/Z0Kr0amA73ahdiwEgHDvGBFPv2/qILMnda/e1oSlL92uAKf\n\tvxXVQu15t7OFAh5SxzypKpK5G5wVVurndPLy4I7Q5G6zP+Vc+gGbc2VwHvqgpByRa0rW\n\tXDbz+G5PGgK+ZtHj59cHvVkWW9vgUSmP90Uyo4u2ZMKfxkGdzpPT4KWXmEfyNsdijnWp\n\thNxCoB2tSelTp7JdA5XxJ4aBWmPd45PabT94FQvk6d5Ato7/UfFQ4T6dWp+52S1oRBuQ\n\t8ishCYk499DJ3z4WS2LS6FUx+9e8I28yn+DXKSbl8CRQJBXqH/LaDqgUn/bRSD1ZTTK8\n\t/XvA==","X-Gm-Message-State":"AOAM5304LnbpCU4Sx8ESeF/vEd9IFRhWOh9yeFTiJX8vmda23eZ/9dKd\n\tG0qnE6vujCjn8Pl68nBCZLFKD0Wq9dtIpSdpjLB72w==","X-Google-Smtp-Source":"ABdhPJy7ISa3QCBy7kz9zbIKSirLbBtscq2UnE8Cif5wBirShme8MLtL0jtZ0qCSjKouWk0SSGEPCCDs1ewMs7C4NzA=","X-Received":"by 2002:a17:906:1f49:: with SMTP id\n\td9mr24309049ejk.150.1633429597640; \n\tTue, 05 Oct 2021 03:26:37 -0700 (PDT)","MIME-Version":"1.0","References":"<20211005073114.3997303-1-hiroh@chromium.org>\n\t<20211005073114.3997303-6-hiroh@chromium.org>\n\t","In-Reply-To":"","From":"Hirokazu Honda ","Date":"Tue, 5 Oct 2021 19:26:25 +0900","Message-ID":"","To":"Laurent Pinchart ","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [RFC PATCH 5/6] lc-compliance: Remove using\n\tnamespace in header files","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]