{"id":14049,"url":"https://patchwork.libcamera.org/api/patches/14049/?format=json","web_url":"https://patchwork.libcamera.org/patch/14049/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20211005073114.3997303-6-hiroh@chromium.org>","date":"2021-10-05T07:31:13","name":"[libcamera-devel,RFC,5/6] lc-compliance: Remove using namespace in header files","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"7ab88e9b0c44e1ce63e4dd4365e4a51e2acadecc","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/?format=json","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/14049/mbox/","series":[{"id":2602,"url":"https://patchwork.libcamera.org/api/series/2602/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2602","date":"2021-10-05T07:31:08","name":"Remove using namespace in header files","version":1,"mbox":"https://patchwork.libcamera.org/series/2602/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/14049/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/14049/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 79EEDBDC71\n\tfor ;\n\tTue, 5 Oct 2021 07:31:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 49A1F691B9;\n\tTue, 5 Oct 2021 09:31:35 +0200 (CEST)","from mail-pf1-x42c.google.com (mail-pf1-x42c.google.com\n\t[IPv6:2607:f8b0:4864:20::42c])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AF204691BD\n\tfor ;\n\tTue, 5 Oct 2021 09:31:33 +0200 (CEST)","by mail-pf1-x42c.google.com with SMTP id g2so16646752pfc.6\n\tfor ;\n\tTue, 05 Oct 2021 00:31:33 -0700 (PDT)","from hiroh2.tok.corp.google.com\n\t([2401:fa00:8f:203:debc:d0db:3bd8:f961])\n\tby smtp.gmail.com with ESMTPSA id\n\to14sm16761812pfh.145.2021.10.05.00.31.30\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 05 Oct 2021 00:31:31 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"OfBuA1sX\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=fhp6VldNPONO2CVYik2Y7RItvUuE5jx8y/8HeWR21IQ=;\n\tb=OfBuA1sX3PQGl3QdiNV8NjVWfwnwcApdBBC+AVfHSyFfX9resPO1IpeO6YPRBe6jcy\n\tXmyamOhvJ5svbwU92y61YTnJ2IMHjeS0RKh5KjJKeOAaYarrk9x1Tp5flP3XEm8lOy9V\n\tuulc7uOjL2DAa3j4T5kVw10pi6JNBYIxSiPpw=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=fhp6VldNPONO2CVYik2Y7RItvUuE5jx8y/8HeWR21IQ=;\n\tb=1NlOUfjg9Z9icDul1+OIBFmZEhYj4lkldxr8rqpVqGTY/3qQ6tndsDE6rHwizHGZ6+\n\tjP4r/2wGywFzytro9uVPSkfinBoAmPo13uq3Hoc4Ut0v3ChDkph47ZNYO7clVE7hSogR\n\tmlzdVroAKRe4eci2vAahEjWO1zc8v8ZSvIVP0DiI8CdI65Is5uAfIOwlZk9/TsXE5Dvr\n\tmgKKPt3OJ3b3meoqavG1shXFNGMuERdrotJArc+qc7LyvhKIrQ3npM8qA9WKE0VE1qRm\n\tAQf04IJM6hQmCgFXaFaLky6hsGWJE2AEHImTxMx8flR4SbBIGQ2m7Qp7LkbGxVYcxNoV\n\tUkAQ==","X-Gm-Message-State":"AOAM530xINrWW9kT6LkfvsI2uV/eXBadViLgebg7DHlhZ/XmiZ5iWKwx\n\th9whj/viY+6JThzLPYZdAEFZUPUNlcNEwg==","X-Google-Smtp-Source":"ABdhPJyQkiylkda9Z/F7U23G9Z03SSfTtgcuo+2j/2bPY/n/Qij4zPF1FEUNaxCqffhp5HuzHDqeDg==","X-Received":"by 2002:a62:d11e:0:b0:446:d705:7175 with SMTP id\n\tz30-20020a62d11e000000b00446d7057175mr29448098pfg.74.1633419091991; \n\tTue, 05 Oct 2021 00:31:31 -0700 (PDT)","From":"Hirokazu Honda ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 5 Oct 2021 16:31:13 +0900","Message-Id":"<20211005073114.3997303-6-hiroh@chromium.org>","X-Mailer":"git-send-email 2.33.0.800.g4c38ced690-goog","In-Reply-To":"<20211005073114.3997303-1-hiroh@chromium.org>","References":"<20211005073114.3997303-1-hiroh@chromium.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [RFC PATCH 5/6] lc-compliance: Remove using\n\tnamespace in header files","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"\"using namespace\" in a header file propagates the namespace to\nthe files including the header file. So it should be avoided.\nThis removes \"using namespace\" in header files in lc-compliance.\n\nSigned-off-by: Hirokazu Honda \n---\n src/lc-compliance/environment.cpp | 2 +-\n src/lc-compliance/environment.h | 8 +++-----\n 2 files changed, 4 insertions(+), 6 deletions(-)","diff":"diff --git a/src/lc-compliance/environment.cpp b/src/lc-compliance/environment.cpp\nindex 9e24b5e3..f4583c8e 100644\n--- a/src/lc-compliance/environment.cpp\n+++ b/src/lc-compliance/environment.cpp\n@@ -13,7 +13,7 @@ Environment *Environment::get()\n \treturn &instance;\n }\n \n-void Environment::setup(CameraManager *cm, std::string cameraId)\n+void Environment::setup(libcamera::CameraManager *cm, std::string cameraId)\n {\n \tcm_ = cm;\n \tcameraId_ = cameraId;\ndiff --git a/src/lc-compliance/environment.h b/src/lc-compliance/environment.h\nindex 1c7d9a55..ba308732 100644\n--- a/src/lc-compliance/environment.h\n+++ b/src/lc-compliance/environment.h\n@@ -9,23 +9,21 @@\n \n #include \n \n-using namespace libcamera;\n-\n class Environment\n {\n public:\n \tstatic Environment *get();\n \n-\tvoid setup(CameraManager *cm, std::string cameraId);\n+\tvoid setup(libcamera::CameraManager *cm, std::string cameraId);\n \n \tconst std::string &cameraId() const { return cameraId_; }\n-\tCameraManager *cm() const { return cm_; }\n+\tlibcamera::CameraManager *cm() const { return cm_; }\n \n private:\n \tEnvironment() = default;\n \n \tstd::string cameraId_;\n-\tCameraManager *cm_;\n+\tlibcamera::CameraManager *cm_;\n };\n \n #endif /* __LC_COMPLIANCE_ENVIRONMENT_H__ */\n","prefixes":["libcamera-devel","RFC","5/6"]}