{"id":14026,"url":"https://patchwork.libcamera.org/api/patches/14026/?format=json","web_url":"https://patchwork.libcamera.org/patch/14026/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20211001211525.1423725-2-javierm@redhat.com>","date":"2021-10-01T21:15:25","name":"[libcamera-devel,v2,2/2] android: Check if Stream configurations were generated correctly","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"d75d2459ed8dffe6858d8c440ff2aeaf933f8448","submitter":{"id":95,"url":"https://patchwork.libcamera.org/api/people/95/?format=json","name":"Javier Martinez Canillas","email":"javierm@redhat.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/14026/mbox/","series":[{"id":2591,"url":"https://patchwork.libcamera.org/api/series/2591/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2591","date":"2021-10-01T21:15:24","name":"[libcamera-devel,v2,1/2] gstreamer: Check if Stream configurations were generated correctly","version":2,"mbox":"https://patchwork.libcamera.org/series/2591/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/14026/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/14026/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C05BBBDC71\n\tfor ;\n\tFri, 1 Oct 2021 21:15:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 83902691AA;\n\tFri, 1 Oct 2021 23:15:59 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 50E56691A6\n\tfor ;\n\tFri, 1 Oct 2021 23:15:57 +0200 (CEST)","from mail-wm1-f70.google.com (mail-wm1-f70.google.com\n\t[209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id\n\tus-mta-488-LRjnSPMBPDapBPQfuEBwZA-1; Fri, 01 Oct 2021 17:15:55 -0400","by mail-wm1-f70.google.com with SMTP id\n\tn30-20020a05600c3b9e00b002fbbaada5d7so6490790wms.7\n\tfor ;\n\tFri, 01 Oct 2021 14:15:54 -0700 (PDT)","from minerva.home ([92.176.231.106])\n\tby smtp.gmail.com with ESMTPSA id\n\ty11sm8242871wrg.18.2021.10.01.14.15.52\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 01 Oct 2021 14:15:52 -0700 (PDT)"],"Authentication-Results":["lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"jLqbjDq7\"; dkim-atps=neutral","relay.mimecast.com;\n\tauth=pass smtp.auth=CUSA124A263 smtp.mailfrom=javierm@redhat.com"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1633122956;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=crN8ugqgp3xaIBmuWZYMPqudPOK97CfYk3r3GgNJ5EA=;\n\tb=jLqbjDq7RSkKuuX+tdlPuM787F0sZPzM28vUeYtolngdIB1pk4uE+f7jnnukgL7HzcggK3\n\tsHs9vpT5fHgpfKiFE1epj1AwNn6ZkEQ9KYmTVdNYxchSwvbth/mPKGuRdixxHqelydPuBf\n\tQEsBmX71yYuTBd6csjvkNlFQznPtA2U=","X-MC-Unique":"LRjnSPMBPDapBPQfuEBwZA-1","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=crN8ugqgp3xaIBmuWZYMPqudPOK97CfYk3r3GgNJ5EA=;\n\tb=hgZUxAv9MOR0gJBv75i0THFfMaw/obGlRI59T+vCs9Ur7E+imIOTUZatJJ0gJqvp0X\n\tlbgD2PxGqDPH3q5hLBR5CTfxyNu7LU7HNFM/9JSUvU/rjGeDm8XL0VFOdZZt/5EoSg4M\n\t04ErpjvS3Bz2o3WjFV/uM6v7GWzYoNrFuCFaWzQnkiTzuA7k573beCtXOKRpMRaL5+8q\n\t49X9uVyY4/OpPslnHkcfYM5+T9+g+866U4liO9IUMG5QDl29KlpoEOIqkgrTWQ7ujewU\n\tXCnd8xcr/SgkK36uQE7CVCl63mXuogyuvq160vXMVguNMglM0G+HePeVP8Cvizif5PvS\n\tPwhg==","X-Gm-Message-State":"AOAM531HTrkXRsaJXJ3otjdeSTbNGFFEXuCUS9MIiOOF4SmeSwlqHNXh\n\tUporQz6GH6/VtkS6iBQ45qfbIVAiSQ1W/h6p4w1jaWfaF2YP5Xxh4vwYy4R5OMb/EaXaq/WNvTD\n\tZP7YWrMfUOc98lU5sbnV4PSJHIsAkrxdEEZY4MBfSyCLuTZXiv4JYejDJJBDV665dpFxu6faP7w\n\tLZrjq20nly","X-Received":["by 2002:a05:6000:550:: with SMTP id\n\tb16mr124292wrf.297.1633122953458; \n\tFri, 01 Oct 2021 14:15:53 -0700 (PDT)","by 2002:a05:6000:550:: with SMTP id\n\tb16mr124277wrf.297.1633122953163; \n\tFri, 01 Oct 2021 14:15:53 -0700 (PDT)"],"X-Google-Smtp-Source":"ABdhPJxNRtFbi8wI2vAqzXTnMQmGs3ldTgJYSKYuYp/65Nmf30jKX3j+d1J5aR0MiW5xSdxdoRcjlQ==","From":"Javier Martinez Canillas ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 1 Oct 2021 23:15:25 +0200","Message-Id":"<20211001211525.1423725-2-javierm@redhat.com>","X-Mailer":"git-send-email 2.31.1","In-Reply-To":"<20211001211525.1423725-1-javierm@redhat.com>","References":"<20211001211525.1423725-1-javierm@redhat.com>","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Transfer-Encoding":"8bit","Content-Type":"text/plain; charset=\"US-ASCII\"","Subject":"[libcamera-devel] [PATCH v2 2/2] android: Check if Stream\n\tconfigurations were generated correctly","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The libcamera Android Camera HAL generates camera configurations for the\nStillCapture, Raw and ViewFinder stream roles. But there is only a check\nif the configuration generation failed, for the StillCapture stream role.\n\nThis could lead to a NULL pointer dereference if a pipeline handler fails\nto generate a default configuration for one of the other two stream roles.\n\nSigned-off-by: Javier Martinez Canillas \n---\n\nChanges in v2:\n- Fix typos in commit message.\n\n src/android/camera_capabilities.cpp | 13 ++++++++++++-\n 1 file changed, 12 insertions(+), 1 deletion(-)","diff":"diff --git a/src/android/camera_capabilities.cpp b/src/android/camera_capabilities.cpp\nindex 87a6e1c6f26..baeedc11500 100644\n--- a/src/android/camera_capabilities.cpp\n+++ b/src/android/camera_capabilities.cpp\n@@ -408,6 +408,11 @@ CameraCapabilities::initializeYUVResolutions(const PixelFormat &pixelFormat,\n \tstd::vector supportedResolutions;\n \tstd::unique_ptr cameraConfig =\n \t\tcamera_->generateConfiguration({ StreamRole::Viewfinder });\n+\tif (!cameraConfig) {\n+\t\tLOG(HAL, Error) << \"Failed to get supported YUV resolutions\";\n+\t\treturn supportedResolutions;\n+\t}\n+\n \tStreamConfiguration &cfg = cameraConfig->at(0);\n \n \tfor (const Size &res : resolutions) {\n@@ -431,11 +436,17 @@ CameraCapabilities::initializeYUVResolutions(const PixelFormat &pixelFormat,\n std::vector\n CameraCapabilities::initializeRawResolutions(const PixelFormat &pixelFormat)\n {\n+\tstd::vector supportedResolutions;\n \tstd::unique_ptr cameraConfig =\n \t\tcamera_->generateConfiguration({ StreamRole::Raw });\n+\tif (!cameraConfig) {\n+\t\tLOG(HAL, Error) << \"Failed to get supported Raw resolutions\";\n+\t\treturn supportedResolutions;\n+\t}\n+\n \tStreamConfiguration &cfg = cameraConfig->at(0);\n \tconst StreamFormats &formats = cfg.formats();\n-\tstd::vector supportedResolutions = formats.sizes(pixelFormat);\n+\tsupportedResolutions = formats.sizes(pixelFormat);\n \n \treturn supportedResolutions;\n }\n","prefixes":["libcamera-devel","v2","2/2"]}