[{"id":20624,"web_url":"https://patchwork.libcamera.org/comment/20624/","msgid":"<163549619474.12048.12929725742829232539@Monstersaurus>","date":"2021-10-29T08:29:54","subject":"Re: [libcamera-devel] [PATCH v2 4/7] test: ipa_data_serializer:\n\tRemove controls::AeEnable","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Paul Elder (2021-10-01 11:33:22)\n> Remove controls::AeEnable from the IPA data serializer test, as it is no\n> longer an available control.\n\nHas AeEnable been removed from the control declarations? If so, does\nthis need to be merged with it to prevent compilation failures?\n\nOr otherwise, should it be removed? (In this patch?)\n\n\nI've just grabbed your current development branch, and indeed there is\ncompilation breakage in \"controls: Reorganize the AE-related controls\"\n\nso this needs to be handled in a way that will keep each commit\ncompiling to prevent bisection.\n\n--\nKieran\n\n\n> \n> Bug: https://bugs.libcamera.org/show_bug.cgi?id=42\n> Bug: https://bugs.libcamera.org/show_bug.cgi?id=43\n> Signed-off-by: Paul Elder \n> \n> ---\n> No change in v2\n> ---\n> test/serialization/ipa_data_serializer_test.cpp | 1 -\n> 1 file changed, 1 deletion(-)\n> \n> diff --git a/test/serialization/ipa_data_serializer_test.cpp b/test/serialization/ipa_data_serializer_test.cpp\n> index 5fcdcb8e..85ad4d04 100644\n> --- a/test/serialization/ipa_data_serializer_test.cpp\n> +++ b/test/serialization/ipa_data_serializer_test.cpp\n> @@ -33,7 +33,6 @@ using namespace std;\n> using namespace libcamera;\n> \n> static const ControlInfoMap Controls = ControlInfoMap({\n> - { &controls::AeEnable, ControlInfo(false, true) },\n> { &controls::ExposureTime, ControlInfo(0, 999999) },\n> { &controls::AnalogueGain, ControlInfo(1.0f, 32.0f) },\n> { &controls::ColourGains, ControlInfo(0.0f, 32.0f) },\n> -- \n> 2.27.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7EB68BF415\n\tfor ;\n\tFri, 29 Oct 2021 08:29:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D15CA600BB;\n\tFri, 29 Oct 2021 10:29:58 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AE2D9600B4\n\tfor ;\n\tFri, 29 Oct 2021 10:29:57 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 366183E5;\n\tFri, 29 Oct 2021 10:29:57 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Or1evFPz\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1635496197;\n\tbh=qM5l2laZ4QmvKes2ywR/iZVsQS84wfSM29aGPnpAZ+U=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=Or1evFPzg8Xus4wLrJmWqKkWPnlbIN1eN/cbiWzMJEk41F733Nkd4/7+RQpf0FxXK\n\tFkNPbDC/8tKkKzhd6IKayj2Iu1PGnCWmdtfYnuhbWOjvFlbum4C0VtPGLpW5CofNq0\n\tQkkhlWdTaZYwpEqBX73iOhnFrQpQHLImuV39CFSM=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20211001103325.1077590-5-paul.elder@ideasonboard.com>","References":"<20211001103325.1077590-1-paul.elder@ideasonboard.com>\n\t<20211001103325.1077590-5-paul.elder@ideasonboard.com>","From":"Kieran Bingham ","To":"Paul Elder ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Fri, 29 Oct 2021 09:29:54 +0100","Message-ID":"<163549619474.12048.12929725742829232539@Monstersaurus>","User-Agent":"alot/0.9.1","Subject":"Re: [libcamera-devel] [PATCH v2 4/7] test: ipa_data_serializer:\n\tRemove controls::AeEnable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]