[{"id":20013,"web_url":"https://patchwork.libcamera.org/comment/20013/","msgid":"<65267e76-54ac-9e27-ce85-5ac1eafb22e2@ideasonboard.com>","date":"2021-09-30T10:59:10","subject":"Re: [libcamera-devel] [PATCH 13/18] ipa: ipu3: Isolate ipa_context\n\tdocumentation","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi JM,\n\nOn 30/09/2021 10:55, Jean-Michel Hautbois wrote:\n> From: Kieran Bingham \n> \n> The IPU3 IPA core is growing with additional documentation. The\n> ipa_context documentation is stored here, but it pushes the IPU3\n> documentation and implementation further from the head of the file.\n> \n> Furthermore, the ipa_context documentation is outside of the ipa::ipu3\n> namespace and isn't identified correctly by Doxygen.\n> \n> Move the ipa_context to its own compilation object even though there\n> isn't any code, but to maintain consistency with our documentation\n> model.\n> \n> Correctly re-introduce the documentation into the libcamera::ipa::ipu3\n> namespace during the move.\n> \n> Signed-off-by: Kieran Bingham \n> ---\n> src/ipa/ipu3/ipa_context.cpp | 113 +++++++++++++++++++++++++++++++++++\n> src/ipa/ipu3/ipu3.cpp | 104 --------------------------------\n> src/ipa/ipu3/meson.build | 1 +\n> 3 files changed, 114 insertions(+), 104 deletions(-)\n> create mode 100644 src/ipa/ipu3/ipa_context.cpp\n> \n> diff --git a/src/ipa/ipu3/ipa_context.cpp b/src/ipa/ipu3/ipa_context.cpp\n> new file mode 100644\n> index 00000000..40d79772\n> --- /dev/null\n> +++ b/src/ipa/ipu3/ipa_context.cpp\n> @@ -0,0 +1,113 @@\n> +/* SPDX-License-Identifier: LGPL-2.1-or-later */\n> +/*\n> + * Copyright (C) 2021, Google Inc.\n> + *\n> + * ipa_context.cpp - IPU3 IPA Context\n> + */\n> +\n> +#include \"ipa_context.h\"\n> +\n> +namespace libcamera::ipa::ipu3 {\n> +\n> +/**\n> + * \\file ipa_context.h\n> + * \\brief Context and state information shared between the algorithms\n> + */\n> +\n> +/**\n> + * \\struct IPASessionConfiguration\n> + * \\brief Session configuration for the IPA module\n> + *\n> + * The session configuration contains all IPA configuration parameters that\n> + * remain constant during the capture session, from IPA module start to stop.\n> + * It is typically set during the configure() operation of the IPA module, but\n> + * may also be updated in the start() operation.\n> + */\n> +\n> +/**\n> + * \\struct IPAFrameContext\n> + * \\brief Per-frame context for algorithms\n> + *\n> + * The frame context stores data specific to a single frame processed by the\n> + * IPA. Each frame processed by the IPA has a context associated with it,\n> + * accessible through the IPAContext structure.\n> + *\n> + * \\todo Detail how to access contexts for a particular frame\n> + *\n> + * Each of the fields in the frame context belongs to either a specific\n> + * algorithm, or to the top-level IPA module. A field may be read by any\n> + * algorithm, but should only be written by its owner.\n> + */\n> +\n> +/**\n> + * \\struct IPAContext\n> + * \\brief Global IPA context data shared between all algorithms\n> + *\n> + * \\var IPAContext::configuration\n> + * \\brief The IPA session configuration, immutable during the session\n> + *\n> + * \\var IPAContext::frameContext\n> + * \\brief The frame context for the frame being processed\n> + *\n> + * \\todo While the frame context is supposed to be per-frame, this\n> + * single frame context stores data related to both the current frame\n> + * and the previous frames, with fields being updated as the algorithms\n> + * are run. This needs to be turned into real per-frame data storage.\n> + */\n> +\n> +/**\n> + * \\struct IPASessionConfiguration::grid\n> + * \\brief Grid configuration of the IPA\n> + *\n> + * \\var IPASessionConfiguration::grid::bdsGrid\n> + * \\brief Bayer Down Scaler grid plane config used by the kernel\n> + *\n> + * \\var IPASessionConfiguration::grid::bdsOutputSize\n> + * \\brief BDS output size configured by the pipeline handler\n> + */\n> +\n> +/**\n> + * \\struct IPAFrameContext::agc\n> + * \\brief Context for the Automatic Gain Control algorithm\n> + *\n> + * The exposure and gain determined are expected to be applied to the sensor\n> + * at the earliest opportunity.\n> + *\n> + * \\var IPAFrameContext::agc::exposure\n> + * \\brief Exposure time expressed as a number of lines\n> + *\n> + * \\var IPAFrameContext::agc::gain\n> + * \\brief Analogue gain multiplier\n> + *\n> + * The gain should be adapted to the sensor specific gain code before applying.\n> + */\n> +\n> +/**\n> + * \\struct IPAFrameContext::awb\n> + * \\brief Context for the Automatic White Balance algorithm\n> + *\n> + * \\struct IPAFrameContext::awb::gains\n> + * \\brief White balance gains\n> + *\n> + * \\var IPAFrameContext::awb::gains::red\n> + * \\brief White balance gain for R channel\n> + *\n> + * \\var IPAFrameContext::awb::gains::green\n> + * \\brief White balance gain for G channel\n> + *\n> + * \\var IPAFrameContext::awb::gains::blue\n> + * \\brief White balance gain for B channel\n> + */\n> +\n> +/**\n> + * \\struct IPAFrameContext::toneMapping\n> + * \\brief Context for ToneMapping and Gamma control\n> + *\n\nI think this now causes\n\n * \\var IPAFrameContext::toneMapping::gamma\n * \\brief Gamma value for the LUT\n\nto be dropped from here, and needs to be added in.\n\n\n\n> + * \\var IPAFrameContext::toneMapping::gammaCorrection\n> + * \\brief Per-pixel tone mapping implemented as a LUT\n> + *\n> + * The LUT structure is defined by the IPU3 kernel interface. See\n> + * struct ipu3_uapi_gamma_corr_lut for further details.\n> + */\n> +\n> +} /* namespace libcamera::ipa::ipu3 */\n> diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\n> index 9867c993..1b1fc052 100644\n> --- a/src/ipa/ipu3/ipu3.cpp\n> +++ b/src/ipa/ipu3/ipu3.cpp\n> @@ -37,110 +37,6 @@\n> #include \"algorithms/tone_mapping.h\"\n> #include \"libipa/camera_sensor_helper.h\"\n> \n> -/**\n> - * \\file ipa_context.h\n> - * \\brief Context and state information shared between the algorithms\n> - */\n> -\n> -/**\n> - * \\struct IPASessionConfiguration\n> - * \\brief Session configuration for the IPA module\n> - *\n> - * The session configuration contains all IPA configuration parameters that\n> - * remain constant during the capture session, from IPA module start to stop.\n> - * It is typically set during the configure() operation of the IPA module, but\n> - * may also be updated in the start() operation.\n> - */\n> -\n> -/**\n> - * \\struct IPAFrameContext\n> - * \\brief Per-frame context for algorithms\n> - *\n> - * The frame context stores data specific to a single frame processed by the\n> - * IPA. Each frame processed by the IPA has a context associated with it,\n> - * accessible through the IPAContext structure.\n> - *\n> - * \\todo Detail how to access contexts for a particular frame\n> - *\n> - * Each of the fields in the frame context belongs to either a specific\n> - * algorithm, or to the top-level IPA module. A field may be read by any\n> - * algorithm, but should only be written by its owner.\n> - */\n> -\n> -/**\n> - * \\struct IPAContext\n> - * \\brief Global IPA context data shared between all algorithms\n> - *\n> - * \\var IPAContext::configuration\n> - * \\brief The IPA session configuration, immutable during the session\n> - *\n> - * \\var IPAContext::frameContext\n> - * \\brief The frame context for the frame being processed\n> - *\n> - * \\todo While the frame context is supposed to be per-frame, this\n> - * single frame context stores data related to both the current frame\n> - * and the previous frames, with fields being updated as the algorithms\n> - * are run. This needs to be turned into real per-frame data storage.\n> - */\n> -\n> -/**\n> - * \\struct IPASessionConfiguration::grid\n> - * \\brief Grid configuration of the IPA\n> - *\n> - * \\var IPASessionConfiguration::grid::bdsGrid\n> - * \\brief Bayer Down Scaler grid plane config used by the kernel\n> - *\n> - * \\var IPASessionConfiguration::grid::bdsOutputSize\n> - * \\brief BDS output size configured by the pipeline handler\n> - */\n> -\n> -/**\n> - * \\struct IPAFrameContext::agc\n> - * \\brief Context for the Automatic Gain Control algorithm\n> - *\n> - * The exposure and gain determined are expected to be applied to the sensor\n> - * at the earliest opportunity.\n> - *\n> - * \\var IPAFrameContext::agc::exposure\n> - * \\brief Exposure time expressed as a number of lines\n> - *\n> - * \\var IPAFrameContext::agc::gain\n> - * \\brief Analogue gain multiplier\n> - *\n> - * The gain should be adapted to the sensor specific gain code before applying.\n> - */\n> -\n> -/**\n> - * \\struct IPAFrameContext::awb\n> - * \\brief Context for the Automatic White Balance algorithm\n> - *\n> - * \\struct IPAFrameContext::awb::gains\n> - * \\brief White balance gains\n> - *\n> - * \\var IPAFrameContext::awb::gains::red\n> - * \\brief White balance gain for R channel\n> - *\n> - * \\var IPAFrameContext::awb::gains::green\n> - * \\brief White balance gain for G channel\n> - *\n> - * \\var IPAFrameContext::awb::gains::blue\n> - * \\brief White balance gain for B channel\n> - */\n> -\n> -/**\n> - * \\struct IPAFrameContext::toneMapping\n> - * \\brief Context for ToneMapping and Gamma control\n> - *\n> - * \\var IPAFrameContext::toneMapping::gamma\n> - * \\brief Gamma value for the LUT\n> - *\n> - * \\var IPAFrameContext::toneMapping::gammaCorrection\n> - * \\brief Per-pixel tone mapping implemented as a LUT\n> - *\n> - * The LUT structure is defined by the IPU3 kernel interface. See\n> - * struct ipu3_uapi_gamma_corr_lut for further details.\n> - */\n> -\n> /* Minimum grid width, expressed as a number of cells */\n> static constexpr uint32_t kMinGridWidth = 16;\n> /* Maximum grid width, expressed as a number of cells */\n> diff --git a/src/ipa/ipu3/meson.build b/src/ipa/ipu3/meson.build\n> index 39320980..3194111a 100644\n> --- a/src/ipa/ipu3/meson.build\n> +++ b/src/ipa/ipu3/meson.build\n> @@ -5,6 +5,7 @@ subdir('algorithms')\n> ipa_name = 'ipa_ipu3'\n> \n> ipu3_ipa_sources = files([\n> + 'ipa_context.cpp',\n> 'ipu3.cpp',\n> ])\n> \n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7D378BDC71\n\tfor ;\n\tThu, 30 Sep 2021 10:59:16 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BDF3C691AA;\n\tThu, 30 Sep 2021 12:59:15 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7461269190\n\tfor ;\n\tThu, 30 Sep 2021 12:59:14 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D5F9A2A8;\n\tThu, 30 Sep 2021 12:59:13 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Wk17t3Kj\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1632999554;\n\tbh=+Bh8suOoJOIWNZeLulqTQy50awtX/FYZl5iGoBU2PqI=;\n\th=From:Subject:To:References:Date:In-Reply-To:From;\n\tb=Wk17t3Kj5IOQ7IzunQxAxs3bAQ4ApW9WiSsKbNYY5Lwcs873ZG/OpalxrRNtyXaio\n\tKBA5JbjWHF/0qUvBim3xwbuKoyQL34unLVD36pa8H3UyH+pDBUGEr7CMJlZLek8QYw\n\tlPKfBP/Cu1AiqDfpKBP7VI3IT0tXZomAnw1X5I+w=","From":"Kieran Bingham ","To":"Jean-Michel Hautbois ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20210930095513.76213-1-jeanmichel.hautbois@ideasonboard.com>\n\t<20210930095513.76213-14-jeanmichel.hautbois@ideasonboard.com>","Message-ID":"<65267e76-54ac-9e27-ce85-5ac1eafb22e2@ideasonboard.com>","Date":"Thu, 30 Sep 2021 11:59:10 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.13.0","MIME-Version":"1.0","In-Reply-To":"<20210930095513.76213-14-jeanmichel.hautbois@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH 13/18] ipa: ipu3: Isolate ipa_context\n\tdocumentation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":20014,"web_url":"https://patchwork.libcamera.org/comment/20014/","msgid":"","date":"2021-09-30T11:29:23","subject":"Re: [libcamera-devel] [PATCH 13/18] ipa: ipu3: Isolate ipa_context\n\tdocumentation","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/people/75/","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"content":"Hi Kieran,\n\nOn 30/09/2021 12:59, Kieran Bingham wrote:\n> Hi JM,\n> \n> On 30/09/2021 10:55, Jean-Michel Hautbois wrote:\n>> From: Kieran Bingham \n>>\n>> The IPU3 IPA core is growing with additional documentation. The\n>> ipa_context documentation is stored here, but it pushes the IPU3\n>> documentation and implementation further from the head of the file.\n>>\n>> Furthermore, the ipa_context documentation is outside of the ipa::ipu3\n>> namespace and isn't identified correctly by Doxygen.\n>>\n>> Move the ipa_context to its own compilation object even though there\n>> isn't any code, but to maintain consistency with our documentation\n>> model.\n>>\n>> Correctly re-introduce the documentation into the libcamera::ipa::ipu3\n>> namespace during the move.\n>>\n>> Signed-off-by: Kieran Bingham \n>> ---\n>> src/ipa/ipu3/ipa_context.cpp | 113 +++++++++++++++++++++++++++++++++++\n>> src/ipa/ipu3/ipu3.cpp | 104 --------------------------------\n>> src/ipa/ipu3/meson.build | 1 +\n>> 3 files changed, 114 insertions(+), 104 deletions(-)\n>> create mode 100644 src/ipa/ipu3/ipa_context.cpp\n>>\n>> diff --git a/src/ipa/ipu3/ipa_context.cpp b/src/ipa/ipu3/ipa_context.cpp\n>> new file mode 100644\n>> index 00000000..40d79772\n>> --- /dev/null\n>> +++ b/src/ipa/ipu3/ipa_context.cpp\n>> @@ -0,0 +1,113 @@\n>> +/* SPDX-License-Identifier: LGPL-2.1-or-later */\n>> +/*\n>> + * Copyright (C) 2021, Google Inc.\n>> + *\n>> + * ipa_context.cpp - IPU3 IPA Context\n>> + */\n>> +\n>> +#include \"ipa_context.h\"\n>> +\n>> +namespace libcamera::ipa::ipu3 {\n>> +\n>> +/**\n>> + * \\file ipa_context.h\n>> + * \\brief Context and state information shared between the algorithms\n>> + */\n>> +\n>> +/**\n>> + * \\struct IPASessionConfiguration\n>> + * \\brief Session configuration for the IPA module\n>> + *\n>> + * The session configuration contains all IPA configuration parameters that\n>> + * remain constant during the capture session, from IPA module start to stop.\n>> + * It is typically set during the configure() operation of the IPA module, but\n>> + * may also be updated in the start() operation.\n>> + */\n>> +\n>> +/**\n>> + * \\struct IPAFrameContext\n>> + * \\brief Per-frame context for algorithms\n>> + *\n>> + * The frame context stores data specific to a single frame processed by the\n>> + * IPA. Each frame processed by the IPA has a context associated with it,\n>> + * accessible through the IPAContext structure.\n>> + *\n>> + * \\todo Detail how to access contexts for a particular frame\n>> + *\n>> + * Each of the fields in the frame context belongs to either a specific\n>> + * algorithm, or to the top-level IPA module. A field may be read by any\n>> + * algorithm, but should only be written by its owner.\n>> + */\n>> +\n>> +/**\n>> + * \\struct IPAContext\n>> + * \\brief Global IPA context data shared between all algorithms\n>> + *\n>> + * \\var IPAContext::configuration\n>> + * \\brief The IPA session configuration, immutable during the session\n>> + *\n>> + * \\var IPAContext::frameContext\n>> + * \\brief The frame context for the frame being processed\n>> + *\n>> + * \\todo While the frame context is supposed to be per-frame, this\n>> + * single frame context stores data related to both the current frame\n>> + * and the previous frames, with fields being updated as the algorithms\n>> + * are run. This needs to be turned into real per-frame data storage.\n>> + */\n>> +\n>> +/**\n>> + * \\struct IPASessionConfiguration::grid\n>> + * \\brief Grid configuration of the IPA\n>> + *\n>> + * \\var IPASessionConfiguration::grid::bdsGrid\n>> + * \\brief Bayer Down Scaler grid plane config used by the kernel\n>> + *\n>> + * \\var IPASessionConfiguration::grid::bdsOutputSize\n>> + * \\brief BDS output size configured by the pipeline handler\n>> + */\n>> +\n>> +/**\n>> + * \\struct IPAFrameContext::agc\n>> + * \\brief Context for the Automatic Gain Control algorithm\n>> + *\n>> + * The exposure and gain determined are expected to be applied to the sensor\n>> + * at the earliest opportunity.\n>> + *\n>> + * \\var IPAFrameContext::agc::exposure\n>> + * \\brief Exposure time expressed as a number of lines\n>> + *\n>> + * \\var IPAFrameContext::agc::gain\n>> + * \\brief Analogue gain multiplier\n>> + *\n>> + * The gain should be adapted to the sensor specific gain code before applying.\n>> + */\n>> +\n>> +/**\n>> + * \\struct IPAFrameContext::awb\n>> + * \\brief Context for the Automatic White Balance algorithm\n>> + *\n>> + * \\struct IPAFrameContext::awb::gains\n>> + * \\brief White balance gains\n>> + *\n>> + * \\var IPAFrameContext::awb::gains::red\n>> + * \\brief White balance gain for R channel\n>> + *\n>> + * \\var IPAFrameContext::awb::gains::green\n>> + * \\brief White balance gain for G channel\n>> + *\n>> + * \\var IPAFrameContext::awb::gains::blue\n>> + * \\brief White balance gain for B channel\n>> + */\n>> +\n>> +/**\n>> + * \\struct IPAFrameContext::toneMapping\n>> + * \\brief Context for ToneMapping and Gamma control\n>> + *\n> \n> I think this now causes\n> \n> * \\var IPAFrameContext::toneMapping::gamma\n> * \\brief Gamma value for the LUT\n> \n> to be dropped from here, and needs to be added in.\n> \n\nOh, I did not get a warning for it !!\nThanks !\n\n> \n> \n>> + * \\var IPAFrameContext::toneMapping::gammaCorrection\n>> + * \\brief Per-pixel tone mapping implemented as a LUT\n>> + *\n>> + * The LUT structure is defined by the IPU3 kernel interface. See\n>> + * struct ipu3_uapi_gamma_corr_lut for further details.\n>> + */\n>> +\n>> +} /* namespace libcamera::ipa::ipu3 */\n>> diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\n>> index 9867c993..1b1fc052 100644\n>> --- a/src/ipa/ipu3/ipu3.cpp\n>> +++ b/src/ipa/ipu3/ipu3.cpp\n>> @@ -37,110 +37,6 @@\n>> #include \"algorithms/tone_mapping.h\"\n>> #include \"libipa/camera_sensor_helper.h\"\n>> \n>> -/**\n>> - * \\file ipa_context.h\n>> - * \\brief Context and state information shared between the algorithms\n>> - */\n>> -\n>> -/**\n>> - * \\struct IPASessionConfiguration\n>> - * \\brief Session configuration for the IPA module\n>> - *\n>> - * The session configuration contains all IPA configuration parameters that\n>> - * remain constant during the capture session, from IPA module start to stop.\n>> - * It is typically set during the configure() operation of the IPA module, but\n>> - * may also be updated in the start() operation.\n>> - */\n>> -\n>> -/**\n>> - * \\struct IPAFrameContext\n>> - * \\brief Per-frame context for algorithms\n>> - *\n>> - * The frame context stores data specific to a single frame processed by the\n>> - * IPA. Each frame processed by the IPA has a context associated with it,\n>> - * accessible through the IPAContext structure.\n>> - *\n>> - * \\todo Detail how to access contexts for a particular frame\n>> - *\n>> - * Each of the fields in the frame context belongs to either a specific\n>> - * algorithm, or to the top-level IPA module. A field may be read by any\n>> - * algorithm, but should only be written by its owner.\n>> - */\n>> -\n>> -/**\n>> - * \\struct IPAContext\n>> - * \\brief Global IPA context data shared between all algorithms\n>> - *\n>> - * \\var IPAContext::configuration\n>> - * \\brief The IPA session configuration, immutable during the session\n>> - *\n>> - * \\var IPAContext::frameContext\n>> - * \\brief The frame context for the frame being processed\n>> - *\n>> - * \\todo While the frame context is supposed to be per-frame, this\n>> - * single frame context stores data related to both the current frame\n>> - * and the previous frames, with fields being updated as the algorithms\n>> - * are run. This needs to be turned into real per-frame data storage.\n>> - */\n>> -\n>> -/**\n>> - * \\struct IPASessionConfiguration::grid\n>> - * \\brief Grid configuration of the IPA\n>> - *\n>> - * \\var IPASessionConfiguration::grid::bdsGrid\n>> - * \\brief Bayer Down Scaler grid plane config used by the kernel\n>> - *\n>> - * \\var IPASessionConfiguration::grid::bdsOutputSize\n>> - * \\brief BDS output size configured by the pipeline handler\n>> - */\n>> -\n>> -/**\n>> - * \\struct IPAFrameContext::agc\n>> - * \\brief Context for the Automatic Gain Control algorithm\n>> - *\n>> - * The exposure and gain determined are expected to be applied to the sensor\n>> - * at the earliest opportunity.\n>> - *\n>> - * \\var IPAFrameContext::agc::exposure\n>> - * \\brief Exposure time expressed as a number of lines\n>> - *\n>> - * \\var IPAFrameContext::agc::gain\n>> - * \\brief Analogue gain multiplier\n>> - *\n>> - * The gain should be adapted to the sensor specific gain code before applying.\n>> - */\n>> -\n>> -/**\n>> - * \\struct IPAFrameContext::awb\n>> - * \\brief Context for the Automatic White Balance algorithm\n>> - *\n>> - * \\struct IPAFrameContext::awb::gains\n>> - * \\brief White balance gains\n>> - *\n>> - * \\var IPAFrameContext::awb::gains::red\n>> - * \\brief White balance gain for R channel\n>> - *\n>> - * \\var IPAFrameContext::awb::gains::green\n>> - * \\brief White balance gain for G channel\n>> - *\n>> - * \\var IPAFrameContext::awb::gains::blue\n>> - * \\brief White balance gain for B channel\n>> - */\n>> -\n>> -/**\n>> - * \\struct IPAFrameContext::toneMapping\n>> - * \\brief Context for ToneMapping and Gamma control\n>> - *\n>> - * \\var IPAFrameContext::toneMapping::gamma\n>> - * \\brief Gamma value for the LUT\n>> - *\n>> - * \\var IPAFrameContext::toneMapping::gammaCorrection\n>> - * \\brief Per-pixel tone mapping implemented as a LUT\n>> - *\n>> - * The LUT structure is defined by the IPU3 kernel interface. See\n>> - * struct ipu3_uapi_gamma_corr_lut for further details.\n>> - */\n>> -\n>> /* Minimum grid width, expressed as a number of cells */\n>> static constexpr uint32_t kMinGridWidth = 16;\n>> /* Maximum grid width, expressed as a number of cells */\n>> diff --git a/src/ipa/ipu3/meson.build b/src/ipa/ipu3/meson.build\n>> index 39320980..3194111a 100644\n>> --- a/src/ipa/ipu3/meson.build\n>> +++ b/src/ipa/ipu3/meson.build\n>> @@ -5,6 +5,7 @@ subdir('algorithms')\n>> ipa_name = 'ipa_ipu3'\n>> \n>> ipu3_ipa_sources = files([\n>> + 'ipa_context.cpp',\n>> 'ipu3.cpp',\n>> ])\n>> \n>>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 702BEC3243\n\tfor ;\n\tThu, 30 Sep 2021 11:29:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AEEA8691AA;\n\tThu, 30 Sep 2021 13:29:26 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 79AD769190\n\tfor ;\n\tThu, 30 Sep 2021 13:29:25 +0200 (CEST)","from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:bab4:22c5:662d:e478])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 06F6E2A8;\n\tThu, 30 Sep 2021 13:29:25 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"mCnCEf9/\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1633001365;\n\tbh=xLB0PdRpHP816navDgm9+MRisvZoj5whm4rkWBuGUR4=;\n\th=Subject:To:References:From:Date:In-Reply-To:From;\n\tb=mCnCEf9/jlS/AySgR3jbir+22TP4YtpkgVavvzmP9Vu/o5jru7nDsklQISLXSN1YS\n\ttpyb8sgCmW6BjCnrdbh3URRcgjyod/Lj/3bHQMKdH/b9Jdi31V6Q/SuZiR52IQwa1K\n\tuW0kYvjvEUzxqqRDcbjXwPz0BSnbJXJtDjy7Z9x8=","To":"Kieran Bingham ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20210930095513.76213-1-jeanmichel.hautbois@ideasonboard.com>\n\t<20210930095513.76213-14-jeanmichel.hautbois@ideasonboard.com>\n\t<65267e76-54ac-9e27-ce85-5ac1eafb22e2@ideasonboard.com>","From":"Jean-Michel Hautbois ","Message-ID":"","Date":"Thu, 30 Sep 2021 13:29:23 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.13.0","MIME-Version":"1.0","In-Reply-To":"<65267e76-54ac-9e27-ce85-5ac1eafb22e2@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH 13/18] ipa: ipu3: Isolate ipa_context\n\tdocumentation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]