[{"id":20040,"web_url":"https://patchwork.libcamera.org/comment/20040/","msgid":"","date":"2021-10-05T01:06:50","subject":"Re: [libcamera-devel] [PATCH v2 08/12] ipa: ipu3: awb: Correct the\n\tgain multipliers","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jean-Michel,\n\nThank you for the patch.\n\nOn Thu, Sep 30, 2021 at 11:37:11AM +0200, Jean-Michel Hautbois wrote:\n> The gains have a precision u3.13, range [0, 8[ which means that a gain\n> multiplier value of 1.0 is represented as a multiplication by 8192 in\n> the ImgU. Correct the gains as this was misunderstood in the first\n> place.\n> \n> Signed-off-by: Jean-Michel Hautbois \n> Reviewed-by: Kieran Bingham \n> Reviewed-by: Laurent Pinchart \n> ---\n> src/ipa/ipu3/algorithms/awb.cpp | 15 ++++++---------\n> 1 file changed, 6 insertions(+), 9 deletions(-)\n> \n> diff --git a/src/ipa/ipu3/algorithms/awb.cpp b/src/ipa/ipu3/algorithms/awb.cpp\n> index be764c79..c1ff9450 100644\n> --- a/src/ipa/ipu3/algorithms/awb.cpp\n> +++ b/src/ipa/ipu3/algorithms/awb.cpp\n> @@ -313,6 +313,7 @@ void Awb::awbGreyWorld()\n> \t/* Color temperature is not relevant in Grey world but still useful to estimate it :-) */\n> \tasyncResults_.temperatureK = estimateCCT(sumRed.R, sumRed.G, sumBlue.B);\n> \tasyncResults_.redGain = redGain;\n> +\t/*Hardcode the green gain to 1.0. */\n\nMissing space before Hardcode.\n\n> \tasyncResults_.greenGain = 1.0;\n> \tasyncResults_.blueGain = blueGain;\n> }\n> @@ -376,15 +377,11 @@ void Awb::prepare(IPAContext &context, ipu3_uapi_params *params)\n> \t\t\t\t\t\t\t* params->acc_param.bnr.opt_center.x_reset;\n> \tparams->acc_param.bnr.opt_center_sqr.y_sqr_reset = params->acc_param.bnr.opt_center.y_reset\n> \t\t\t\t\t\t\t* params->acc_param.bnr.opt_center.y_reset;\n> -\t/*\n> -\t * Green gains should not be touched and considered 1.\n> -\t * Default is 16, so do not change it at all.\n> -\t * 4096 is the value for a gain of 1.0\n> -\t */\n> -\tparams->acc_param.bnr.wb_gains.gr = 16 * context.frameContext.awb.gains.green;\n> -\tparams->acc_param.bnr.wb_gains.r = 4096 * context.frameContext.awb.gains.red;\n> -\tparams->acc_param.bnr.wb_gains.b = 4096 * context.frameContext.awb.gains.blue;\n> -\tparams->acc_param.bnr.wb_gains.gb = 16 * context.frameContext.awb.gains.green;\n> +\t/* Convert to u3.13 fixed point values */\n> +\tparams->acc_param.bnr.wb_gains.gr = 8192 * context.frameContext.awb.gains.green;\n> +\tparams->acc_param.bnr.wb_gains.r = 8192 * context.frameContext.awb.gains.red;\n> +\tparams->acc_param.bnr.wb_gains.b = 8192 * context.frameContext.awb.gains.blue;\n> +\tparams->acc_param.bnr.wb_gains.gb = 8192 * context.frameContext.awb.gains.green;\n> \n> \tLOG(IPU3Awb, Debug) << \"Color temperature estimated: \" << asyncResults_.temperatureK;\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E0CF6BDC71\n\tfor ;\n\tTue, 5 Oct 2021 01:06:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 58F746918F;\n\tTue, 5 Oct 2021 03:06:59 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CC03069189\n\tfor ;\n\tTue, 5 Oct 2021 03:06:57 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 312AC25B;\n\tTue, 5 Oct 2021 03:06:57 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"WRETiOJK\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1633396017;\n\tbh=HeEQ4V1BzCcjM034mRF6epnvYisTWgD8Q8G/ri6tNcs=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=WRETiOJKTg8DS2Ds6Jv0ezeXY4Dv7/F8ZBs4OQrOLo/GLZri8NJn+v/Ac1H26ubZY\n\tv4acbPwg3eF5dnkBnw9uEwJkmgsdXuG16tJjcTVUhlOdVmic2Bs1T0GcAt1OhN66TX\n\tnI8YWKT9EEJ8Z+eCg7TP1OMDL43EQ0NB+nG4B/1Y=","Date":"Tue, 5 Oct 2021 04:06:50 +0300","From":"Laurent Pinchart ","To":"Jean-Michel Hautbois ","Message-ID":"","References":"<20210930093715.73293-1-jeanmichel.hautbois@ideasonboard.com>\n\t<20210930093715.73293-9-jeanmichel.hautbois@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210930093715.73293-9-jeanmichel.hautbois@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 08/12] ipa: ipu3: awb: Correct the\n\tgain multipliers","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]