[{"id":20002,"web_url":"https://patchwork.libcamera.org/comment/20002/","msgid":"","date":"2021-09-29T14:27:16","subject":"Re: [libcamera-devel] [PATCH v4 3/4] android: camera_device: Mark\n\tabortRequest() and notifyError() as const","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Umang,\n\nThank you for the patch.\n\nOn Wed, Sep 29, 2021 at 07:00:29PM +0530, Umang Jain wrote:\n> abortRequest() and notifyError() do not access any members of\n> CameraDevice hence, these functions can be const.\n\nThey both access callbacks_.\n\n> Signed-off-by: Umang Jain \n> ---\n> src/android/camera_device.cpp | 4 ++--\n> src/android/camera_device.h | 4 ++--\n> 2 files changed, 4 insertions(+), 4 deletions(-)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index e815f7a0..45350563 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -860,7 +860,7 @@ int CameraDevice::processControls(Camera3RequestDescriptor *descriptor)\n> \treturn 0;\n> }\n> \n> -void CameraDevice::abortRequest(camera3_capture_request_t *request)\n> +void CameraDevice::abortRequest(camera3_capture_request_t *request) const\n> {\n> \tnotifyError(request->frame_number, nullptr, CAMERA3_MSG_ERROR_REQUEST);\n> \n> @@ -1258,7 +1258,7 @@ void CameraDevice::notifyShutter(uint32_t frameNumber, uint64_t timestamp)\n> }\n> \n> void CameraDevice::notifyError(uint32_t frameNumber, camera3_stream_t *stream,\n> -\t\t\t camera3_error_msg_code code)\n> +\t\t\t camera3_error_msg_code code) const\n> {\n> \tcamera3_notify_msg_t notify = {};\n> \n> diff --git a/src/android/camera_device.h b/src/android/camera_device.h\n> index 9ec510d5..85497921 100644\n> --- a/src/android/camera_device.h\n> +++ b/src/android/camera_device.h\n> @@ -99,11 +99,11 @@ private:\n> \tcreateFrameBuffer(const buffer_handle_t camera3buffer,\n> \t\t\t libcamera::PixelFormat pixelFormat,\n> \t\t\t const libcamera::Size &size);\n> -\tvoid abortRequest(camera3_capture_request_t *request);\n> +\tvoid abortRequest(camera3_capture_request_t *request) const;\n> \tbool isValidRequest(camera3_capture_request_t *request) const;\n> \tvoid notifyShutter(uint32_t frameNumber, uint64_t timestamp);\n> \tvoid notifyError(uint32_t frameNumber, camera3_stream_t *stream,\n> -\t\t\t camera3_error_msg_code code);\n> +\t\t\t camera3_error_msg_code code) const;\n> \tint processControls(Camera3RequestDescriptor *descriptor);\n> \tstd::unique_ptr getResultMetadata(\n> \t\tconst Camera3RequestDescriptor &descriptor) const;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 43628C3243\n\tfor ;\n\tWed, 29 Sep 2021 14:27:21 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A84AE691AA;\n\tWed, 29 Sep 2021 16:27:20 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3167D69185\n\tfor ;\n\tWed, 29 Sep 2021 16:27:19 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 99A833F0;\n\tWed, 29 Sep 2021 16:27:18 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Mrtq4tEj\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1632925638;\n\tbh=q89TyXByxebpVXcesIgx/8NSPQffpUEjmGqre+MHvPY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Mrtq4tEjTF2nwmcoo66GVPgj0ALmDlCLCWfWf6Gcla6x+FQ+OsoKOO2Qe43djISUO\n\tOaRwDi3dMF5HJyY+ET6R2jU+KG2c+ZxeThQ51RPM/plcLQPChFADWIVzyFyrltUBoz\n\t8nO93ugLE6Wt6aq6kJMK5JXxkx5iR+bNhmyehPP8=","Date":"Wed, 29 Sep 2021 17:27:16 +0300","From":"Laurent Pinchart ","To":"Umang Jain ","Message-ID":"","References":"<20210929133030.401961-1-umang.jain@ideasonboard.com>\n\t<20210929133030.401961-4-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210929133030.401961-4-umang.jain@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v4 3/4] android: camera_device: Mark\n\tabortRequest() and notifyError() as const","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":20005,"web_url":"https://patchwork.libcamera.org/comment/20005/","msgid":"<171ffdb8-3c87-3d1a-15b6-82b6b2371770@ideasonboard.com>","date":"2021-09-29T17:41:38","subject":"Re: [libcamera-devel] [PATCH v4 3/4] android: camera_device: Mark\n\tabortRequest() and notifyError() as const","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 9/29/21 7:57 PM, Laurent Pinchart wrote:\n> Hi Umang,\n>\n> Thank you for the patch.\n>\n> On Wed, Sep 29, 2021 at 07:00:29PM +0530, Umang Jain wrote:\n>> abortRequest() and notifyError() do not access any members of\n>> CameraDevice hence, these functions can be const.\n> They both access callbacks_.\n\n\nOops,\n\nThe commit message should be updated to:\n\n     abortRequest() and notifyError do not modify any members of \nCameraDevice,\n     hence, these functions can be const.\n\n\n>\n>> Signed-off-by: Umang Jain \n>> ---\n>> src/android/camera_device.cpp | 4 ++--\n>> src/android/camera_device.h | 4 ++--\n>> 2 files changed, 4 insertions(+), 4 deletions(-)\n>>\n>> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n>> index e815f7a0..45350563 100644\n>> --- a/src/android/camera_device.cpp\n>> +++ b/src/android/camera_device.cpp\n>> @@ -860,7 +860,7 @@ int CameraDevice::processControls(Camera3RequestDescriptor *descriptor)\n>> \treturn 0;\n>> }\n>> \n>> -void CameraDevice::abortRequest(camera3_capture_request_t *request)\n>> +void CameraDevice::abortRequest(camera3_capture_request_t *request) const\n>> {\n>> \tnotifyError(request->frame_number, nullptr, CAMERA3_MSG_ERROR_REQUEST);\n>> \n>> @@ -1258,7 +1258,7 @@ void CameraDevice::notifyShutter(uint32_t frameNumber, uint64_t timestamp)\n>> }\n>> \n>> void CameraDevice::notifyError(uint32_t frameNumber, camera3_stream_t *stream,\n>> -\t\t\t camera3_error_msg_code code)\n>> +\t\t\t camera3_error_msg_code code) const\n>> {\n>> \tcamera3_notify_msg_t notify = {};\n>> \n>> diff --git a/src/android/camera_device.h b/src/android/camera_device.h\n>> index 9ec510d5..85497921 100644\n>> --- a/src/android/camera_device.h\n>> +++ b/src/android/camera_device.h\n>> @@ -99,11 +99,11 @@ private:\n>> \tcreateFrameBuffer(const buffer_handle_t camera3buffer,\n>> \t\t\t libcamera::PixelFormat pixelFormat,\n>> \t\t\t const libcamera::Size &size);\n>> -\tvoid abortRequest(camera3_capture_request_t *request);\n>> +\tvoid abortRequest(camera3_capture_request_t *request) const;\n>> \tbool isValidRequest(camera3_capture_request_t *request) const;\n>> \tvoid notifyShutter(uint32_t frameNumber, uint64_t timestamp);\n>> \tvoid notifyError(uint32_t frameNumber, camera3_stream_t *stream,\n>> -\t\t\t camera3_error_msg_code code);\n>> +\t\t\t camera3_error_msg_code code) const;\n>> \tint processControls(Camera3RequestDescriptor *descriptor);\n>> \tstd::unique_ptr getResultMetadata(\n>> \t\tconst Camera3RequestDescriptor &descriptor) const;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 76FF6BDC71\n\tfor ;\n\tWed, 29 Sep 2021 17:41:44 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A0E43691AB;\n\tWed, 29 Sep 2021 19:41:43 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 493BE69185\n\tfor ;\n\tWed, 29 Sep 2021 19:41:42 +0200 (CEST)","from [192.168.1.104] (unknown [103.251.226.9])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6AFB63F0;\n\tWed, 29 Sep 2021 19:41:41 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"v/oWa87g\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1632937301;\n\tbh=hEO3LBguBpCvppf4R/A3cO5g/yUs+1yTq2xSAOO/W18=;\n\th=Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=v/oWa87g5STLEJLt31IhxV6KrIjeEAIXVyl2QIRw5Tv7N1IRfcoo7hxCeRNHdUdab\n\tNb5kcyd+Jr40VXvKfNI5UzJ3PZyA0I0pvQWkeytLZ9tXVaRrjk14LiqL3DfDDl7R2v\n\t89dDC2OPnMiA4xpPcb2WbW8PwumrzBdBvW865VJQ=","To":"Laurent Pinchart ","References":"<20210929133030.401961-1-umang.jain@ideasonboard.com>\n\t<20210929133030.401961-4-umang.jain@ideasonboard.com>\n\t","From":"Umang Jain ","Message-ID":"<171ffdb8-3c87-3d1a-15b6-82b6b2371770@ideasonboard.com>","Date":"Wed, 29 Sep 2021 23:11:38 +0530","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.10.2","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"8bit","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH v4 3/4] android: camera_device: Mark\n\tabortRequest() and notifyError() as const","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":20006,"web_url":"https://patchwork.libcamera.org/comment/20006/","msgid":"","date":"2021-09-29T17:46:46","subject":"Re: [libcamera-devel] [PATCH v4 3/4] android: camera_device: Mark\n\tabortRequest() and notifyError() as const","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Wed, Sep 29, 2021 at 11:11:38PM +0530, Umang Jain wrote:\n> Hi Laurent,\n> \n> On 9/29/21 7:57 PM, Laurent Pinchart wrote:\n> > Hi Umang,\n> >\n> > Thank you for the patch.\n> >\n> > On Wed, Sep 29, 2021 at 07:00:29PM +0530, Umang Jain wrote:\n> >> abortRequest() and notifyError() do not access any members of\n> >> CameraDevice hence, these functions can be const.\n> > They both access callbacks_.\n> \n> \n> Oops,\n> \n> The commit message should be updated to:\n> \n>     abortRequest() and notifyError do not modify any members of \n> CameraDevice,\n>     hence, these functions can be const.\n\nReviewed-by: Laurent Pinchart \n\n> >> Signed-off-by: Umang Jain \n> >> ---\n> >> src/android/camera_device.cpp | 4 ++--\n> >> src/android/camera_device.h | 4 ++--\n> >> 2 files changed, 4 insertions(+), 4 deletions(-)\n> >>\n> >> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> >> index e815f7a0..45350563 100644\n> >> --- a/src/android/camera_device.cpp\n> >> +++ b/src/android/camera_device.cpp\n> >> @@ -860,7 +860,7 @@ int CameraDevice::processControls(Camera3RequestDescriptor *descriptor)\n> >> \treturn 0;\n> >> }\n> >> \n> >> -void CameraDevice::abortRequest(camera3_capture_request_t *request)\n> >> +void CameraDevice::abortRequest(camera3_capture_request_t *request) const\n> >> {\n> >> \tnotifyError(request->frame_number, nullptr, CAMERA3_MSG_ERROR_REQUEST);\n> >> \n> >> @@ -1258,7 +1258,7 @@ void CameraDevice::notifyShutter(uint32_t frameNumber, uint64_t timestamp)\n> >> }\n> >> \n> >> void CameraDevice::notifyError(uint32_t frameNumber, camera3_stream_t *stream,\n> >> -\t\t\t camera3_error_msg_code code)\n> >> +\t\t\t camera3_error_msg_code code) const\n> >> {\n> >> \tcamera3_notify_msg_t notify = {};\n> >> \n> >> diff --git a/src/android/camera_device.h b/src/android/camera_device.h\n> >> index 9ec510d5..85497921 100644\n> >> --- a/src/android/camera_device.h\n> >> +++ b/src/android/camera_device.h\n> >> @@ -99,11 +99,11 @@ private:\n> >> \tcreateFrameBuffer(const buffer_handle_t camera3buffer,\n> >> \t\t\t libcamera::PixelFormat pixelFormat,\n> >> \t\t\t const libcamera::Size &size);\n> >> -\tvoid abortRequest(camera3_capture_request_t *request);\n> >> +\tvoid abortRequest(camera3_capture_request_t *request) const;\n> >> \tbool isValidRequest(camera3_capture_request_t *request) const;\n> >> \tvoid notifyShutter(uint32_t frameNumber, uint64_t timestamp);\n> >> \tvoid notifyError(uint32_t frameNumber, camera3_stream_t *stream,\n> >> -\t\t\t camera3_error_msg_code code);\n> >> +\t\t\t camera3_error_msg_code code) const;\n> >> \tint processControls(Camera3RequestDescriptor *descriptor);\n> >> \tstd::unique_ptr getResultMetadata(\n> >> \t\tconst Camera3RequestDescriptor &descriptor) const;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8694AC3243\n\tfor ;\n\tWed, 29 Sep 2021 17:46:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C52CA691AA;\n\tWed, 29 Sep 2021 19:46:50 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0B7FA69185\n\tfor ;\n\tWed, 29 Sep 2021 19:46:49 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 700613F0;\n\tWed, 29 Sep 2021 19:46:48 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"rLhhtUdw\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1632937608;\n\tbh=oCoJH+skPPxA3QpN6CVq0JqaGb+rsBgngnO8R4bOvuY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=rLhhtUdwrTk+zwhMqt8/w0rVExVyHVS9oNbgLZsd58w4usk10hFxdI7AVElFrmQN4\n\tRqYeQJEHEom5Sj6uIrT7KLvdJN9v33A7g46pbBICIpkKx2hahcyyiV9jhMJCWfquIB\n\tpOFt8oPygR4ieo/ZN76I7kPcAKg208uyxgKLFY64=","Date":"Wed, 29 Sep 2021 20:46:46 +0300","From":"Laurent Pinchart ","To":"Umang Jain ","Message-ID":"","References":"<20210929133030.401961-1-umang.jain@ideasonboard.com>\n\t<20210929133030.401961-4-umang.jain@ideasonboard.com>\n\t\n\t<171ffdb8-3c87-3d1a-15b6-82b6b2371770@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<171ffdb8-3c87-3d1a-15b6-82b6b2371770@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v4 3/4] android: camera_device: Mark\n\tabortRequest() and notifyError() as const","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":20008,"web_url":"https://patchwork.libcamera.org/comment/20008/","msgid":"<20210929184140.hjm54mo5ur5kpptw@uno.localdomain>","date":"2021-09-29T18:41:40","subject":"Re: [libcamera-devel] [PATCH v4 3/4] android: camera_device: Mark\n\tabortRequest() and notifyError() as const","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Umang,\n\nOn Wed, Sep 29, 2021 at 07:00:29PM +0530, Umang Jain wrote:\n> abortRequest() and notifyError() do not access any members of\n> CameraDevice hence, these functions can be const.\n\nI know it's -techincally- correct, but I find it confusing to a\nfunction that sets the state of the descriptor at hand as const :)\n\nAnyway, I'll go with the majority\n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n>\n> Signed-off-by: Umang Jain \n> ---\n> src/android/camera_device.cpp | 4 ++--\n> src/android/camera_device.h | 4 ++--\n> 2 files changed, 4 insertions(+), 4 deletions(-)\n>\n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index e815f7a0..45350563 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -860,7 +860,7 @@ int CameraDevice::processControls(Camera3RequestDescriptor *descriptor)\n> \treturn 0;\n> }\n>\n> -void CameraDevice::abortRequest(camera3_capture_request_t *request)\n> +void CameraDevice::abortRequest(camera3_capture_request_t *request) const\n> {\n> \tnotifyError(request->frame_number, nullptr, CAMERA3_MSG_ERROR_REQUEST);\n>\n> @@ -1258,7 +1258,7 @@ void CameraDevice::notifyShutter(uint32_t frameNumber, uint64_t timestamp)\n> }\n>\n> void CameraDevice::notifyError(uint32_t frameNumber, camera3_stream_t *stream,\n> -\t\t\t camera3_error_msg_code code)\n> +\t\t\t camera3_error_msg_code code) const\n> {\n> \tcamera3_notify_msg_t notify = {};\n>\n> diff --git a/src/android/camera_device.h b/src/android/camera_device.h\n> index 9ec510d5..85497921 100644\n> --- a/src/android/camera_device.h\n> +++ b/src/android/camera_device.h\n> @@ -99,11 +99,11 @@ private:\n> \tcreateFrameBuffer(const buffer_handle_t camera3buffer,\n> \t\t\t libcamera::PixelFormat pixelFormat,\n> \t\t\t const libcamera::Size &size);\n> -\tvoid abortRequest(camera3_capture_request_t *request);\n> +\tvoid abortRequest(camera3_capture_request_t *request) const;\n> \tbool isValidRequest(camera3_capture_request_t *request) const;\n> \tvoid notifyShutter(uint32_t frameNumber, uint64_t timestamp);\n> \tvoid notifyError(uint32_t frameNumber, camera3_stream_t *stream,\n> -\t\t\t camera3_error_msg_code code);\n> +\t\t\t camera3_error_msg_code code) const;\n> \tint processControls(Camera3RequestDescriptor *descriptor);\n> \tstd::unique_ptr getResultMetadata(\n> \t\tconst Camera3RequestDescriptor &descriptor) const;\n> --\n> 2.31.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 51A2AC3243\n\tfor ;\n\tWed, 29 Sep 2021 18:40:55 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1F72A691AA;\n\tWed, 29 Sep 2021 20:40:55 +0200 (CEST)","from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net\n\t[217.70.183.194])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 514B869185\n\tfor ;\n\tWed, 29 Sep 2021 20:40:54 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby relay2-d.mail.gandi.net (Postfix) with ESMTPSA id E080240003;\n\tWed, 29 Sep 2021 18:40:53 +0000 (UTC)"],"Date":"Wed, 29 Sep 2021 20:41:40 +0200","From":"Jacopo Mondi ","To":"Umang Jain ","Message-ID":"<20210929184140.hjm54mo5ur5kpptw@uno.localdomain>","References":"<20210929133030.401961-1-umang.jain@ideasonboard.com>\n\t<20210929133030.401961-4-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210929133030.401961-4-umang.jain@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v4 3/4] android: camera_device: Mark\n\tabortRequest() and notifyError() as const","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]