[{"id":19952,"web_url":"https://patchwork.libcamera.org/comment/19952/","msgid":"","date":"2021-09-28T23:10:19","subject":"Re: [libcamera-devel] [PATCH v2 1/3] android: camera_worker: Use\n\tCamera3RequestDescriptor as cookie","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"content":"Hi Umang, thank you for the patch.\n\nOn Wed, Sep 29, 2021 at 1:25 AM Umang Jain wrote:\n>\n> Use Camera3RequestDescriptor as cookie for the Capture Request.\n> The cookie is used to lookup descriptors map in\n> CameraDevice::requestComplete(). The map will be transformed to a\n> queue in subsequent commit.\n>\n> Signed-off-by: Umang Jain \n> Reviewed-by: Laurent Pinchart \n\nReviewed-by: Hirokazu Honda \n\n> ---\n> src/android/camera_device.cpp | 3 ++-\n> src/android/camera_worker.cpp | 4 ++--\n> src/android/camera_worker.h | 3 ++-\n> 3 files changed, 6 insertions(+), 4 deletions(-)\n>\n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index 0fe11fe8..9287ea07 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -244,7 +244,8 @@ CameraDevice::Camera3RequestDescriptor::Camera3RequestDescriptor(\n> * Create the CaptureRequest, stored as a unique_ptr<> to tie its\n> * lifetime to the descriptor.\n> */\n> - request_ = std::make_unique(camera);\n> + request_ = std::make_unique(camera,\n> + reinterpret_cast(this));\n> }\n>\n> /*\n> diff --git a/src/android/camera_worker.cpp b/src/android/camera_worker.cpp\n> index 91313183..dabb3054 100644\n> --- a/src/android/camera_worker.cpp\n> +++ b/src/android/camera_worker.cpp\n> @@ -27,10 +27,10 @@ LOG_DECLARE_CATEGORY(HAL)\n> * by the CameraWorker which queues it to the libcamera::Camera after handling\n> * fences.\n> */\n> -CaptureRequest::CaptureRequest(Camera *camera)\n> +CaptureRequest::CaptureRequest(Camera *camera, uint64_t cookie)\n> : camera_(camera)\n> {\n> - request_ = camera_->createRequest(reinterpret_cast(this));\n> + request_ = camera_->createRequest(cookie);\n> }\n>\n> void CaptureRequest::addBuffer(Stream *stream, FrameBuffer *buffer, int fence)\n> diff --git a/src/android/camera_worker.h b/src/android/camera_worker.h\n> index 67ae50bd..c94f1632 100644\n> --- a/src/android/camera_worker.h\n> +++ b/src/android/camera_worker.h\n> @@ -8,6 +8,7 @@\n> #define __ANDROID_CAMERA_WORKER_H__\n>\n> #include \n> +#include \n>\n> #include \n> #include \n> @@ -22,7 +23,7 @@ class CameraDevice;\n> class CaptureRequest\n> {\n> public:\n> - CaptureRequest(libcamera::Camera *camera);\n> + CaptureRequest(libcamera::Camera *camera, uint64_t cookie);\n>\n> const std::vector &fences() const { return acquireFences_; }\n> libcamera::ControlList &controls() { return request_->controls(); }\n> --\n> 2.31.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 97B6ABDC71\n\tfor ;\n\tTue, 28 Sep 2021 23:10:33 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C6FA269191;\n\tWed, 29 Sep 2021 01:10:32 +0200 (CEST)","from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com\n\t[IPv6:2a00:1450:4864:20::52b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CB86E6012C\n\tfor ;\n\tWed, 29 Sep 2021 01:10:30 +0200 (CEST)","by mail-ed1-x52b.google.com with SMTP id r18so1144391edv.12\n\tfor ;\n\tTue, 28 Sep 2021 16:10:30 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"UE0AlLfW\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=zPBOB5BEaYy1OiVvu3KVOyOaGfcSpMS8CEx+8n2EM3Y=;\n\tb=UE0AlLfWVHDirp17nnODh/d0CT3H1WQ6Y4Rq4dtha/bFUTfLTrFUm5CRVqkBTmNeTC\n\t4aQXWbVW8rzDvDLNrrPq2tO+6+bjCSRYjSqbXF7pGtBY5uq9eL9q6uDqT6ohUnwwNwqp\n\ttTTX6Q0tVMIEbc7v35csN0tDFxCNX1lPhVf5s=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=zPBOB5BEaYy1OiVvu3KVOyOaGfcSpMS8CEx+8n2EM3Y=;\n\tb=OqeueLPlZOwjLii0osaCbrYvGk2e/rh+1dSh6W+qPoI2WLFoAjXuTFiJqMoa5NYET9\n\tGHPGlPxPR8/kilLuzpc5ZXXFg1QIcgtJqjpLoYkUybjhzyxh37LlnHhTdL6Ca5lyWZ1B\n\tjnqEUwyQ0M9kQiHNCwP9vQdOV2RcY507G4gcJ6JPWceVVKchpFr2sFnSUHzn/Oy1a5Xu\n\tk/qNxeABlJPugYmsEMq3h15YKbU8xMc7gdbp66KcetswHe3e7RVom717idYF+DR8rwOL\n\t+AqLbyJqjP9+D10KfqfSAAoMOQnKVQjeXaBlGVk5L/TRllZZln0nvvYlrPnVtTKj2eV8\n\tSGsw==","X-Gm-Message-State":"AOAM533rAelYfph8ZL0p7gpBw8gWOhd+s3gBVpTncoyzozVw7+wQU4J+\n\trcdSYuInELzFcAgF675fCWarlPi16lj+BB37yF5Fb7Pkr6o=","X-Google-Smtp-Source":"ABdhPJxs8QbpyjZz7h3AMCHAkwVHsWgSU///AohHaKFfNKDqK0z1T0pfsytK/v0h33chvgoqdqk/6Fk4LBnPXAuHwhY=","X-Received":"by 2002:a50:d80d:: with SMTP id\n\to13mr11112518edj.204.1632870630320; \n\tTue, 28 Sep 2021 16:10:30 -0700 (PDT)","MIME-Version":"1.0","References":"<20210928162536.227475-1-umang.jain@ideasonboard.com>\n\t<20210928162536.227475-2-umang.jain@ideasonboard.com>","In-Reply-To":"<20210928162536.227475-2-umang.jain@ideasonboard.com>","From":"Hirokazu Honda ","Date":"Wed, 29 Sep 2021 08:10:19 +0900","Message-ID":"","To":"Umang Jain ","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH v2 1/3] android: camera_worker: Use\n\tCamera3RequestDescriptor as cookie","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]