[{"id":19920,"web_url":"https://patchwork.libcamera.org/comment/19920/","msgid":"<41dd5a7d-a7a2-846f-9bdf-04b165b7f1b5@ideasonboard.com>","date":"2021-09-28T10:32:39","subject":"Re: [libcamera-devel] [IPU3-IPA PATCH] ipu3: Use new sensor controls","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/people/75/","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"content":"Hi Kieran,\n\nOn 28/09/2021 12:10, Kieran Bingham wrote:\n> The IPU3 interface was updated in 4c1fc33d8ab9 (\"libcamera: ipu3: Drop\n> entityControls map\") where the sensor controls are given their own\n> dedicated control list and is named accordingly.\n> \n> Update the IPU3 IPA to match the new interface update.\n> \n> Signed-off-by: Kieran Bingham \nReviewed-by: Jean-Michel Hautbois \n\n> ---\n> ipu3.cpp | 6 +++---\n> 1 file changed, 3 insertions(+), 3 deletions(-)\n> \n> diff --git a/ipu3.cpp b/ipu3.cpp\n> index 3e89e6dd4e02..b60c58c990af 100644\n> --- a/ipu3.cpp\n> +++ b/ipu3.cpp\n> @@ -201,14 +201,14 @@ int IPAIPU3::start()\n> \n> int IPAIPU3::configure(const IPAConfigInfo &configInfo)\n> {\n> -\tif (configInfo.entityControls.empty()) {\n> -\t\tLOG(IPAIPU3, Error) << \"No controls provided\";\n> +\tif (configInfo.sensorControls.empty()) {\n> +\t\tLOG(IPAIPU3, Error) << \"No sensor controls provided\";\n> \t\treturn -ENODATA;\n> \t}\n> \n> \tsensorInfo_ = configInfo.sensorInfo;\n> \n> -\tctrls_ = configInfo.entityControls.at(0);\n> +\tctrls_ = configInfo.sensorControls;\n> \n> \tconst auto itExp = ctrls_.find(V4L2_CID_EXPOSURE);\n> \tif (itExp == ctrls_.end()) {\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E8385BDC71\n\tfor ;\n\tTue, 28 Sep 2021 10:32:44 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 260346918C;\n\tTue, 28 Sep 2021 12:32:44 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 05DBA69185\n\tfor ;\n\tTue, 28 Sep 2021 12:32:42 +0200 (CEST)","from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:49db:1c4b:4bb:6f1f])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A1E2E3F1;\n\tTue, 28 Sep 2021 12:32:41 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ksJKQI+a\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1632825161;\n\tbh=sCeQR8X2BN2E01CO7ns3FfJSVN8uLu8ixmUKluXWumA=;\n\th=Subject:To:References:From:Date:In-Reply-To:From;\n\tb=ksJKQI+aPogeY83CBFDh/AnaHiZfNORcL26ii6gymDOSywtUp9dTD0riGJR7WMPx/\n\tkIQJnWLjrR3kvVDauKd/gqALQ0er7zppeNf331+TSG/TXRNiQldPN3NWOum4Rx/IPX\n\tkWtYnLjdi0VRCRSCI36IAaY5Pj5de6DdJdTWaX8s=","To":"Kieran Bingham ,\n\tlibcamera devel ","References":"<20210928101007.452727-1-kieran.bingham@ideasonboard.com>","From":"Jean-Michel Hautbois ","Message-ID":"<41dd5a7d-a7a2-846f-9bdf-04b165b7f1b5@ideasonboard.com>","Date":"Tue, 28 Sep 2021 12:32:39 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.13.0","MIME-Version":"1.0","In-Reply-To":"<20210928101007.452727-1-kieran.bingham@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [IPU3-IPA PATCH] ipu3: Use new sensor controls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":19922,"web_url":"https://patchwork.libcamera.org/comment/19922/","msgid":"<979d556d-54b2-4778-0142-0d8ceaf85c9f@ideasonboard.com>","date":"2021-09-28T11:03:37","subject":"Re: [libcamera-devel] [IPU3-IPA PATCH] ipu3: Use new sensor controls","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Kieran\n\nOn 9/28/21 3:40 PM, Kieran Bingham wrote:\n> The IPU3 interface was updated in 4c1fc33d8ab9 (\"libcamera: ipu3: Drop\n> entityControls map\") where the sensor controls are given their own\n> dedicated control list and is named accordingly.\n>\n> Update the IPU3 IPA to match the new interface update.\n>\n> Signed-off-by: Kieran Bingham \n\n\nReviewed-by: Umang Jain \n\n> ---\n> ipu3.cpp | 6 +++---\n> 1 file changed, 3 insertions(+), 3 deletions(-)\n>\n> diff --git a/ipu3.cpp b/ipu3.cpp\n> index 3e89e6dd4e02..b60c58c990af 100644\n> --- a/ipu3.cpp\n> +++ b/ipu3.cpp\n> @@ -201,14 +201,14 @@ int IPAIPU3::start()\n> \n> int IPAIPU3::configure(const IPAConfigInfo &configInfo)\n> {\n> -\tif (configInfo.entityControls.empty()) {\n> -\t\tLOG(IPAIPU3, Error) << \"No controls provided\";\n> +\tif (configInfo.sensorControls.empty()) {\n> +\t\tLOG(IPAIPU3, Error) << \"No sensor controls provided\";\n> \t\treturn -ENODATA;\n> \t}\n> \n> \tsensorInfo_ = configInfo.sensorInfo;\n> \n> -\tctrls_ = configInfo.entityControls.at(0);\n> +\tctrls_ = configInfo.sensorControls;\n> \n> \tconst auto itExp = ctrls_.find(V4L2_CID_EXPOSURE);\n> \tif (itExp == ctrls_.end()) {","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 15FB8C3243\n\tfor ;\n\tTue, 28 Sep 2021 11:03:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4D30B6918C;\n\tTue, 28 Sep 2021 13:03:44 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E2D7769185\n\tfor ;\n\tTue, 28 Sep 2021 13:03:42 +0200 (CEST)","from [192.168.1.104] (unknown [103.251.226.4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E78A93F1;\n\tTue, 28 Sep 2021 13:03:41 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"P3ibH2t0\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1632827022;\n\tbh=sUlSnzCzAIhXRJNuPZ9zKuDnQWng1U3gPUp0soe+H2I=;\n\th=Subject:To:References:From:Date:In-Reply-To:From;\n\tb=P3ibH2t0pH08X5tIv8BXxY3/DIa3VhPRPoa2j10WbVgeaJKIehbPP/DSledCgJoIb\n\to3X/jgzBFzmDc9VqWzw/ufzgl9nPkGilKL0oiwL7j1zedSNsYqP92FQ5QkF32xD72i\n\tZFV3Jhb0CkDxdvsjF0VpmPJ2zL7lWhz1os/F0Fy8=","To":"Kieran Bingham ,\n\tlibcamera devel ","References":"<20210928101007.452727-1-kieran.bingham@ideasonboard.com>","From":"Umang Jain ","Message-ID":"<979d556d-54b2-4778-0142-0d8ceaf85c9f@ideasonboard.com>","Date":"Tue, 28 Sep 2021 16:33:37 +0530","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.10.2","MIME-Version":"1.0","In-Reply-To":"<20210928101007.452727-1-kieran.bingham@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"7bit","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [IPU3-IPA PATCH] ipu3: Use new sensor controls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":19924,"web_url":"https://patchwork.libcamera.org/comment/19924/","msgid":"<20210928120008.s47wroisnfxrewww@uno.localdomain>","date":"2021-09-28T12:00:08","subject":"Re: [libcamera-devel] [IPU3-IPA PATCH] ipu3: Use new sensor controls","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Kieran,\n\nOn Tue, Sep 28, 2021 at 12:32:39PM +0200, Jean-Michel Hautbois wrote:\n> Hi Kieran,\n>\n> On 28/09/2021 12:10, Kieran Bingham wrote:\n> > The IPU3 interface was updated in 4c1fc33d8ab9 (\"libcamera: ipu3: Drop\n> > entityControls map\") where the sensor controls are given their own\n> > dedicated control list and is named accordingly.\n> >\n> > Update the IPU3 IPA to match the new interface update.\n> >\n> > Signed-off-by: Kieran Bingham \n> Reviewed-by: Jean-Michel Hautbois \n\nThanks\nReviewed-by: Jacopo Mondi \n\n>\n> > ---\n> > ipu3.cpp | 6 +++---\n> > 1 file changed, 3 insertions(+), 3 deletions(-)\n> >\n> > diff --git a/ipu3.cpp b/ipu3.cpp\n> > index 3e89e6dd4e02..b60c58c990af 100644\n> > --- a/ipu3.cpp\n> > +++ b/ipu3.cpp\n> > @@ -201,14 +201,14 @@ int IPAIPU3::start()\n> >\n> > int IPAIPU3::configure(const IPAConfigInfo &configInfo)\n> > {\n> > -\tif (configInfo.entityControls.empty()) {\n> > -\t\tLOG(IPAIPU3, Error) << \"No controls provided\";\n> > +\tif (configInfo.sensorControls.empty()) {\n> > +\t\tLOG(IPAIPU3, Error) << \"No sensor controls provided\";\n> > \t\treturn -ENODATA;\n> > \t}\n> >\n> > \tsensorInfo_ = configInfo.sensorInfo;\n> >\n> > -\tctrls_ = configInfo.entityControls.at(0);\n> > +\tctrls_ = configInfo.sensorControls;\n> >\n> > \tconst auto itExp = ctrls_.find(V4L2_CID_EXPOSURE);\n> > \tif (itExp == ctrls_.end()) {\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8B8EEC3243\n\tfor ;\n\tTue, 28 Sep 2021 11:59:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D1DF36918C;\n\tTue, 28 Sep 2021 13:59:22 +0200 (CEST)","from relay10.mail.gandi.net (relay10.mail.gandi.net\n\t[217.70.178.230])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B79C969185\n\tfor ;\n\tTue, 28 Sep 2021 13:59:21 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby relay10.mail.gandi.net (Postfix) with ESMTPSA id 1D16924000B;\n\tTue, 28 Sep 2021 11:59:20 +0000 (UTC)"],"Date":"Tue, 28 Sep 2021 14:00:08 +0200","From":"Jacopo Mondi ","To":"Jean-Michel Hautbois ","Message-ID":"<20210928120008.s47wroisnfxrewww@uno.localdomain>","References":"<20210928101007.452727-1-kieran.bingham@ideasonboard.com>\n\t<41dd5a7d-a7a2-846f-9bdf-04b165b7f1b5@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<41dd5a7d-a7a2-846f-9bdf-04b165b7f1b5@ideasonboard.com>","Subject":"Re: [libcamera-devel] [IPU3-IPA PATCH] ipu3: Use new sensor controls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]