{"id":13964,"url":"https://patchwork.libcamera.org/api/patches/13964/?format=json","web_url":"https://patchwork.libcamera.org/patch/13964/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210928101007.452727-1-kieran.bingham@ideasonboard.com>","date":"2021-09-28T10:10:07","name":"[libcamera-devel,IPU3-IPA] ipu3: Use new sensor controls","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"d616bd65ae8ebb69736be401d725821463619004","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/13964/mbox/","series":[{"id":2579,"url":"https://patchwork.libcamera.org/api/series/2579/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2579","date":"2021-09-28T10:10:07","name":"[libcamera-devel,IPU3-IPA] ipu3: Use new sensor controls","version":1,"mbox":"https://patchwork.libcamera.org/series/2579/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/13964/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/13964/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E5D8BBDC71\n\tfor ;\n\tTue, 28 Sep 2021 10:10:13 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 248466918C;\n\tTue, 28 Sep 2021 12:10:13 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 28D4E69185\n\tfor ;\n\tTue, 28 Sep 2021 12:10:12 +0200 (CEST)","from Monstersaurus.local\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9C6523F1;\n\tTue, 28 Sep 2021 12:10:11 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"jmK6uSEz\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1632823811;\n\tbh=eOkMu3JR231qqC+Gu2JNizpg+9sI1jdVJ4OJcaHFFao=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=jmK6uSEzx3ZgHBS22GU4zfeNzvP3UeFqva+x/n4ONnq5FEiy71V1gEfOYfrkKO5u/\n\tAFvpMef0jJCUKNtT7ieCH+poUO3RrkkXYTjosAd4d9+F7iFQFkn2eSw94r6kp4KjXu\n\tIv7SMdeV+V8BPCHa4s+7oPipaK4S21bIIneCeYY4=","From":"Kieran Bingham ","To":"libcamera devel ","Date":"Tue, 28 Sep 2021 11:10:07 +0100","Message-Id":"<20210928101007.452727-1-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.30.2","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [IPU3-IPA PATCH] ipu3: Use new sensor controls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The IPU3 interface was updated in 4c1fc33d8ab9 (\"libcamera: ipu3: Drop\nentityControls map\") where the sensor controls are given their own\ndedicated control list and is named accordingly.\n\nUpdate the IPU3 IPA to match the new interface update.\n\nSigned-off-by: Kieran Bingham \n---\n ipu3.cpp | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)","diff":"diff --git a/ipu3.cpp b/ipu3.cpp\nindex 3e89e6dd4e02..b60c58c990af 100644\n--- a/ipu3.cpp\n+++ b/ipu3.cpp\n@@ -201,14 +201,14 @@ int IPAIPU3::start()\n \n int IPAIPU3::configure(const IPAConfigInfo &configInfo)\n {\n-\tif (configInfo.entityControls.empty()) {\n-\t\tLOG(IPAIPU3, Error) << \"No controls provided\";\n+\tif (configInfo.sensorControls.empty()) {\n+\t\tLOG(IPAIPU3, Error) << \"No sensor controls provided\";\n \t\treturn -ENODATA;\n \t}\n \n \tsensorInfo_ = configInfo.sensorInfo;\n \n-\tctrls_ = configInfo.entityControls.at(0);\n+\tctrls_ = configInfo.sensorControls;\n \n \tconst auto itExp = ctrls_.find(V4L2_CID_EXPOSURE);\n \tif (itExp == ctrls_.end()) {\n","prefixes":["libcamera-devel","IPU3-IPA"]}