[{"id":19898,"web_url":"https://patchwork.libcamera.org/comment/19898/","msgid":"<20210927212133.a7xyrvodhcr6uwtk@uno.localdomain>","date":"2021-09-27T21:21:33","subject":"Re: [libcamera-devel] [PATCH] libcamera: control_serializer: Fix\n\tusage of uninitialized variable","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"On Tue, Sep 28, 2021 at 12:19:33AM +0300, Laurent Pinchart wrote:\n> The idMap variable may be used uninitialized in the\n> ControlSerializer::deserialize() function as reported by\n> gcc 11:\n>\n> ../../src/libcamera/control_serializer.cpp: In member function ‘T libcamera::ControlSerializer::deserialize(libcamera::ByteStreamBuffer&) [with T = libcamera::ControlList]’:\n> ../../src/libcamera/control_serializer.cpp:609:33: error: ‘idMap’ may be used uninitialized in this function [-Werror=maybe-uninitialized]\n> 609 | ControlList ctrls(*idMap);\n> |\n>\n> This is due to a missing default case in a switch/case. Fix it by adding\n> the default case.\n>\n> Fixes: 6b1404fc4836 (\"libcamera: control_serializer: Fix usage of uninitialized variable\")\n\nUps\n\n> Signed-off-by: Laurent Pinchart \n\nThanks for fixing\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> src/libcamera/control_serializer.cpp | 1 +\n> 1 file changed, 1 insertion(+)\n>\n> diff --git a/src/libcamera/control_serializer.cpp b/src/libcamera/control_serializer.cpp\n> index 77b77448d61d..e87d23625ed2 100644\n> --- a/src/libcamera/control_serializer.cpp\n> +++ b/src/libcamera/control_serializer.cpp\n> @@ -594,6 +594,7 @@ ControlList ControlSerializer::deserialize(ByteStreamBuffer &buffer\n> \t\t\tbreak;\n>\n> \t\tcase IPA_CONTROL_ID_MAP_V4L2:\n> +\t\tdefault:\n> \t\t\tLOG(Serializer, Fatal)\n> \t\t\t\t<< \"A list of V4L2 controls requires an ControlInfoMap\";\n> \t\t\treturn {};\n>\n> base-commit: 957c5d534b42e05520de82f27b2204fa864d511a\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 53EC4C3243\n\tfor ;\n\tMon, 27 Sep 2021 21:20:47 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2FFF06918E;\n\tMon, 27 Sep 2021 23:20:47 +0200 (CEST)","from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net\n\t[217.70.183.199])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 983D66012C\n\tfor ;\n\tMon, 27 Sep 2021 23:20:46 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby relay9-d.mail.gandi.net (Postfix) with ESMTPSA id E4EEDFF806;\n\tMon, 27 Sep 2021 21:20:45 +0000 (UTC)"],"Date":"Mon, 27 Sep 2021 23:21:33 +0200","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Message-ID":"<20210927212133.a7xyrvodhcr6uwtk@uno.localdomain>","References":"<20210927211933.25088-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20210927211933.25088-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: control_serializer: Fix\n\tusage of uninitialized variable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":19908,"web_url":"https://patchwork.libcamera.org/comment/19908/","msgid":"<20210928015003.GJ4382@pyrite.rasen.tech>","date":"2021-09-28T01:50:03","subject":"Re: [libcamera-devel] [PATCH] libcamera: control_serializer: Fix\n\tusage of uninitialized variable","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Laurent,\n\nOn Tue, Sep 28, 2021 at 12:19:33AM +0300, Laurent Pinchart wrote:\n> The idMap variable may be used uninitialized in the\n> ControlSerializer::deserialize() function as reported by\n> gcc 11:\n> \n> ../../src/libcamera/control_serializer.cpp: In member function ‘T libcamera::ControlSerializer::deserialize(libcamera::ByteStreamBuffer&) [with T = libcamera::ControlList]’:\n> ../../src/libcamera/control_serializer.cpp:609:33: error: ‘idMap’ may be used uninitialized in this function [-Werror=maybe-uninitialized]\n> 609 | ControlList ctrls(*idMap);\n> |\n> \n> This is due to a missing default case in a switch/case. Fix it by adding\n> the default case.\n> \n> Fixes: 6b1404fc4836 (\"libcamera: control_serializer: Fix usage of uninitialized variable\")\n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Paul Elder \n\n> ---\n> src/libcamera/control_serializer.cpp | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/src/libcamera/control_serializer.cpp b/src/libcamera/control_serializer.cpp\n> index 77b77448d61d..e87d23625ed2 100644\n> --- a/src/libcamera/control_serializer.cpp\n> +++ b/src/libcamera/control_serializer.cpp\n> @@ -594,6 +594,7 @@ ControlList ControlSerializer::deserialize(ByteStreamBuffer &buffer\n> \t\t\tbreak;\n> \n> \t\tcase IPA_CONTROL_ID_MAP_V4L2:\n> +\t\tdefault:\n> \t\t\tLOG(Serializer, Fatal)\n> \t\t\t\t<< \"A list of V4L2 controls requires an ControlInfoMap\";\n> \t\t\treturn {};\n> \n> base-commit: 957c5d534b42e05520de82f27b2204fa864d511a\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 51E6CC3243\n\tfor ;\n\tTue, 28 Sep 2021 01:50:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AA1C96918B;\n\tTue, 28 Sep 2021 03:50:13 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6775A684C7\n\tfor ;\n\tTue, 28 Sep 2021 03:50:11 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C7CDE3F1;\n\tTue, 28 Sep 2021 03:50:09 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"XU162R4R\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1632793811;\n\tbh=SaxEuny9xuyIIv2XJ/mPWs8vxk3ca+cu6Ik2toO2h48=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=XU162R4RSRfjJNl/Avon+/QniQR7dTLC/7r6QDy3zk8LxNDKZfMFzGRzsvF/7/RaH\n\tF6JWWHEdbDYfUAgEA5SXl6D25W0moc8VbbcMLtWs+I7q91bPKxN7EtsV6OXjGlHm6k\n\tkMKjvIoC5gjuU6Q+Z/IW7K/JSyKbM2vOnM54PwhY=","Date":"Tue, 28 Sep 2021 10:50:03 +0900","From":"paul.elder@ideasonboard.com","To":"Laurent Pinchart ","Message-ID":"<20210928015003.GJ4382@pyrite.rasen.tech>","References":"<20210927211933.25088-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20210927211933.25088-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: control_serializer: Fix\n\tusage of uninitialized variable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]