[{"id":19899,"web_url":"https://patchwork.libcamera.org/comment/19899/","msgid":"<147ef44e-a429-5cc8-b552-81bcb0ca4d2a@ideasonboard.com>","date":"2021-09-27T22:11:24","subject":"Re: [libcamera-devel] [PATCH] fixup! ipa: ipu3: Rename\n\tIspStatsRegion to Accumulator","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"On 27/09/2021 19:34, Jean-Michel Hautbois wrote:\n> JM,\n> \n> You may also want this fixup as the max cells in width is 80 ;-).\n> \n> ---\n> src/ipa/ipu3/algorithms/awb.cpp | 6 +++---\n> 1 file changed, 3 insertions(+), 3 deletions(-)\n> \n> diff --git a/src/ipa/ipu3/algorithms/awb.cpp b/src/ipa/ipu3/algorithms/awb.cpp\n> index 06570b60..67cf3a55 100644\n> --- a/src/ipa/ipu3/algorithms/awb.cpp\n> +++ b/src/ipa/ipu3/algorithms/awb.cpp\n> @@ -26,8 +26,8 @@ static constexpr uint32_t kMinGreenLevelInZone = 32;\n> * - Cells are defined in Pixels\n> * - Zones are defined in Cells\n> *\n> - * 81 cells\n> - * /───────────── 1296 pixels ───────────\\\n> + * 80 cells\n\n\nI would also suggest aligning the numbers to make sure the units are\naligned.\n\nI.e.\n\n 80 ...\n1290 ...\n 16 ...\n\n--\nKieran\n\n\n> + * /───────────── 1280 pixels ───────────\\\n> * 16 zones\n> * 16\n> * ┌────┬────┬────┬────┬────┬─ ──────┬────┐ \\\n> @@ -55,7 +55,7 @@ static constexpr uint32_t kMinGreenLevelInZone = 32;\n> * └────┴────┴────┴────┴────┴─ ──────┴────┘ /\n> *\n> * The algorithm works with a fixed number of zones \\a kAwbStatsSizeX x\n> - * \\a kAwbStatsSizeY. For example, a frame of 1296x720 is divided into 81x45\n> + * \\a kAwbStatsSizeY. For example, a frame of 1280x720 is divided into 80x45\n> * cells of [16x16] pixels. In the case of \\a kAwbStatsSizeX=16 and\n> * \\a kAwbStatsSizeY=12 the zones are made of [5x4] cells. The cells are\n> * left-aligned and calculated by IPAIPU3::calculateBdsGrid().\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 90F85C3243\n\tfor ;\n\tMon, 27 Sep 2021 22:11:30 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 91A1F6918B;\n\tTue, 28 Sep 2021 00:11:29 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DDB3D6012D\n\tfor ;\n\tTue, 28 Sep 2021 00:11:27 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 59A4C3F1;\n\tTue, 28 Sep 2021 00:11:27 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"fjhIfuD7\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1632780687;\n\tbh=v4UPh6vfFrdmWa62DV7vB/CIEvGDiMaQ7WtHC6XUYWI=;\n\th=Subject:To:References:From:Date:In-Reply-To:From;\n\tb=fjhIfuD7fP6Q1aXqJdnB6jDWKU3rbixas58FBFfnzCL3ogIa2GVkZe0cyZYLMeAo1\n\t82pvE0vMgFKg3KFS2x5DE6m+5aM6ZnFLvmvGhgv3fGvXHkIAyPFWHvKZ000jkIS6cG\n\tavwrT+B1Q9vVb6Tt0b58R/WYJxDtLLg1AQkZ4kdw=","To":"Jean-Michel Hautbois ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20210923081625.60276-3-jeanmichel.hautbois@ideasonboard.com>\n\t<20210927183405.64087-1-jeanmichel.hautbois@ideasonboard.com>","From":"Kieran Bingham ","Message-ID":"<147ef44e-a429-5cc8-b552-81bcb0ca4d2a@ideasonboard.com>","Date":"Mon, 27 Sep 2021 23:11:24 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.13.0","MIME-Version":"1.0","In-Reply-To":"<20210927183405.64087-1-jeanmichel.hautbois@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH] fixup! ipa: ipu3: Rename\n\tIspStatsRegion to Accumulator","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]