[{"id":19866,"web_url":"https://patchwork.libcamera.org/comment/19866/","msgid":"<20210927065819.GG4382@pyrite.rasen.tech>","date":"2021-09-27T06:58:19","subject":"Re: [libcamera-devel] [PATCH 2/3] Documentation:\n\tapplication-developer: Use correct type to store size","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Laurent,\n\nOn Mon, Sep 27, 2021 at 12:21:07AM +0300, Laurent Pinchart wrote:\n> The return type of std::vector::size() is size_t. Use the same type,\n> instead of unsigned int, to store its return value when retrieving the\n> number of allocated buffers.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Paul Elder \n\n> ---\n> Documentation/guides/application-developer.rst | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/Documentation/guides/application-developer.rst b/Documentation/guides/application-developer.rst\n> index 3de13060db08..41a7d88369be 100644\n> --- a/Documentation/guides/application-developer.rst\n> +++ b/Documentation/guides/application-developer.rst\n> @@ -278,7 +278,7 @@ as the parameter of the ``FrameBufferAllocator::buffers()`` function.\n> return -ENOMEM;\n> }\n> \n> - unsigned int allocated = allocator->buffers(cfg.stream()).size();\n> + size_t allocated = allocator->buffers(cfg.stream()).size();\n> std::cout << \"Allocated \" << allocated << \" buffers for stream\" << std::endl;\n> }\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 66837BDC71\n\tfor ;\n\tMon, 27 Sep 2021 06:58:28 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3645A6918E;\n\tMon, 27 Sep 2021 08:58:28 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A736E684C8\n\tfor ;\n\tMon, 27 Sep 2021 08:58:26 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3AEBC49A;\n\tMon, 27 Sep 2021 08:58:24 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"cK2D/MA8\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1632725906;\n\tbh=nXEMn0JytzI5VGD3xM+VD7e6pRzgCSvhmdlM81aazx8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=cK2D/MA8NaPlzoEnBAhXzekzoF0vCOKgeEWgSxmjZrww+f6Iu0OhZ+PbDVw5Dlhcv\n\tzGRSut5e1oZLmd+G1WS6JASR/spkP4z0d6/+PvimVEHBrV6sCdeSI3gfk7UkR5ZOkx\n\t9pJbLkuwLfw5xzP8o2xJEXUj8aZ34A1zkLZZYmOs=","Date":"Mon, 27 Sep 2021 15:58:19 +0900","From":"paul.elder@ideasonboard.com","To":"Laurent Pinchart ","Message-ID":"<20210927065819.GG4382@pyrite.rasen.tech>","References":"<20210926212108.22510-1-laurent.pinchart@ideasonboard.com>\n\t<20210926212108.22510-2-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20210926212108.22510-2-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 2/3] Documentation:\n\tapplication-developer: Use correct type to store size","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":19879,"web_url":"https://patchwork.libcamera.org/comment/19879/","msgid":"<20210927122029.eafjhmtx6x7qsv3s@ideasonboard.com>","date":"2021-09-27T12:20:29","subject":"Re: [libcamera-devel] [PATCH 2/3] Documentation:\n\tapplication-developer: Use correct type to store size","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"On Mon, Sep 27, 2021 at 12:21:07AM +0300, Laurent Pinchart wrote:\n> The return type of std::vector::size() is size_t. Use the same type,\n> instead of unsigned int, to store its return value when retrieving the\n> number of allocated buffers.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Kieran Bingham \n\n> ---\n> Documentation/guides/application-developer.rst | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/Documentation/guides/application-developer.rst b/Documentation/guides/application-developer.rst\n> index 3de13060db08..41a7d88369be 100644\n> --- a/Documentation/guides/application-developer.rst\n> +++ b/Documentation/guides/application-developer.rst\n> @@ -278,7 +278,7 @@ as the parameter of the ``FrameBufferAllocator::buffers()`` function.\n> return -ENOMEM;\n> }\n> \n> - unsigned int allocated = allocator->buffers(cfg.stream()).size();\n> + size_t allocated = allocator->buffers(cfg.stream()).size();\n> std::cout << \"Allocated \" << allocated << \" buffers for stream\" << std::endl;\n> }\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n\n--\nKieran","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4F758C3243\n\tfor ;\n\tMon, 27 Sep 2021 12:20:33 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C58B26918B;\n\tMon, 27 Sep 2021 14:20:32 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5685B6012C\n\tfor ;\n\tMon, 27 Sep 2021 14:20:31 +0200 (CEST)","from ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C94FDE81;\n\tMon, 27 Sep 2021 14:20:30 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"oLboWUnX\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1632745230;\n\tbh=oThA+iDE/yaCDdq524etFq6QidKVFd4uH7vuFy/9RCU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=oLboWUnXXBmzCAiO64HHG7XMkYt9avl1gIqxPJC2Bk/LiIGnc6TDdXWEl8UMTdEaM\n\thCscg+U16v9XjmOLdjzivnqE+Q9Y5ScnH6lKemwK3vl7wXzvAriTIFY85iK0BaI1Aa\n\tfxbqaeAZL/paoNcsU+bP4ASMp6y6/9yxuyS//iRM=","Date":"Mon, 27 Sep 2021 13:20:29 +0100","From":"Kieran Bingham ","To":"Laurent Pinchart ","Message-ID":"<20210927122029.eafjhmtx6x7qsv3s@ideasonboard.com>","References":"<20210926212108.22510-1-laurent.pinchart@ideasonboard.com>\n\t<20210926212108.22510-2-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210926212108.22510-2-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 2/3] Documentation:\n\tapplication-developer: Use correct type to store size","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]