{"id":13941,"url":"https://patchwork.libcamera.org/api/patches/13941/?format=json","web_url":"https://patchwork.libcamera.org/patch/13941/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210926212108.22510-2-laurent.pinchart@ideasonboard.com>","date":"2021-09-26T21:21:07","name":"[libcamera-devel,2/3] Documentation: application-developer: Use correct type to store size","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"9312f83f9df7c59ec20375283978ccaf16c23576","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/13941/mbox/","series":[{"id":2571,"url":"https://patchwork.libcamera.org/api/series/2571/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2571","date":"2021-09-26T21:21:06","name":"[libcamera-devel,1/3] Documentation: application-developer: Make global variable static","version":1,"mbox":"https://patchwork.libcamera.org/series/2571/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/13941/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/13941/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A8176BDC71\n\tfor ;\n\tSun, 26 Sep 2021 21:21:21 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2DF0869195;\n\tSun, 26 Sep 2021 23:21:20 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 63C9F6918C\n\tfor ;\n\tSun, 26 Sep 2021 23:21:17 +0200 (CEST)","from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id F0281BB0\n\tfor ;\n\tSun, 26 Sep 2021 23:21:16 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"M7brjBzh\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1632691277;\n\tbh=OEAu3s59Esl9Hv3rq2npQpPU9I+SGmsN7uKL2PgUk7g=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=M7brjBzhOm4E6dLgCKToeymFDM0emZNXrhdFV8mtEOKvSnL9a0giHBPvsa6tQWQV/\n\tiO67jspXSK7FKIqf03c27Bz4e6wTci5kn0U/s2AWl4x92LMgv1rERWMtZ82/dHab9W\n\tVVJsE1FWNZJeb58Jise0QF6KfUi4Nw2WMx4DAeDc=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 27 Sep 2021 00:21:07 +0300","Message-Id":"<20210926212108.22510-2-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.32.0","In-Reply-To":"<20210926212108.22510-1-laurent.pinchart@ideasonboard.com>","References":"<20210926212108.22510-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 2/3] Documentation: application-developer:\n\tUse correct type to store size","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The return type of std::vector::size() is size_t. Use the same type,\ninstead of unsigned int, to store its return value when retrieving the\nnumber of allocated buffers.\n\nSigned-off-by: Laurent Pinchart \n---\n Documentation/guides/application-developer.rst | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/Documentation/guides/application-developer.rst b/Documentation/guides/application-developer.rst\nindex 3de13060db08..41a7d88369be 100644\n--- a/Documentation/guides/application-developer.rst\n+++ b/Documentation/guides/application-developer.rst\n@@ -278,7 +278,7 @@ as the parameter of the ``FrameBufferAllocator::buffers()`` function.\n return -ENOMEM;\n }\n \n- unsigned int allocated = allocator->buffers(cfg.stream()).size();\n+ size_t allocated = allocator->buffers(cfg.stream()).size();\n std::cout << \"Allocated \" << allocated << \" buffers for stream\" << std::endl;\n }\n \n","prefixes":["libcamera-devel","2/3"]}