[{"id":19868,"web_url":"https://patchwork.libcamera.org/comment/19868/","msgid":"<20210927070122.GH4382@pyrite.rasen.tech>","date":"2021-09-27T07:01:22","subject":"Re: [libcamera-devel] [PATCH 1/3] Documentation:\n\tapplication-developer: Make global variable static","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Laurent,\n\nOn Mon, Sep 27, 2021 at 12:21:06AM +0300, Laurent Pinchart wrote:\n> The global \"camera\" variable isn't accessed outside of its compilation\n> unit. Make it static.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Paul Elder \n\n> ---\n> Documentation/guides/application-developer.rst | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/Documentation/guides/application-developer.rst b/Documentation/guides/application-developer.rst\n> index ae28c96b5aca..3de13060db08 100644\n> --- a/Documentation/guides/application-developer.rst\n> +++ b/Documentation/guides/application-developer.rst\n> @@ -58,7 +58,7 @@ variable for the camera to support the event call back later:\n> \n> .. code:: cpp\n> \n> - std::shared_ptr camera;\n> + static std::shared_ptr camera;\n> \n> Create a Camera Manager instance at the beginning of the main function, and then\n> start it. An application must only create a single Camera Manager instance.\n> \n> base-commit: 72e8e03719aa552abce7eeee8a6e4a9b8eb8443e\n> --","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B979BBF01C\n\tfor ;\n\tMon, 27 Sep 2021 07:01:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7786E6918F;\n\tMon, 27 Sep 2021 09:01:31 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 18EFC69188\n\tfor ;\n\tMon, 27 Sep 2021 09:01:30 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9A37049A;\n\tMon, 27 Sep 2021 09:01:28 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"cktnxL9b\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1632726089;\n\tbh=zTTIfozhWyHGr4VvHd9pl5+vJOUM0/DfzvFc45j5PDs=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=cktnxL9bzQoRCPvJEDLDeEHwa/2a49VijzbH8TMLv53iBKE6moeN9DmrNbowxHW2X\n\tC+szBYjOv2j+vzzVDm1RyNG1Th1JN2h8/Api5Oaxl5lJRCgazw0Va/IOFAfAYBFS8b\n\tBhwADLGRBoIzGSnC5vgw+Mmbq5ig845mvql8lemk=","Date":"Mon, 27 Sep 2021 16:01:22 +0900","From":"paul.elder@ideasonboard.com","To":"Laurent Pinchart ","Message-ID":"<20210927070122.GH4382@pyrite.rasen.tech>","References":"<20210926212108.22510-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20210926212108.22510-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 1/3] Documentation:\n\tapplication-developer: Make global variable static","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":19877,"web_url":"https://patchwork.libcamera.org/comment/19877/","msgid":"<20210927120810.vkqt5mv7ilelejwz@ideasonboard.com>","date":"2021-09-27T12:08:10","subject":"Re: [libcamera-devel] [PATCH 1/3] Documentation:\n\tapplication-developer: Make global variable static","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"On Mon, Sep 27, 2021 at 12:21:06AM +0300, Laurent Pinchart wrote:\n> The global \"camera\" variable isn't accessed outside of its compilation\n> unit. Make it static.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Kieran Bingham \n\n> ---\n> Documentation/guides/application-developer.rst | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/Documentation/guides/application-developer.rst b/Documentation/guides/application-developer.rst\n> index ae28c96b5aca..3de13060db08 100644\n> --- a/Documentation/guides/application-developer.rst\n> +++ b/Documentation/guides/application-developer.rst\n> @@ -58,7 +58,7 @@ variable for the camera to support the event call back later:\n> \n> .. code:: cpp\n> \n> - std::shared_ptr camera;\n> + static std::shared_ptr camera;\n> \n> Create a Camera Manager instance at the beginning of the main function, and then\n> start it. An application must only create a single Camera Manager instance.\n> \n> base-commit: 72e8e03719aa552abce7eeee8a6e4a9b8eb8443e\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 25F41C3243\n\tfor ;\n\tMon, 27 Sep 2021 12:08:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 91F9E6918B;\n\tMon, 27 Sep 2021 14:08:13 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B11266012C\n\tfor ;\n\tMon, 27 Sep 2021 14:08:12 +0200 (CEST)","from ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 40BFEB91;\n\tMon, 27 Sep 2021 14:08:12 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"iHkgv+Ax\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1632744492;\n\tbh=dVhaOVKxbdeT5AtDyzvAOoz14WyB9OT7inbUUpkLG74=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=iHkgv+AxNMva9EP2wEA+A+wbBdghwahfiYIL6eabagAQRt+vUBpqAnV00Bi1SYR1m\n\t/sEJmYSUJgp1me8eQvJsoggv6hKLxFktVC7P8OgTxYe4NwfYWX4LZ8GLrbYUhFj2Zx\n\t18+gTeq20PGXWNSrJqi5ruDJWpp9drAbCouoacq8=","Date":"Mon, 27 Sep 2021 13:08:10 +0100","From":"Kieran Bingham ","To":"Laurent Pinchart ","Message-ID":"<20210927120810.vkqt5mv7ilelejwz@ideasonboard.com>","References":"<20210926212108.22510-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210926212108.22510-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 1/3] Documentation:\n\tapplication-developer: Make global variable static","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":19878,"web_url":"https://patchwork.libcamera.org/comment/19878/","msgid":"<20210927121753.fy6pudoeig2ah73i@ideasonboard.com>","date":"2021-09-27T12:17:53","subject":"Re: [libcamera-devel] [PATCH 1/3] Documentation:\n\tapplication-developer: Make global variable static","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"On Mon, Sep 27, 2021 at 12:21:06AM +0300, Laurent Pinchart wrote:\n> The global \"camera\" variable isn't accessed outside of its compilation\n> unit. Make it static.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Kieran Bingham \n\n> ---\n> Documentation/guides/application-developer.rst | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/Documentation/guides/application-developer.rst b/Documentation/guides/application-developer.rst\n> index ae28c96b5aca..3de13060db08 100644\n> --- a/Documentation/guides/application-developer.rst\n> +++ b/Documentation/guides/application-developer.rst\n> @@ -58,7 +58,7 @@ variable for the camera to support the event call back later:\n> \n> .. code:: cpp\n> \n> - std::shared_ptr camera;\n> + static std::shared_ptr camera;\n> \n> Create a Camera Manager instance at the beginning of the main function, and then\n> start it. An application must only create a single Camera Manager instance.\n> \n> base-commit: 72e8e03719aa552abce7eeee8a6e4a9b8eb8443e\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 63EFFBDC71\n\tfor ;\n\tMon, 27 Sep 2021 12:17:57 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C847D6918B;\n\tMon, 27 Sep 2021 14:17:56 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 625336012C\n\tfor ;\n\tMon, 27 Sep 2021 14:17:55 +0200 (CEST)","from ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D8011B91;\n\tMon, 27 Sep 2021 14:17:54 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"rEjjY8xu\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1632745075;\n\tbh=dVhaOVKxbdeT5AtDyzvAOoz14WyB9OT7inbUUpkLG74=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=rEjjY8xuMMJgCKXDdqx6h11+CqvybtevDCjtoh7V6yHGp0a5C9yf7jScK6Av2RF99\n\tR45Klse7C7IXh64TvAcZNW6Myy5SStPm8im9XssvmaQMNt1yNeFiKUeycDcYGz40Wg\n\ts5TpYzOg3Y/eEU7cFifo1fjZwZQv6+fWUVNFFUlE=","Date":"Mon, 27 Sep 2021 13:17:53 +0100","From":"Kieran Bingham ","To":"Laurent Pinchart ","Message-ID":"<20210927121753.fy6pudoeig2ah73i@ideasonboard.com>","References":"<20210926212108.22510-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210926212108.22510-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 1/3] Documentation:\n\tapplication-developer: Make global variable static","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]