[{"id":19849,"web_url":"https://patchwork.libcamera.org/comment/19849/","msgid":"<YVDbFpNvA9wWSLKX@pendragon.ideasonboard.com>","date":"2021-09-26T20:41:58","subject":"Re: [libcamera-devel] [PATCH 2/2] simple-cam: Use matching type to\n\tstore stream size","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Dorota,\n\nThank you for the patch.\n\nOn Sun, Sep 26, 2021 at 11:33:19PM +0300, Laurent Pinchart wrote:\n> From: Dorota Czaplejewicz <dorota.czaplejewicz@puri.sm>\n\nWe usually try to have a commit message body, even for simple patches.\nThis could be\n\nThe std::vector::size() function returns a size_t. Use the same type of\nthe variable that stores the return value to avoid a compiler warning.\n\nI'll let Kieran apply the patches, I'm sure he can update the commit\nmessage with the above text (if you're fine with it).\n\n> Signed-off-by: Dorota Czaplejewicz <dorota.czaplejewicz@puri.sm>\n> ---\n>  simple-cam.cpp | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/simple-cam.cpp b/simple-cam.cpp\n> index 350f68be7906..e374e45849dc 100644\n> --- a/simple-cam.cpp\n> +++ b/simple-cam.cpp\n> @@ -299,7 +299,7 @@ int main()\n>  \t\t\treturn EXIT_FAILURE;\n>  \t\t}\n>  \n> -\t\tunsigned int allocated = allocator->buffers(cfg.stream()).size();\n> +\t\tsize_t allocated = allocator->buffers(cfg.stream()).size();\n>  \t\tstd::cout << \"Allocated \" << allocated << \" buffers for stream\" << std::endl;\n>  \t}\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B77DEBDC71\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSun, 26 Sep 2021 20:42:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 182B96918E;\n\tSun, 26 Sep 2021 22:42:06 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4DBB56012D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 26 Sep 2021 22:42:04 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CA46AEF;\n\tSun, 26 Sep 2021 22:42:03 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"NE1pxAD6\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1632688924;\n\tbh=40lIA18AKXlzZxJCAx6PkBreKX83B3WcpjVGK4idklM=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=NE1pxAD6wmrmjalDNbpaDmuHe9p1sSPPvI1EXEQbEj9lAGJXpqvxq+a/OywpFR54X\n\tVZKeJnGsiQv3w5j+lfz/Sx/C2UqU+FB9eGLqZAXZbxwr5N2zPCKmg08HS4v18sQm+U\n\tIDbmWjntCCje6zVP563Q9DkAGaBA5es2TXCOrJD4=","Date":"Sun, 26 Sep 2021 23:41:58 +0300","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"libcamera-devel@lists.libcamera.org","Message-ID":"<YVDbFpNvA9wWSLKX@pendragon.ideasonboard.com>","References":"<20210926203319.18289-1-laurent.pinchart@ideasonboard.com>\n\t<20210926203319.18289-2-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210926203319.18289-2-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 2/2] simple-cam: Use matching type to\n\tstore stream size","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"Dorota Czaplejewicz <dorota.czaplejewicz@puri.sm>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":19876,"web_url":"https://patchwork.libcamera.org/comment/19876/","msgid":"<20210927120310.nfz7rhpu4wvw3lhn@ideasonboard.com>","date":"2021-09-27T12:03:10","subject":"Re: [libcamera-devel] [PATCH 2/2] simple-cam: Use matching type to\n\tstore stream size","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"On Sun, Sep 26, 2021 at 11:41:58PM +0300, Laurent Pinchart wrote:\n> Hi Dorota,\n> \n> Thank you for the patch.\n> \n> On Sun, Sep 26, 2021 at 11:33:19PM +0300, Laurent Pinchart wrote:\n> > From: Dorota Czaplejewicz <dorota.czaplejewicz@puri.sm>\n> \n> We usually try to have a commit message body, even for simple patches.\n> This could be\n> \n> The std::vector::size() function returns a size_t. Use the same type of\n> the variable that stores the return value to avoid a compiler warning.\n> \n> I'll let Kieran apply the patches, I'm sure he can update the commit\n> message with the above text (if you're fine with it).\n\nLaurent: Will you be adding a tag?\n\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\n> \n> > Signed-off-by: Dorota Czaplejewicz <dorota.czaplejewicz@puri.sm>\n> > ---\n> >  simple-cam.cpp | 2 +-\n> >  1 file changed, 1 insertion(+), 1 deletion(-)\n> > \n> > diff --git a/simple-cam.cpp b/simple-cam.cpp\n> > index 350f68be7906..e374e45849dc 100644\n> > --- a/simple-cam.cpp\n> > +++ b/simple-cam.cpp\n> > @@ -299,7 +299,7 @@ int main()\n> >  \t\t\treturn EXIT_FAILURE;\n> >  \t\t}\n> >  \n> > -\t\tunsigned int allocated = allocator->buffers(cfg.stream()).size();\n> > +\t\tsize_t allocated = allocator->buffers(cfg.stream()).size();\n> >  \t\tstd::cout << \"Allocated \" << allocated << \" buffers for stream\" << std::endl;\n> >  \t}\n> >  \n> \n> -- \n> Regards,\n> \n> Laurent Pinchart","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6689FBDC71\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 27 Sep 2021 12:03:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C93BD6012C;\n\tMon, 27 Sep 2021 14:03:13 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 446036012C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 27 Sep 2021 14:03:12 +0200 (CEST)","from ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B22E9B91;\n\tMon, 27 Sep 2021 14:03:11 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ijGHz+g9\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1632744191;\n\tbh=P2BHGpLXI5SHuMq8M7/T0KS8P4n9s/VVMtsaPxjB1bs=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=ijGHz+g9eOXGPDQ063qU7uWpadGN4rllthi4n/vNYsOqb4bFbC57ue+jUjLfnd0Ec\n\tExC24ClUmHvbIygNKohuGa8ltoZqisfY0/1isnMDS5ekTUJH0FODYR0VxEkDu58Oca\n\t+Tq46tOaF7gW6KAIAMc1/BBXynYVRHgRRG5Fd3aw=","Date":"Mon, 27 Sep 2021 13:03:10 +0100","From":"Kieran Bingham <kieran.bingham@ideasonboard.com>","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Message-ID":"<20210927120310.nfz7rhpu4wvw3lhn@ideasonboard.com>","References":"<20210926203319.18289-1-laurent.pinchart@ideasonboard.com>\n\t<20210926203319.18289-2-laurent.pinchart@ideasonboard.com>\n\t<YVDbFpNvA9wWSLKX@pendragon.ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<YVDbFpNvA9wWSLKX@pendragon.ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 2/2] simple-cam: Use matching type to\n\tstore stream size","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"Dorota Czaplejewicz <dorota.czaplejewicz@puri.sm>,\n\tlibcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":19891,"web_url":"https://patchwork.libcamera.org/comment/19891/","msgid":"<YVHoAdGliA1GmjTC@pendragon.ideasonboard.com>","date":"2021-09-27T15:49:21","subject":"Re: [libcamera-devel] [PATCH 2/2] simple-cam: Use matching type to\n\tstore stream size","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Mon, Sep 27, 2021 at 01:03:10PM +0100, Kieran Bingham wrote:\n> On Sun, Sep 26, 2021 at 11:41:58PM +0300, Laurent Pinchart wrote:\n> > On Sun, Sep 26, 2021 at 11:33:19PM +0300, Laurent Pinchart wrote:\n> > > From: Dorota Czaplejewicz <dorota.czaplejewicz@puri.sm>\n> > \n> > We usually try to have a commit message body, even for simple patches.\n> > This could be\n> > \n> > The std::vector::size() function returns a size_t. Use the same type of\n> > the variable that stores the return value to avoid a compiler warning.\n> > \n> > I'll let Kieran apply the patches, I'm sure he can update the commit\n> > message with the above text (if you're fine with it).\n> \n> Laurent: Will you be adding a tag?\n> \n> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\nSure thing.\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\nI expect you to push the recently submitted simple-cam patches, please\nlet me know if you need my help.\n\n> > > Signed-off-by: Dorota Czaplejewicz <dorota.czaplejewicz@puri.sm>\n> > > ---\n> > >  simple-cam.cpp | 2 +-\n> > >  1 file changed, 1 insertion(+), 1 deletion(-)\n> > > \n> > > diff --git a/simple-cam.cpp b/simple-cam.cpp\n> > > index 350f68be7906..e374e45849dc 100644\n> > > --- a/simple-cam.cpp\n> > > +++ b/simple-cam.cpp\n> > > @@ -299,7 +299,7 @@ int main()\n> > >  \t\t\treturn EXIT_FAILURE;\n> > >  \t\t}\n> > >  \n> > > -\t\tunsigned int allocated = allocator->buffers(cfg.stream()).size();\n> > > +\t\tsize_t allocated = allocator->buffers(cfg.stream()).size();\n> > >  \t\tstd::cout << \"Allocated \" << allocated << \" buffers for stream\" << std::endl;\n> > >  \t}\n> > >","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CAA53BDC71\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 27 Sep 2021 15:49:30 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 451456918B;\n\tMon, 27 Sep 2021 17:49:30 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E5F7E6012C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 27 Sep 2021 17:49:28 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5C195B91;\n\tMon, 27 Sep 2021 17:49:28 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"tZSHuXMj\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1632757768;\n\tbh=gQdfuz7FCSDMGN43ytB+EH62+RAPCBh2DDkO9ERTbwQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=tZSHuXMj4ROo6xIZKSZH6eokM0o+Qu1QdyeUx61jdNxFIGRxZSD170USkeAtR+Ovb\n\t+dXpkqXL7IGHCrjsY+bB78HqxZAb/c3Hp8p23MtB7AEW8pS5pK+90o3rtO0Ko6CGCC\n\t4jMaDRHD1DZVXWHefewUMAzJV2utN9JqHSxnQjC4=","Date":"Mon, 27 Sep 2021 18:49:21 +0300","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Message-ID":"<YVHoAdGliA1GmjTC@pendragon.ideasonboard.com>","References":"<20210926203319.18289-1-laurent.pinchart@ideasonboard.com>\n\t<20210926203319.18289-2-laurent.pinchart@ideasonboard.com>\n\t<YVDbFpNvA9wWSLKX@pendragon.ideasonboard.com>\n\t<20210927120310.nfz7rhpu4wvw3lhn@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210927120310.nfz7rhpu4wvw3lhn@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 2/2] simple-cam: Use matching type to\n\tstore stream size","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"Dorota Czaplejewicz <dorota.czaplejewicz@puri.sm>,\n\tlibcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":19892,"web_url":"https://patchwork.libcamera.org/comment/19892/","msgid":"<20210927175437.7c127692.dorota.czaplejewicz@puri.sm>","date":"2021-09-27T15:54:37","subject":"Re: [libcamera-devel] [PATCH 2/2] simple-cam: Use matching type to\n\tstore stream size","submitter":{"id":96,"url":"https://patchwork.libcamera.org/api/people/96/","name":"Dorota Czaplejewicz","email":"dorota.czaplejewicz@puri.sm"},"content":"Hi Laurent,\n\nOn Sun, 26 Sep 2021 23:41:58 +0300\nLaurent Pinchart <laurent.pinchart@ideasonboard.com> wrote:\n\n> Hi Dorota,\n> \n> Thank you for the patch.\n> \n> On Sun, Sep 26, 2021 at 11:33:19PM +0300, Laurent Pinchart wrote:\n> > From: Dorota Czaplejewicz <dorota.czaplejewicz@puri.sm>  \n> \n> We usually try to have a commit message body, even for simple patches.\n\nSorry, I didn't realize that. I'm used to coming up with a sufficient explanation and then putting it in the first line if it fits.\n\n> This could be\n> \n> The std::vector::size() function returns a size_t. Use the same type of\n> the variable that stores the return value to avoid a compiler warning.\n> \n> I'll let Kieran apply the patches, I'm sure he can update the commit\n> message with the above text (if you're fine with it).\n> \nI don't mind at all, go ahead.\n\nCheers,\nDorota\n\n> > Signed-off-by: Dorota Czaplejewicz <dorota.czaplejewicz@puri.sm>\n> > ---\n> >  simple-cam.cpp | 2 +-\n> >  1 file changed, 1 insertion(+), 1 deletion(-)\n> > \n> > diff --git a/simple-cam.cpp b/simple-cam.cpp\n> > index 350f68be7906..e374e45849dc 100644\n> > --- a/simple-cam.cpp\n> > +++ b/simple-cam.cpp\n> > @@ -299,7 +299,7 @@ int main()\n> >  \t\t\treturn EXIT_FAILURE;\n> >  \t\t}\n> >  \n> > -\t\tunsigned int allocated = allocator->buffers(cfg.stream()).size();\n> > +\t\tsize_t allocated = allocator->buffers(cfg.stream()).size();\n> >  \t\tstd::cout << \"Allocated \" << allocated << \" buffers for stream\" << std::endl;\n> >  \t}\n> >    \n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C0F59C3243\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 27 Sep 2021 15:56:22 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2A38B6918B;\n\tMon, 27 Sep 2021 17:56:22 +0200 (CEST)","from comms.puri.sm (comms.puri.sm [159.203.221.185])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8DA8B6012C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 27 Sep 2021 17:56:20 +0200 (CEST)","from localhost (localhost [127.0.0.1])\n\tby comms.puri.sm (Postfix) with ESMTP id C6EA1E003D;\n\tMon, 27 Sep 2021 08:56:18 -0700 (PDT)","from comms.puri.sm ([127.0.0.1])\n\tby localhost (comms.puri.sm [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 7T4Ua8BEViBW; Mon, 27 Sep 2021 08:56:18 -0700 (PDT)"],"Date":"Mon, 27 Sep 2021 17:54:37 +0200","From":"Dorota Czaplejewicz <dorota.czaplejewicz@puri.sm>","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Message-ID":"<20210927175437.7c127692.dorota.czaplejewicz@puri.sm>","In-Reply-To":"<YVDbFpNvA9wWSLKX@pendragon.ideasonboard.com>","References":"<20210926203319.18289-1-laurent.pinchart@ideasonboard.com>\n\t<20210926203319.18289-2-laurent.pinchart@ideasonboard.com>\n\t<YVDbFpNvA9wWSLKX@pendragon.ideasonboard.com>","Organization":"Purism","Content-Type":"multipart/signed; boundary=\"Sig_/WDxuPvkfr4g=Ik+C8b+Huzi\";\n\tprotocol=\"application/pgp-signature\"; micalg=pgp-sha256","Subject":"Re: [libcamera-devel] [PATCH 2/2] simple-cam: Use matching type to\n\tstore stream size","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":19893,"web_url":"https://patchwork.libcamera.org/comment/19893/","msgid":"<20210927163357.qymlz5z3ovghlwrl@ideasonboard.com>","date":"2021-09-27T16:33:57","subject":"Re: [libcamera-devel] [PATCH 2/2] simple-cam: Use matching type to\n\tstore stream size","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"On Mon, Sep 27, 2021 at 06:49:21PM +0300, Laurent Pinchart wrote:\n> Hi Kieran,\n> \n> On Mon, Sep 27, 2021 at 01:03:10PM +0100, Kieran Bingham wrote:\n> > On Sun, Sep 26, 2021 at 11:41:58PM +0300, Laurent Pinchart wrote:\n> > > On Sun, Sep 26, 2021 at 11:33:19PM +0300, Laurent Pinchart wrote:\n> > > > From: Dorota Czaplejewicz <dorota.czaplejewicz@puri.sm>\n> > > \n> > > We usually try to have a commit message body, even for simple patches.\n> > > This could be\n> > > \n> > > The std::vector::size() function returns a size_t. Use the same type of\n> > > the variable that stores the return value to avoid a compiler warning.\n> > > \n> > > I'll let Kieran apply the patches, I'm sure he can update the commit\n> > > message with the above text (if you're fine with it).\n> > \n> > Laurent: Will you be adding a tag?\n> > \n> > Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n> \n> Sure thing.\n> \n> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\nThanks,\n\n> \n> I expect you to push the recently submitted simple-cam patches, please\n> let me know if you need my help.\n\nThat's fine, I'm planning to handle them. But I've had a day throwing\nall my e-mail workflows out of the pram ;-)\n\nBut ... I hope it's all for the greater good, as now I can integrate\npatchwork states into my mailbox ...\n\n\n> > > > Signed-off-by: Dorota Czaplejewicz <dorota.czaplejewicz@puri.sm>\n> > > > ---\n> > > >  simple-cam.cpp | 2 +-\n> > > >  1 file changed, 1 insertion(+), 1 deletion(-)\n> > > > \n> > > > diff --git a/simple-cam.cpp b/simple-cam.cpp\n> > > > index 350f68be7906..e374e45849dc 100644\n> > > > --- a/simple-cam.cpp\n> > > > +++ b/simple-cam.cpp\n> > > > @@ -299,7 +299,7 @@ int main()\n> > > >  \t\t\treturn EXIT_FAILURE;\n> > > >  \t\t}\n> > > >  \n> > > > -\t\tunsigned int allocated = allocator->buffers(cfg.stream()).size();\n> > > > +\t\tsize_t allocated = allocator->buffers(cfg.stream()).size();\n> > > >  \t\tstd::cout << \"Allocated \" << allocated << \" buffers for stream\" << std::endl;\n> > > >  \t}\n> > > >  \n> \n> -- \n> Regards,\n> \n> Laurent Pinchart\n\n--\nKieran","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 19F2ABDC71\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 27 Sep 2021 16:34:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 372326918B;\n\tMon, 27 Sep 2021 18:34:00 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 140936012C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 27 Sep 2021 18:33:59 +0200 (CEST)","from ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 81692B91;\n\tMon, 27 Sep 2021 18:33:58 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"saDifM76\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1632760438;\n\tbh=OqH++1515O3/Cfb+EMSuufECX4uXJOS5hxb1wKjtNRo=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=saDifM76sZ5RiVaLLgQxlpJpPQWoDR1WpjvPw6bPDci+smAD+J3OTS1h0TLXf4LNx\n\tp1F9JcOWNRh/nC6+GuDEgEfezimGjULnogyXurwHOpFvEPA9nDi9xBAcd9HtsKp5J6\n\t7Het1wlHCLhXoFHYo4tPLg3HrNj5/fFbwtCc1iGU=","Date":"Mon, 27 Sep 2021 17:33:57 +0100","From":"Kieran Bingham <kieran.bingham@ideasonboard.com>","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Message-ID":"<20210927163357.qymlz5z3ovghlwrl@ideasonboard.com>","References":"<20210926203319.18289-1-laurent.pinchart@ideasonboard.com>\n\t<20210926203319.18289-2-laurent.pinchart@ideasonboard.com>\n\t<YVDbFpNvA9wWSLKX@pendragon.ideasonboard.com>\n\t<20210927120310.nfz7rhpu4wvw3lhn@ideasonboard.com>\n\t<YVHoAdGliA1GmjTC@pendragon.ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<YVHoAdGliA1GmjTC@pendragon.ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 2/2] simple-cam: Use matching type to\n\tstore stream size","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"Dorota Czaplejewicz <dorota.czaplejewicz@puri.sm>,\n\tlibcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]