[{"id":19848,"web_url":"https://patchwork.libcamera.org/comment/19848/","msgid":"","date":"2021-09-26T20:39:23","subject":"Re: [libcamera-devel] [PATCH 1/2] simple-cam: Turn globals static","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Dorota,\n\nThank you for the patch.\n\nOn Sun, Sep 26, 2021 at 11:33:18PM +0300, Laurent Pinchart wrote:\n> From: Dorota Czaplejewicz \n> \n> This fixes a warning from QtCreator.\n> \n> Signed-off-by: Dorota Czaplejewicz \n\nLooks good to me. I'll submit a corresponding fix to the application\nwriter's guide in libcamera.\n\nReviewed-by: Laurent Pinchart \n\n> ---\n> simple-cam.cpp | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/simple-cam.cpp b/simple-cam.cpp\n> index 95e472b4377a..350f68be7906 100644\n> --- a/simple-cam.cpp\n> +++ b/simple-cam.cpp\n> @@ -16,8 +16,8 @@\n> #define TIMEOUT_SEC 3\n> \n> using namespace libcamera;\n> -std::shared_ptr camera;\n> -EventLoop loop;\n> +static std::shared_ptr camera;\n> +static EventLoop loop;\n> \n> /*\n> * --------------------------------------------------------------------\n> \n> base-commit: b8da445fc72cfd436ed7ddb8a428e7ea11af9fd9\n> prerequisite-patch-id: a93394f0289868f6be89478f79cc43f1080d5751","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B7A17BF01C\n\tfor ;\n\tSun, 26 Sep 2021 20:39:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 14AD06918E;\n\tSun, 26 Sep 2021 22:39:31 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 48E0C6012D\n\tfor ;\n\tSun, 26 Sep 2021 22:39:29 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C006FEF;\n\tSun, 26 Sep 2021 22:39:28 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"GIKzoloe\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1632688769;\n\tbh=RHHzHkaqT7f2VMKstYQ0KjA3NPSAE36428EMzd7GWsU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=GIKzoloew25/adUb1L8adIcXOycoPaWAAQi/JmP4l1wLTBEz4unDqm+g92bYfr+nO\n\tQWyuSItyiGtBF/E6lRnZQYUJtVBSR0ktRLtLG4a1bdEE/2zkMb5w++QbYIx3vDOEYI\n\tEHbAt3u89qzUEzogfh1SAMwn8ZYyEV2GEqcWArcg=","Date":"Sun, 26 Sep 2021 23:39:23 +0300","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Message-ID":"","References":"<20210926203319.18289-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210926203319.18289-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 1/2] simple-cam: Turn globals static","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Dorota Czaplejewicz ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":19863,"web_url":"https://patchwork.libcamera.org/comment/19863/","msgid":"<20210927065142.GD4382@pyrite.rasen.tech>","date":"2021-09-27T06:51:42","subject":"Re: [libcamera-devel] [PATCH 1/2] simple-cam: Turn globals static","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi,\n\nOn Sun, Sep 26, 2021 at 11:33:18PM +0300, Laurent Pinchart wrote:\n> From: Dorota Czaplejewicz \n> \n> This fixes a warning from QtCreator.\n> \n> Signed-off-by: Dorota Czaplejewicz \n\nReviewed-by: Paul Elder \n\n> ---\n> simple-cam.cpp | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/simple-cam.cpp b/simple-cam.cpp\n> index 95e472b4377a..350f68be7906 100644\n> --- a/simple-cam.cpp\n> +++ b/simple-cam.cpp\n> @@ -16,8 +16,8 @@\n> #define TIMEOUT_SEC 3\n> \n> using namespace libcamera;\n> -std::shared_ptr camera;\n> -EventLoop loop;\n> +static std::shared_ptr camera;\n> +static EventLoop loop;\n> \n> /*\n> * --------------------------------------------------------------------\n> \n> base-commit: b8da445fc72cfd436ed7ddb8a428e7ea11af9fd9\n> prerequisite-patch-id: a93394f0289868f6be89478f79cc43f1080d5751","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C3ADEBF01C\n\tfor ;\n\tMon, 27 Sep 2021 06:51:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 245AD6918E;\n\tMon, 27 Sep 2021 08:51:52 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B531B684C8\n\tfor ;\n\tMon, 27 Sep 2021 08:51:50 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E5D9549A;\n\tMon, 27 Sep 2021 08:51:48 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"HmlMTJUL\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1632725510;\n\tbh=w6br72a5CtHQgTRukPkn0aZrKLaoQL8sEpwHVEDYU48=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=HmlMTJUL/0ypTZc1XNPX11u5eRl1MqQ4TB/P19C3k31d5Mi43gVOueTYKpisT6dEb\n\tocicB2YwfUjnyZd80PI9eGLHWqYmW8/7JteoCN0glZVDAiYfGLrQmuoss1o0mRFzgZ\n\t8ZaoZW1NBQ6rNfoz/BA+sRJFOifRJ/OJR86cPhBU=","Date":"Mon, 27 Sep 2021 15:51:42 +0900","From":"paul.elder@ideasonboard.com","To":"Laurent Pinchart ","Message-ID":"<20210927065142.GD4382@pyrite.rasen.tech>","References":"<20210926203319.18289-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20210926203319.18289-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 1/2] simple-cam: Turn globals static","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Dorota Czaplejewicz ,\n\tlibcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":19875,"web_url":"https://patchwork.libcamera.org/comment/19875/","msgid":"<20210927115943.5gwpkazrcei7b2pl@ideasonboard.com>","date":"2021-09-27T11:59:43","subject":"Re: [libcamera-devel] [PATCH 1/2] simple-cam: Turn globals static","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"On Sun, Sep 26, 2021 at 11:39:23PM +0300, Laurent Pinchart wrote:\n> Hi Dorota,\n> \n> Thank you for the patch.\n> \n> On Sun, Sep 26, 2021 at 11:33:18PM +0300, Laurent Pinchart wrote:\n> > From: Dorota Czaplejewicz \n> > \n> > This fixes a warning from QtCreator.\n> > \n> > Signed-off-by: Dorota Czaplejewicz \n> \n> Looks good to me. I'll submit a corresponding fix to the application\n> writer's guide in libcamera.\n\nI've got other patches to submit to that too ... maybe it's time to\nrevive them.\n\nBut this is likely a good thing to do all the same\n\nReviewed-by: Kieran Bingham \n\n> \n> Reviewed-by: Laurent Pinchart \n> \n> > ---\n> > simple-cam.cpp | 4 ++--\n> > 1 file changed, 2 insertions(+), 2 deletions(-)\n> > \n> > diff --git a/simple-cam.cpp b/simple-cam.cpp\n> > index 95e472b4377a..350f68be7906 100644\n> > --- a/simple-cam.cpp\n> > +++ b/simple-cam.cpp\n> > @@ -16,8 +16,8 @@\n> > #define TIMEOUT_SEC 3\n> > \n> > using namespace libcamera;\n> > -std::shared_ptr camera;\n> > -EventLoop loop;\n> > +static std::shared_ptr camera;\n> > +static EventLoop loop;\n> > \n> > /*\n> > * --------------------------------------------------------------------\n> > \n> > base-commit: b8da445fc72cfd436ed7ddb8a428e7ea11af9fd9\n> > prerequisite-patch-id: a93394f0289868f6be89478f79cc43f1080d5751\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8B676C3243\n\tfor ;\n\tMon, 27 Sep 2021 11:59:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AB1B06918B;\n\tMon, 27 Sep 2021 13:59:47 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8C6B26012C\n\tfor ;\n\tMon, 27 Sep 2021 13:59:45 +0200 (CEST)","from ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0D460B91;\n\tMon, 27 Sep 2021 13:59:45 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"lIP+8kOp\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1632743985;\n\tbh=cBbUhyXzaognqkWP3GQNbxoL4UBe8LtBEn2mVi5TvIg=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=lIP+8kOpaSyPEv5c961qnzbxYQydP7IzSSstlWQQRLboxbK9NclvZYfaipA+NmtPZ\n\txCW3cQr04/ykq2NUp+ct8R0Ge08KcUdjQmMwuS96XhWl+1GfLoDi8y8Qdx4XOU8t3e\n\tlSPku1bXpahZeJUQeCbrzzDu8HCjyImdqiY7Letw=","Date":"Mon, 27 Sep 2021 12:59:43 +0100","From":"Kieran Bingham ","To":"Laurent Pinchart ","Message-ID":"<20210927115943.5gwpkazrcei7b2pl@ideasonboard.com>","References":"<20210926203319.18289-1-laurent.pinchart@ideasonboard.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH 1/2] simple-cam: Turn globals static","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Dorota Czaplejewicz ,\n\tlibcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]