{"id":13937,"url":"https://patchwork.libcamera.org/api/patches/13937/?format=json","web_url":"https://patchwork.libcamera.org/patch/13937/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210926203319.18289-1-laurent.pinchart@ideasonboard.com>","date":"2021-09-26T20:33:18","name":"[libcamera-devel,1/2] simple-cam: Turn globals static","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"47cd89b53d1cea87446f22ac56fa9ed93faf4c0b","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/13937/mbox/","series":[{"id":2569,"url":"https://patchwork.libcamera.org/api/series/2569/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2569","date":"2021-09-26T20:33:18","name":"[libcamera-devel,1/2] simple-cam: Turn globals static","version":1,"mbox":"https://patchwork.libcamera.org/series/2569/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/13937/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/13937/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 38B6BBDC71\n\tfor ;\n\tSun, 26 Sep 2021 20:33:32 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6E1D769190;\n\tSun, 26 Sep 2021 22:33:31 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2FF0A6012D\n\tfor ;\n\tSun, 26 Sep 2021 22:33:30 +0200 (CEST)","from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 874D2EF;\n\tSun, 26 Sep 2021 22:33:29 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"pJt+jw0S\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1632688409;\n\tbh=PZ8lja7/WNldmfS7YauJZeMO8M6VlQeWVgQ/CecF+/c=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=pJt+jw0SVgfEu3iBWnRa/C/ztD2EOvQ12di3ZJxusA/e/jILxLWGxEBhsI5+wTCEi\n\t8xeBOHcFsjgFH0fQebmNaZHpu5/4kvIgF/F36mdgVj1Z4YElOdB4ET4Kwq5An/v2VH\n\tfJ3d7h+g+OhFiYDc+xL7rsh8Y0V6P9UdooAZIr98=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Sun, 26 Sep 2021 23:33:18 +0300","Message-Id":"<20210926203319.18289-1-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.32.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 1/2] simple-cam: Turn globals static","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Dorota Czaplejewicz ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"From: Dorota Czaplejewicz \n\nThis fixes a warning from QtCreator.\n\nSigned-off-by: Dorota Czaplejewicz \n---\n simple-cam.cpp | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\n\nbase-commit: b8da445fc72cfd436ed7ddb8a428e7ea11af9fd9\nprerequisite-patch-id: a93394f0289868f6be89478f79cc43f1080d5751","diff":"diff --git a/simple-cam.cpp b/simple-cam.cpp\nindex 95e472b4377a..350f68be7906 100644\n--- a/simple-cam.cpp\n+++ b/simple-cam.cpp\n@@ -16,8 +16,8 @@\n #define TIMEOUT_SEC 3\n \n using namespace libcamera;\n-std::shared_ptr camera;\n-EventLoop loop;\n+static std::shared_ptr camera;\n+static EventLoop loop;\n \n /*\n * --------------------------------------------------------------------\n","prefixes":["libcamera-devel","1/2"]}