[{"id":19843,"web_url":"https://patchwork.libcamera.org/comment/19843/","msgid":"","date":"2021-09-24T15:25:25","subject":"Re: [libcamera-devel] [PATCH] libcamera: camera_manager: Fix\n\tutils.h #include location","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"On 24/09/2021 16:03, Laurent Pinchart wrote:\n> The utils.h header #include is separate from the rest of the group for\n> no reason. Move it to where it should be.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Kieran Bingham \n\n\n> ---\n> src/libcamera/camera_manager.cpp | 3 +--\n> 1 file changed, 1 insertion(+), 2 deletions(-)\n> \n> diff --git a/src/libcamera/camera_manager.cpp b/src/libcamera/camera_manager.cpp\n> index e7d026ae94c8..43bfa2b72a51 100644\n> --- a/src/libcamera/camera_manager.cpp\n> +++ b/src/libcamera/camera_manager.cpp\n> @@ -12,10 +12,9 @@\n> \n> #include \n> \n> -#include \n> -\n> #include \n> #include \n> +#include \n> \n> #include \"libcamera/internal/device_enumerator.h\"\n> #include \"libcamera/internal/ipa_manager.h\"\n> \n> base-commit: 40f5fddca7f774944a53f58eeaebc4db79c373d8\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 44690BF01C\n\tfor ;\n\tFri, 24 Sep 2021 15:25:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 70FED6918E;\n\tFri, 24 Sep 2021 17:25:30 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D7E11687DD\n\tfor ;\n\tFri, 24 Sep 2021 17:25:28 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5744FE52;\n\tFri, 24 Sep 2021 17:25:28 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"mbelsHkP\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1632497128;\n\tbh=J4yh7YcEMpA5EIin91JE7/91cRwfyHDc+cCMTWzVxao=;\n\th=Subject:To:References:From:Date:In-Reply-To:From;\n\tb=mbelsHkPT79lrIGOzSTD7Q14mMOPT6Xbx+U1a+fJlWBlRkyD1Y5UKecDNbcieRiiR\n\t4EhIhkCeZnlBxrG+nwP9d999eB/cJBCo1uwcpeIAg9BEVR0FmBeNdJWxsabwLzaQSn\n\tQuFq8nXDwuCnU1jTHAeR16VBuKSuFN7S4jiy1kp8=","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20210924150339.18835-1-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham ","Message-ID":"","Date":"Fri, 24 Sep 2021 16:25:25 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.11.0","MIME-Version":"1.0","In-Reply-To":"<20210924150339.18835-1-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH] libcamera: camera_manager: Fix\n\tutils.h #include location","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":19845,"web_url":"https://patchwork.libcamera.org/comment/19845/","msgid":"","date":"2021-09-25T03:59:53","subject":"Re: [libcamera-devel] [PATCH] libcamera: camera_manager: Fix\n\tutils.h #include location","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 9/24/21 8:33 PM, Laurent Pinchart wrote:\n> The utils.h header #include is separate from the rest of the group for\n> no reason. Move it to where it should be.\n>\n> Signed-off-by: Laurent Pinchart \n\n\nReviewed-by: Umang Jain \n\n> ---\n> src/libcamera/camera_manager.cpp | 3 +--\n> 1 file changed, 1 insertion(+), 2 deletions(-)\n>\n> diff --git a/src/libcamera/camera_manager.cpp b/src/libcamera/camera_manager.cpp\n> index e7d026ae94c8..43bfa2b72a51 100644\n> --- a/src/libcamera/camera_manager.cpp\n> +++ b/src/libcamera/camera_manager.cpp\n> @@ -12,10 +12,9 @@\n> \n> #include \n> \n> -#include \n> -\n> #include \n> #include \n> +#include \n> \n> #include \"libcamera/internal/device_enumerator.h\"\n> #include \"libcamera/internal/ipa_manager.h\"\n>\n> base-commit: 40f5fddca7f774944a53f58eeaebc4db79c373d8","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 94A7EBDC71\n\tfor ;\n\tSat, 25 Sep 2021 04:00:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CE38D6918E;\n\tSat, 25 Sep 2021 06:00:01 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 21CBE60241\n\tfor ;\n\tSat, 25 Sep 2021 05:59:59 +0200 (CEST)","from [192.168.1.104] (unknown [103.251.226.51])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 17F17BB0;\n\tSat, 25 Sep 2021 05:59:57 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ZYkbA+kA\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1632542398;\n\tbh=YyZJIdLXIPzSc0ARtVKhWS5nR5+pa+UpvbBaWLBSbBE=;\n\th=Subject:To:References:From:Date:In-Reply-To:From;\n\tb=ZYkbA+kAlS5slnnk5c1LBKThiU4IlHoFchZJ8cAtK7l50n9Wn8roRn/vxQ7K78lF2\n\tvcEB3ch7qDOVatdqPLMDytpLed39V2WT/AKvIGnO0puNe4HdBUw/pf6a+03qRwYHZ5\n\t5g0JtFFsCDm4+miKNsVsJ8DjD6+ZmFDYQOYMXu98=","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20210924150339.18835-1-laurent.pinchart@ideasonboard.com>","From":"Umang Jain ","Message-ID":"","Date":"Sat, 25 Sep 2021 09:29:53 +0530","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.10.2","MIME-Version":"1.0","In-Reply-To":"<20210924150339.18835-1-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"7bit","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH] libcamera: camera_manager: Fix\n\tutils.h #include location","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]