[{"id":19861,"web_url":"https://patchwork.libcamera.org/comment/19861/","msgid":"<20210927063751.GA4382@pyrite.rasen.tech>","date":"2021-09-27T06:37:51","subject":"Re: [libcamera-devel] [PATCH v2] gstreamer: Fix spelling of the\n\tword, manager used in a util function","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Vedant,\n\nThe subject can be slightly more concise:\n\ngstreamer: Fix spelling of the word manager in an util function\n\nOn Fri, Sep 24, 2021 at 03:29:37PM +0530, Vedant Paranjape wrote:\n> Fix all name in all instances of the function gst_libcamera_get_camera_mananger\n> to gst_libcamera_get_camera_manager. Spelling of manager was incorrect.\n\nThis can be more concise too:\n\nFix spelling of the function gst_libcamera_get_camera_mananger.\n\n\nManipulating information density in english writing is yet another skill.\n\n> \n> This patch has no functional changes.\n> \n> Signed-off-by: Vedant Paranjape \n\nOtherwise, looks good.\n\n\nReviewed-by: Paul Elder \n\n> ---\n> src/gstreamer/gstlibcamera-utils.cpp | 2 +-\n> src/gstreamer/gstlibcamera-utils.h | 2 +-\n> src/gstreamer/gstlibcameraprovider.cpp | 2 +-\n> src/gstreamer/gstlibcamerasrc.cpp | 2 +-\n> 4 files changed, 4 insertions(+), 4 deletions(-)\n> \n> diff --git a/src/gstreamer/gstlibcamera-utils.cpp b/src/gstreamer/gstlibcamera-utils.cpp\n> index cef5b03fe204..3f2422863c03 100644\n> --- a/src/gstreamer/gstlibcamera-utils.cpp\n> +++ b/src/gstreamer/gstlibcamera-utils.cpp\n> @@ -239,7 +239,7 @@ G_LOCK_DEFINE_STATIC(cm_singleton_lock);\n> static std::weak_ptr cm_singleton_ptr;\n> \n> std::shared_ptr\n> -gst_libcamera_get_camera_mananger(int &ret)\n> +gst_libcamera_get_camera_manager(int &ret)\n> {\n> \tstd::shared_ptr cm;\n> \n> diff --git a/src/gstreamer/gstlibcamera-utils.h b/src/gstreamer/gstlibcamera-utils.h\n> index 67a06db3d28a..7087fef0a94d 100644\n> --- a/src/gstreamer/gstlibcamera-utils.h\n> +++ b/src/gstreamer/gstlibcamera-utils.h\n> @@ -20,7 +20,7 @@ GstCaps *gst_libcamera_stream_configuration_to_caps(const libcamera::StreamConfi\n> void gst_libcamera_configure_stream_from_caps(libcamera::StreamConfiguration &stream_cfg,\n> \t\t\t\t\t GstCaps *caps);\n> void gst_libcamera_resume_task(GstTask *task);\n> -std::shared_ptr gst_libcamera_get_camera_mananger(int &ret);\n> +std::shared_ptr gst_libcamera_get_camera_manager(int &ret);\n> \n> /**\n> * \\class GLibLocker\n> diff --git a/src/gstreamer/gstlibcameraprovider.cpp b/src/gstreamer/gstlibcameraprovider.cpp\n> index 948ba0d14037..aee6f9a2be2b 100644\n> --- a/src/gstreamer/gstlibcameraprovider.cpp\n> +++ b/src/gstreamer/gstlibcameraprovider.cpp\n> @@ -180,7 +180,7 @@ gst_libcamera_provider_probe(GstDeviceProvider *provider)\n> \t * gains monitoring support. Meanwhile we need to cycle start()/stop()\n> \t * to ensure every probe() calls return the latest list.\n> \t */\n> -\tcm = gst_libcamera_get_camera_mananger(ret);\n> +\tcm = gst_libcamera_get_camera_manager(ret);\n> \tif (ret) {\n> \t\tGST_ERROR_OBJECT(self, \"Failed to retrieve device list: %s\",\n> \t\t\t\t g_strerror(-ret));\n> diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp\n> index 15409106eac2..b545de4c4262 100644\n> --- a/src/gstreamer/gstlibcamerasrc.cpp\n> +++ b/src/gstreamer/gstlibcamerasrc.cpp\n> @@ -204,7 +204,7 @@ gst_libcamera_src_open(GstLibcameraSrc *self)\n> \n> \tGST_DEBUG_OBJECT(self, \"Opening camera device ...\");\n> \n> -\tcm = gst_libcamera_get_camera_mananger(ret);\n> +\tcm = gst_libcamera_get_camera_manager(ret);\n> \tif (ret) {\n> \t\tGST_ELEMENT_ERROR(self, LIBRARY, INIT,\n> \t\t\t\t (\"Failed listing cameras.\"),\n> -- \n> 2.25.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D0185BF01C\n\tfor ;\n\tMon, 27 Sep 2021 06:38:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3173469191;\n\tMon, 27 Sep 2021 08:38:01 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7F3D2684C8\n\tfor ;\n\tMon, 27 Sep 2021 08:37:59 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E431049A;\n\tMon, 27 Sep 2021 08:37:57 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"FbfR2J5D\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1632724679;\n\tbh=Su0SSumwIhIMTJ1631KC3ITi8ZS+FB9svfnCo1d6Tws=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=FbfR2J5DRPCX3TKGFaEKqwIyqlrsmuEwMPOYMGaNm5gMSwJHbOp0eJ4NMuykwNIWD\n\tMpMcPrMjOXLQRKTZrkMfmtIvnS9JVCq5Mab6aS8kQZDhNrbCwUiJvZ6lCwQVtAlGhX\n\tuaz7LfgNfOrOsGtgFMHJjywL67M+oR+qerHPFYtQ=","Date":"Mon, 27 Sep 2021 15:37:51 +0900","From":"paul.elder@ideasonboard.com","To":"Vedant Paranjape ","Message-ID":"<20210927063751.GA4382@pyrite.rasen.tech>","References":"<20210924095937.1954349-1-vedantparanjape160201@gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20210924095937.1954349-1-vedantparanjape160201@gmail.com>","Subject":"Re: [libcamera-devel] [PATCH v2] gstreamer: Fix spelling of the\n\tword, manager used in a util function","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":19867,"web_url":"https://patchwork.libcamera.org/comment/19867/","msgid":"","date":"2021-09-27T07:00:17","subject":"Re: [libcamera-devel] [PATCH v2] gstreamer: Fix spelling of the\n\tword, manager used in a util function","submitter":{"id":85,"url":"https://patchwork.libcamera.org/api/people/85/","name":"Vedant Paranjape","email":"vedantparanjape160201@gmail.com"},"content":"Hi Paul,\nThanks for the feedback.\n\nCan you please make the changes before merging ? or should I sent a new\npatch.\n\nRegards,\nVedant Paranjape\n\n\nOn Mon, 27 Sep, 2021, 12:07 , wrote:\n\n> Hi Vedant,\n>\n> The subject can be slightly more concise:\n>\n> gstreamer: Fix spelling of the word manager in an util function\n>\n> On Fri, Sep 24, 2021 at 03:29:37PM +0530, Vedant Paranjape wrote:\n> > Fix all name in all instances of the function\n> gst_libcamera_get_camera_mananger\n> > to gst_libcamera_get_camera_manager. Spelling of manager was incorrect.\n>\n> This can be more concise too:\n>\n> Fix spelling of the function gst_libcamera_get_camera_mananger.\n>\n>\n> Manipulating information density in english writing is yet another skill.\n>\n> >\n> > This patch has no functional changes.\n> >\n> > Signed-off-by: Vedant Paranjape \n>\n> Otherwise, looks good.\n>\n>\n> Reviewed-by: Paul Elder \n>\n> > ---\n> > src/gstreamer/gstlibcamera-utils.cpp | 2 +-\n> > src/gstreamer/gstlibcamera-utils.h | 2 +-\n> > src/gstreamer/gstlibcameraprovider.cpp | 2 +-\n> > src/gstreamer/gstlibcamerasrc.cpp | 2 +-\n> > 4 files changed, 4 insertions(+), 4 deletions(-)\n> >\n> > diff --git a/src/gstreamer/gstlibcamera-utils.cpp\n> b/src/gstreamer/gstlibcamera-utils.cpp\n> > index cef5b03fe204..3f2422863c03 100644\n> > --- a/src/gstreamer/gstlibcamera-utils.cpp\n> > +++ b/src/gstreamer/gstlibcamera-utils.cpp\n> > @@ -239,7 +239,7 @@ G_LOCK_DEFINE_STATIC(cm_singleton_lock);\n> > static std::weak_ptr cm_singleton_ptr;\n> >\n> > std::shared_ptr\n> > -gst_libcamera_get_camera_mananger(int &ret)\n> > +gst_libcamera_get_camera_manager(int &ret)\n> > {\n> > std::shared_ptr cm;\n> >\n> > diff --git a/src/gstreamer/gstlibcamera-utils.h\n> b/src/gstreamer/gstlibcamera-utils.h\n> > index 67a06db3d28a..7087fef0a94d 100644\n> > --- a/src/gstreamer/gstlibcamera-utils.h\n> > +++ b/src/gstreamer/gstlibcamera-utils.h\n> > @@ -20,7 +20,7 @@ GstCaps\n> *gst_libcamera_stream_configuration_to_caps(const libcamera::StreamConfi\n> > void\n> gst_libcamera_configure_stream_from_caps(libcamera::StreamConfiguration\n> &stream_cfg,\n> > GstCaps *caps);\n> > void gst_libcamera_resume_task(GstTask *task);\n> > -std::shared_ptr\n> gst_libcamera_get_camera_mananger(int &ret);\n> > +std::shared_ptr\n> gst_libcamera_get_camera_manager(int &ret);\n> >\n> > /**\n> > * \\class GLibLocker\n> > diff --git a/src/gstreamer/gstlibcameraprovider.cpp\n> b/src/gstreamer/gstlibcameraprovider.cpp\n> > index 948ba0d14037..aee6f9a2be2b 100644\n> > --- a/src/gstreamer/gstlibcameraprovider.cpp\n> > +++ b/src/gstreamer/gstlibcameraprovider.cpp\n> > @@ -180,7 +180,7 @@ gst_libcamera_provider_probe(GstDeviceProvider\n> *provider)\n> > * gains monitoring support. Meanwhile we need to cycle\n> start()/stop()\n> > * to ensure every probe() calls return the latest list.\n> > */\n> > - cm = gst_libcamera_get_camera_mananger(ret);\n> > + cm = gst_libcamera_get_camera_manager(ret);\n> > if (ret) {\n> > GST_ERROR_OBJECT(self, \"Failed to retrieve device list:\n> %s\",\n> > g_strerror(-ret));\n> > diff --git a/src/gstreamer/gstlibcamerasrc.cpp\n> b/src/gstreamer/gstlibcamerasrc.cpp\n> > index 15409106eac2..b545de4c4262 100644\n> > --- a/src/gstreamer/gstlibcamerasrc.cpp\n> > +++ b/src/gstreamer/gstlibcamerasrc.cpp\n> > @@ -204,7 +204,7 @@ gst_libcamera_src_open(GstLibcameraSrc *self)\n> >\n> > GST_DEBUG_OBJECT(self, \"Opening camera device ...\");\n> >\n> > - cm = gst_libcamera_get_camera_mananger(ret);\n> > + cm = gst_libcamera_get_camera_manager(ret);\n> > if (ret) {\n> > GST_ELEMENT_ERROR(self, LIBRARY, INIT,\n> > (\"Failed listing cameras.\"),\n> > --\n> > 2.25.1\n> >\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3848ABF01C\n\tfor ;\n\tMon, 27 Sep 2021 07:00:33 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B5A2269191;\n\tMon, 27 Sep 2021 09:00:32 +0200 (CEST)","from mail-yb1-xb32.google.com (mail-yb1-xb32.google.com\n\t[IPv6:2607:f8b0:4864:20::b32])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 819AF69188\n\tfor ;\n\tMon, 27 Sep 2021 09:00:31 +0200 (CEST)","by mail-yb1-xb32.google.com with SMTP id z5so21670228ybj.2\n\tfor ;\n\tMon, 27 Sep 2021 00:00:31 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"d4053YUw\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=sF/Ulf7uvPjhnbTOmOfwLlbekE2BuYn4deBRw0zfh0k=;\n\tb=d4053YUwwzFv6jt/brpFaxEj6Ni95skzb9seliPziBpwiL4TDWQclqJsk3jLubmGMT\n\tv3C/yaAybfSKatdVjNXOkfgWRO91DO2ZjGGf1J5GCjX1CRkrZI/XpqfcMRsMtIumPOP5\n\tYZcHPsJ3kpv0x5VQZqXr1LV32DkJ1oTo+c38ycMFFLbOsuxGUCpgh6RbpZq3vk5HML3m\n\tJWH7zeuuTXTIn4w8wtWsdV05Klzq+xsD3k8ZnV4CSUuK9GXsEGPiMFdUk7WVKQrAbX17\n\tK5ZQxE7OSnRT4U+yul3xfqd1Fi2hhdK4LU6yLxYIbv7mDET+UW4Ux8Nj+W7mx3s38i2p\n\tmMvA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=sF/Ulf7uvPjhnbTOmOfwLlbekE2BuYn4deBRw0zfh0k=;\n\tb=fwWkRQGmbAcd/v3ojGocxrCAPfwEFPC4md05kmumKpjKh44Kh95Z1uf30pBYaqSFFj\n\t+H1mrOq+osDEvDPUQIL5Jh4n3ZS0tHR34VxAxbox9eSq63NFbMhLBbFIiN7rq3Aiz8DH\n\tWqJtP6hk+EkuEl9gYWBHGm/gZH4KY5lpTm5sNGhe9cuWXn4PUkV5fv4qBY5DhkxUaRXj\n\tQor+T/jPCjQQf25zf8XA7Y6P+9DpIKBPlkTdvi8eLa8ttdyHvS1QUlpHJ0dbnR+t7Q+9\n\t4FiWLvdcNdm/iuuT07x884+E3fQCcYrPtsj7KVsvDWU6eTn14uJUD1qyTiirYLeOS/Xe\n\tBimA==","X-Gm-Message-State":"AOAM533pmgoZvT1uD3fpIidI1rcjwhhg5IYbJzwztbsIjZKszrWdX2d4\n\tSgQXDiyyrM963j0AsIYl39lPwO2xht0YkkKCJJWvpNtQzZw=","X-Google-Smtp-Source":"ABdhPJyLyM1CjEc1MhKoqDcAUBN3U8OTAVLewYB0nRpT12iuHD7bQvEl6lCo194gF50JoLXOJj8fiUsD3Nl3o1tHZJo=","X-Received":"by 2002:a25:e697:: with SMTP id d145mr1329754ybh.4.1632726030211;\n\tMon, 27 Sep 2021 00:00:30 -0700 (PDT)","MIME-Version":"1.0","References":"<20210924095937.1954349-1-vedantparanjape160201@gmail.com>\n\t<20210927063751.GA4382@pyrite.rasen.tech>","In-Reply-To":"<20210927063751.GA4382@pyrite.rasen.tech>","From":"Vedant Paranjape ","Date":"Mon, 27 Sep 2021 12:30:17 +0530","Message-ID":"","To":"Paul Elder ","Content-Type":"multipart/alternative; boundary=\"0000000000000bdd7505ccf4a798\"","Subject":"Re: [libcamera-devel] [PATCH v2] gstreamer: Fix spelling of the\n\tword, manager used in a util function","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"LibCamera Devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]