{"id":13918,"url":"https://patchwork.libcamera.org/api/patches/13918/?format=json","web_url":"https://patchwork.libcamera.org/patch/13918/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210924095937.1954349-1-vedantparanjape160201@gmail.com>","date":"2021-09-24T09:59:37","name":"[libcamera-devel,v2] gstreamer: Fix spelling of the word, manager used in a util function","commit_ref":"03c9b1a0a47b4210154b560c9533eedd1a2aeea3","pull_url":null,"state":"accepted","archived":false,"hash":"e0ad3bfb0f59a78769b1a2c1cb3d3665b1396289","submitter":{"id":85,"url":"https://patchwork.libcamera.org/api/people/85/?format=json","name":"Vedant Paranjape","email":"vedantparanjape160201@gmail.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/13918/mbox/","series":[{"id":2561,"url":"https://patchwork.libcamera.org/api/series/2561/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2561","date":"2021-09-24T09:59:37","name":"[libcamera-devel,v2] gstreamer: Fix spelling of the word, manager used in a util function","version":2,"mbox":"https://patchwork.libcamera.org/series/2561/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/13918/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/13918/checks/","tags":{},"headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1B248BF01C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 24 Sep 2021 09:59:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DA20C6918C;\n\tFri, 24 Sep 2021 11:59:47 +0200 (CEST)","from mail-pl1-x62d.google.com (mail-pl1-x62d.google.com\n\t[IPv6:2607:f8b0:4864:20::62d])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CB9D269186\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 24 Sep 2021 11:59:46 +0200 (CEST)","by mail-pl1-x62d.google.com with SMTP id a7so6143465plm.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 24 Sep 2021 02:59:46 -0700 (PDT)","from localhost.localdomain ([1.186.166.87])\n\tby smtp.googlemail.com with ESMTPSA id\n\tv6sm8232400pfv.83.2021.09.24.02.59.43\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 24 Sep 2021 02:59:44 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"HBFGH7uT\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n\th=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=+m3hCTrC9OIVcBWLjG8rJT9LMl0vk8fzOsNR8+Dv/cU=;\n\tb=HBFGH7uTvvpupnOsjNDXLkmnW0MwuOIhYgdVDYSAiWph48Tug1+BlXFITO3WlIISaT\n\t7O+t8NyumbIYI/S6ZWfcN5J7aOxsW3oqkO9ssZLq3H90PWsH/8VqLq6CLQHAi2zD2ucg\n\t6sPK6b70/pKemLApxBlQJ5d+08rExyfLQLj0rwVXbKbvc/JXjc40Wf/R3fLU7vyzawJB\n\tY4La3QL3TC50b3P+KoVlTh/nDJRk8G+3UASQUnjdgj8+2kYjRb3mob+tGw3Hg+hGIZdg\n\tn3J+ZlZgyg9zynVT7AWAwF7HwGnRRsM6vwNyoENM00xVL6ANuHffarlxI4C27vtsfuTO\n\tv+Uw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=+m3hCTrC9OIVcBWLjG8rJT9LMl0vk8fzOsNR8+Dv/cU=;\n\tb=Che/IRpZTHMliNfQh2O3M2aywTucjGjdQefHvswGLlDdcJ8CqlbJ+ZTHQJD+t21yiM\n\tghRU94w7GzOBo02ZAjD8zfu19b4/tadpsKzffh4bKRSYOtEa5v1YmawXw+8PK7uZs91G\n\tByvOaJ+4ON6FrJ4kiObJaweeIUE26t1ld5wrNPh9AgfRGxYxIvkKEoQhB0/4rIKBLSdN\n\tmLoGxGSu3N3IEUFJM/GcWOvVqRf9C0jnxJ4AvHbIvD5LscpTEtOdyBZF0nk8/eW/s6k2\n\tUCjq6bcbLuKOw+bkbRerFPh0C1DJhbvj/zJ0bUMvi+Z+Z3MN7/ZdPAfK9+fiAfxf+Y0X\n\tetYA==","X-Gm-Message-State":"AOAM530GDhKUHRVvklPVbLIfg6hQfLus8xoSAeYGD6Kzpmy3emNSSZnh\n\tt+UN46YQTuAr/fgAr3CMKdDpUMQaxlrUragb","X-Google-Smtp-Source":"ABdhPJwYp+1rSQVEF09BCSM5SKyLG9bL2BYXJTJufvEirtWvx9YJGEdVj5M+exfEokXlZfu65pFBjA==","X-Received":"by 2002:a17:90b:1d05:: with SMTP id\n\ton5mr1205029pjb.204.1632477585007; \n\tFri, 24 Sep 2021 02:59:45 -0700 (PDT)","From":"Vedant Paranjape <vedantparanjape160201@gmail.com>","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 24 Sep 2021 15:29:37 +0530","Message-Id":"<20210924095937.1954349-1-vedantparanjape160201@gmail.com>","X-Mailer":"git-send-email 2.25.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2] gstreamer: Fix spelling of the word,\n\tmanager used in a util function","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"Vedant Paranjape <vedantparanjape160201@gmail.com>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"Fix all name in all instances of the function gst_libcamera_get_camera_mananger\nto gst_libcamera_get_camera_manager. Spelling of manager was incorrect.\n\nThis patch has no functional changes.\n\nSigned-off-by: Vedant Paranjape <vedantparanjape160201@gmail.com>\n---\n src/gstreamer/gstlibcamera-utils.cpp   | 2 +-\n src/gstreamer/gstlibcamera-utils.h     | 2 +-\n src/gstreamer/gstlibcameraprovider.cpp | 2 +-\n src/gstreamer/gstlibcamerasrc.cpp      | 2 +-\n 4 files changed, 4 insertions(+), 4 deletions(-)","diff":"diff --git a/src/gstreamer/gstlibcamera-utils.cpp b/src/gstreamer/gstlibcamera-utils.cpp\nindex cef5b03fe204..3f2422863c03 100644\n--- a/src/gstreamer/gstlibcamera-utils.cpp\n+++ b/src/gstreamer/gstlibcamera-utils.cpp\n@@ -239,7 +239,7 @@ G_LOCK_DEFINE_STATIC(cm_singleton_lock);\n static std::weak_ptr<CameraManager> cm_singleton_ptr;\n \n std::shared_ptr<CameraManager>\n-gst_libcamera_get_camera_mananger(int &ret)\n+gst_libcamera_get_camera_manager(int &ret)\n {\n \tstd::shared_ptr<CameraManager> cm;\n \ndiff --git a/src/gstreamer/gstlibcamera-utils.h b/src/gstreamer/gstlibcamera-utils.h\nindex 67a06db3d28a..7087fef0a94d 100644\n--- a/src/gstreamer/gstlibcamera-utils.h\n+++ b/src/gstreamer/gstlibcamera-utils.h\n@@ -20,7 +20,7 @@ GstCaps *gst_libcamera_stream_configuration_to_caps(const libcamera::StreamConfi\n void gst_libcamera_configure_stream_from_caps(libcamera::StreamConfiguration &stream_cfg,\n \t\t\t\t\t      GstCaps *caps);\n void gst_libcamera_resume_task(GstTask *task);\n-std::shared_ptr<libcamera::CameraManager> gst_libcamera_get_camera_mananger(int &ret);\n+std::shared_ptr<libcamera::CameraManager> gst_libcamera_get_camera_manager(int &ret);\n \n /**\n  * \\class GLibLocker\ndiff --git a/src/gstreamer/gstlibcameraprovider.cpp b/src/gstreamer/gstlibcameraprovider.cpp\nindex 948ba0d14037..aee6f9a2be2b 100644\n--- a/src/gstreamer/gstlibcameraprovider.cpp\n+++ b/src/gstreamer/gstlibcameraprovider.cpp\n@@ -180,7 +180,7 @@ gst_libcamera_provider_probe(GstDeviceProvider *provider)\n \t * gains monitoring support. Meanwhile we need to cycle start()/stop()\n \t * to ensure every probe() calls return the latest list.\n \t */\n-\tcm = gst_libcamera_get_camera_mananger(ret);\n+\tcm = gst_libcamera_get_camera_manager(ret);\n \tif (ret) {\n \t\tGST_ERROR_OBJECT(self, \"Failed to retrieve device list: %s\",\n \t\t\t\t g_strerror(-ret));\ndiff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp\nindex 15409106eac2..b545de4c4262 100644\n--- a/src/gstreamer/gstlibcamerasrc.cpp\n+++ b/src/gstreamer/gstlibcamerasrc.cpp\n@@ -204,7 +204,7 @@ gst_libcamera_src_open(GstLibcameraSrc *self)\n \n \tGST_DEBUG_OBJECT(self, \"Opening camera device ...\");\n \n-\tcm = gst_libcamera_get_camera_mananger(ret);\n+\tcm = gst_libcamera_get_camera_manager(ret);\n \tif (ret) {\n \t\tGST_ELEMENT_ERROR(self, LIBRARY, INIT,\n \t\t\t\t  (\"Failed listing cameras.\"),\n","prefixes":["libcamera-devel","v2"]}