[{"id":19883,"web_url":"https://patchwork.libcamera.org/comment/19883/","msgid":"<87a1845c24900d8db85db35e91281ffc69e3c088.camel@ndufresne.ca>","date":"2021-09-27T13:27:20","subject":"Re: [libcamera-devel] [PATCH v1] gstreamer: Fix spelling of the\n\twork manager used in a util function","submitter":{"id":30,"url":"https://patchwork.libcamera.org/api/people/30/","name":"Nicolas Dufresne","email":"nicolas@ndufresne.ca"},"content":"Le vendredi 24 septembre 2021 à 15:27 +0530, Vedant Paranjape a écrit :\n> Fix all name in all instances of the function gst_libcamera_get_camera_mananger\n> to gst_libcamera_get_camera_manager. Spelling of manager was incorrect.\n> \n> This patch has no functional changes.\n> \n> Signed-off-by: Vedant Paranjape \n\nReviewed-by: Nicolas Dufresne \n\n> ---\n> src/gstreamer/gstlibcamera-utils.cpp | 2 +-\n> src/gstreamer/gstlibcamera-utils.h | 2 +-\n> src/gstreamer/gstlibcameraprovider.cpp | 2 +-\n> src/gstreamer/gstlibcamerasrc.cpp | 2 +-\n> 4 files changed, 4 insertions(+), 4 deletions(-)\n> \n> diff --git a/src/gstreamer/gstlibcamera-utils.cpp b/src/gstreamer/gstlibcamera-utils.cpp\n> index cef5b03fe204..3f2422863c03 100644\n> --- a/src/gstreamer/gstlibcamera-utils.cpp\n> +++ b/src/gstreamer/gstlibcamera-utils.cpp\n> @@ -239,7 +239,7 @@ G_LOCK_DEFINE_STATIC(cm_singleton_lock);\n> static std::weak_ptr cm_singleton_ptr;\n> \n> std::shared_ptr\n> -gst_libcamera_get_camera_mananger(int &ret)\n> +gst_libcamera_get_camera_manager(int &ret)\n> {\n> \tstd::shared_ptr cm;\n> \n> diff --git a/src/gstreamer/gstlibcamera-utils.h b/src/gstreamer/gstlibcamera-utils.h\n> index 67a06db3d28a..7087fef0a94d 100644\n> --- a/src/gstreamer/gstlibcamera-utils.h\n> +++ b/src/gstreamer/gstlibcamera-utils.h\n> @@ -20,7 +20,7 @@ GstCaps *gst_libcamera_stream_configuration_to_caps(const libcamera::StreamConfi\n> void gst_libcamera_configure_stream_from_caps(libcamera::StreamConfiguration &stream_cfg,\n> \t\t\t\t\t GstCaps *caps);\n> void gst_libcamera_resume_task(GstTask *task);\n> -std::shared_ptr gst_libcamera_get_camera_mananger(int &ret);\n> +std::shared_ptr gst_libcamera_get_camera_manager(int &ret);\n> \n> /**\n> * \\class GLibLocker\n> diff --git a/src/gstreamer/gstlibcameraprovider.cpp b/src/gstreamer/gstlibcameraprovider.cpp\n> index 948ba0d14037..aee6f9a2be2b 100644\n> --- a/src/gstreamer/gstlibcameraprovider.cpp\n> +++ b/src/gstreamer/gstlibcameraprovider.cpp\n> @@ -180,7 +180,7 @@ gst_libcamera_provider_probe(GstDeviceProvider *provider)\n> \t * gains monitoring support. Meanwhile we need to cycle start()/stop()\n> \t * to ensure every probe() calls return the latest list.\n> \t */\n> -\tcm = gst_libcamera_get_camera_mananger(ret);\n> +\tcm = gst_libcamera_get_camera_manager(ret);\n> \tif (ret) {\n> \t\tGST_ERROR_OBJECT(self, \"Failed to retrieve device list: %s\",\n> \t\t\t\t g_strerror(-ret));\n> diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp\n> index 15409106eac2..b545de4c4262 100644\n> --- a/src/gstreamer/gstlibcamerasrc.cpp\n> +++ b/src/gstreamer/gstlibcamerasrc.cpp\n> @@ -204,7 +204,7 @@ gst_libcamera_src_open(GstLibcameraSrc *self)\n> \n> \tGST_DEBUG_OBJECT(self, \"Opening camera device ...\");\n> \n> -\tcm = gst_libcamera_get_camera_mananger(ret);\n> +\tcm = gst_libcamera_get_camera_manager(ret);\n> \tif (ret) {\n> \t\tGST_ELEMENT_ERROR(self, LIBRARY, INIT,\n> \t\t\t\t (\"Failed listing cameras.\"),","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 115BCBDC71\n\tfor ;\n\tMon, 27 Sep 2021 13:27:26 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7F1AC6012C;\n\tMon, 27 Sep 2021 15:27:25 +0200 (CEST)","from mail-qt1-x82d.google.com (mail-qt1-x82d.google.com\n\t[IPv6:2607:f8b0:4864:20::82d])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B79856012C\n\tfor ;\n\tMon, 27 Sep 2021 15:27:23 +0200 (CEST)","by mail-qt1-x82d.google.com with SMTP id c20so16595775qtb.2\n\tfor ;\n\tMon, 27 Sep 2021 06:27:23 -0700 (PDT)","from nicolas-tpx395.localdomain (173-246-12-168.qc.cable.ebox.net.\n\t[173.246.12.168]) by smtp.gmail.com with ESMTPSA id\n\tx10sm6171492qtq.45.2021.09.27.06.27.21\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 27 Sep 2021 06:27:21 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=ndufresne-ca.20210112.gappssmtp.com\n\theader.i=@ndufresne-ca.20210112.gappssmtp.com\n\theader.b=\"xCoLHugc\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ndufresne-ca.20210112.gappssmtp.com; s=20210112;\n\th=message-id:subject:from:to:date:in-reply-to:references:user-agent\n\t:mime-version:content-transfer-encoding;\n\tbh=BdKZ/3G9QGMwudb1mGHB9ti5NdaqShooppWuOVxwL3M=;\n\tb=xCoLHugcpmk35gHI45iJWQb66glNu9moUp3eV6AHxCPoR1NTyYNxK2glkFcDOXkjDx\n\tckP6v9YQmqoHk1UtzVd9VtbvJaOVoZSP8V6/BSjBJYIdIYerg/bPrn22f7csy56IlVRi\n\tJy6qK1UFJ6Zvqvn0Nj91MprhwkNV+VzQyH0BJ47xmKKkuf3052irzACm2xUayZVRYdPX\n\t4kPn0Z3SlWTCZaoyhF3wwBIf6OHmcUmoSZpJIWA2Aqn1CQtWzeT3p/wrOILXHKktOemp\n\t8VcOKSfwIEnpUow5/LHOhD45kvS6n+xTdX8kHWkYtSgLo26hKEMURcRKoSHXP2/HMHto\n\tjhoQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:message-id:subject:from:to:date:in-reply-to\n\t:references:user-agent:mime-version:content-transfer-encoding;\n\tbh=BdKZ/3G9QGMwudb1mGHB9ti5NdaqShooppWuOVxwL3M=;\n\tb=cjvjhr/4slYu3D2qYwY2T2UcYBsyZgp3IgVBBDwe14HjG5a9xrJmRV5AzUVJU0/CFO\n\tbJedgopyQ2+FYdMP31LX0NqB/UMtlmfs7MhBt7Q/PguWiR7aLvgCTPD0Qo/cr7c32pr1\n\tg98Lo1dyFuvuhTwwLfeRG+CMSDletH1k3NLN5irafNy1sMfqXrPSpLBXh419BsTR3CDp\n\tlqEh1WOhMpR5tIrFcJ6V53L44znxW/xFJKqHP7jDZFDblTsjNOYy/noNWDbAj5KceOxh\n\tDB7++JczFvIlubMRqYkOYRSdMd6Htn+03DCDRDt/41kCry6NpN4sdx8oIlWHOu9OIQ49\n\ttN5Q==","X-Gm-Message-State":"AOAM533Xx59GbE5J2qdg8g1mszlA8AZjtkxlT6/OKsACpVYNm6fiUF5G\n\tiEGSOCDBrCsZ3zI/bBy/LwanoQ==","X-Google-Smtp-Source":"ABdhPJzYsEV3iszwT4wyGOAllvtNUS8RYUroQ29Kju1aawx+Ter6QSIKd6VUlSxa920DOxrg0HQf/g==","X-Received":"by 2002:ac8:6703:: with SMTP id\n\te3mr18267327qtp.307.1632749242239; \n\tMon, 27 Sep 2021 06:27:22 -0700 (PDT)","Message-ID":"<87a1845c24900d8db85db35e91281ffc69e3c088.camel@ndufresne.ca>","From":"Nicolas Dufresne ","To":"Vedant Paranjape , \n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 27 Sep 2021 09:27:20 -0400","In-Reply-To":"<20210924095757.1951918-1-vedantparanjape160201@gmail.com>","References":"<20210924095757.1951918-1-vedantparanjape160201@gmail.com>","Content-Type":"text/plain; charset=\"UTF-8\"","User-Agent":"Evolution 3.40.4 (3.40.4-1.fc34) ","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH v1] gstreamer: Fix spelling of the\n\twork manager used in a util function","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":19906,"web_url":"https://patchwork.libcamera.org/comment/19906/","msgid":"","date":"2021-09-28T01:26:30","subject":"Re: [libcamera-devel] [PATCH v1] gstreamer: Fix spelling of the\n\twork manager used in a util function","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Mon, Sep 27, 2021 at 09:27:20AM -0400, Nicolas Dufresne wrote:\n> Le vendredi 24 septembre 2021 à 15:27 +0530, Vedant Paranjape a écrit :\n> > Fix all name in all instances of the function gst_libcamera_get_camera_mananger\n> > to gst_libcamera_get_camera_manager. Spelling of manager was incorrect.\n> > \n> > This patch has no functional changes.\n> > \n> > Signed-off-by: Vedant Paranjape \n> \n> Reviewed-by: Nicolas Dufresne \n\nAnd\n\nReviewed-by: Laurent Pinchart \n\n> > ---\n> > src/gstreamer/gstlibcamera-utils.cpp | 2 +-\n> > src/gstreamer/gstlibcamera-utils.h | 2 +-\n> > src/gstreamer/gstlibcameraprovider.cpp | 2 +-\n> > src/gstreamer/gstlibcamerasrc.cpp | 2 +-\n> > 4 files changed, 4 insertions(+), 4 deletions(-)\n> > \n> > diff --git a/src/gstreamer/gstlibcamera-utils.cpp b/src/gstreamer/gstlibcamera-utils.cpp\n> > index cef5b03fe204..3f2422863c03 100644\n> > --- a/src/gstreamer/gstlibcamera-utils.cpp\n> > +++ b/src/gstreamer/gstlibcamera-utils.cpp\n> > @@ -239,7 +239,7 @@ G_LOCK_DEFINE_STATIC(cm_singleton_lock);\n> > static std::weak_ptr cm_singleton_ptr;\n> > \n> > std::shared_ptr\n> > -gst_libcamera_get_camera_mananger(int &ret)\n> > +gst_libcamera_get_camera_manager(int &ret)\n> > {\n> > \tstd::shared_ptr cm;\n> > \n> > diff --git a/src/gstreamer/gstlibcamera-utils.h b/src/gstreamer/gstlibcamera-utils.h\n> > index 67a06db3d28a..7087fef0a94d 100644\n> > --- a/src/gstreamer/gstlibcamera-utils.h\n> > +++ b/src/gstreamer/gstlibcamera-utils.h\n> > @@ -20,7 +20,7 @@ GstCaps *gst_libcamera_stream_configuration_to_caps(const libcamera::StreamConfi\n> > void gst_libcamera_configure_stream_from_caps(libcamera::StreamConfiguration &stream_cfg,\n> > \t\t\t\t\t GstCaps *caps);\n> > void gst_libcamera_resume_task(GstTask *task);\n> > -std::shared_ptr gst_libcamera_get_camera_mananger(int &ret);\n> > +std::shared_ptr gst_libcamera_get_camera_manager(int &ret);\n> > \n> > /**\n> > * \\class GLibLocker\n> > diff --git a/src/gstreamer/gstlibcameraprovider.cpp b/src/gstreamer/gstlibcameraprovider.cpp\n> > index 948ba0d14037..aee6f9a2be2b 100644\n> > --- a/src/gstreamer/gstlibcameraprovider.cpp\n> > +++ b/src/gstreamer/gstlibcameraprovider.cpp\n> > @@ -180,7 +180,7 @@ gst_libcamera_provider_probe(GstDeviceProvider *provider)\n> > \t * gains monitoring support. Meanwhile we need to cycle start()/stop()\n> > \t * to ensure every probe() calls return the latest list.\n> > \t */\n> > -\tcm = gst_libcamera_get_camera_mananger(ret);\n> > +\tcm = gst_libcamera_get_camera_manager(ret);\n> > \tif (ret) {\n> > \t\tGST_ERROR_OBJECT(self, \"Failed to retrieve device list: %s\",\n> > \t\t\t\t g_strerror(-ret));\n> > diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp\n> > index 15409106eac2..b545de4c4262 100644\n> > --- a/src/gstreamer/gstlibcamerasrc.cpp\n> > +++ b/src/gstreamer/gstlibcamerasrc.cpp\n> > @@ -204,7 +204,7 @@ gst_libcamera_src_open(GstLibcameraSrc *self)\n> > \n> > \tGST_DEBUG_OBJECT(self, \"Opening camera device ...\");\n> > \n> > -\tcm = gst_libcamera_get_camera_mananger(ret);\n> > +\tcm = gst_libcamera_get_camera_manager(ret);\n> > \tif (ret) {\n> > \t\tGST_ELEMENT_ERROR(self, LIBRARY, INIT,\n> > \t\t\t\t (\"Failed listing cameras.\"),","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3390FBDC71\n\tfor ;\n\tTue, 28 Sep 2021 01:26:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5449069189;\n\tTue, 28 Sep 2021 03:26:38 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6DD476012D\n\tfor ;\n\tTue, 28 Sep 2021 03:26:37 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 045DF3F1;\n\tTue, 28 Sep 2021 03:26:36 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"vWKV5MhF\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1632792397;\n\tbh=6jisSptQ/y0++YG+x1Lw/wsDdZs97zLSwuKDZeLJFO8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=vWKV5MhF/5xa95NNzYIIVNZqBVznElLJA89ktGdE8PcAi5uMtjkgRdaubD+S0zCLz\n\tAVviCou6CENtN654qu9g+uzQ0T8PaMs6XFRbyk5SeYdTVy5go2SFUIBe43k6+nZM0J\n\t/6B9t3mCq4tURXLHdXUdZ4aK9pTNEGDxPg4+6BLQ=","Date":"Tue, 28 Sep 2021 04:26:30 +0300","From":"Laurent Pinchart ","To":"Nicolas Dufresne ","Message-ID":"","References":"<20210924095757.1951918-1-vedantparanjape160201@gmail.com>\n\t<87a1845c24900d8db85db35e91281ffc69e3c088.camel@ndufresne.ca>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<87a1845c24900d8db85db35e91281ffc69e3c088.camel@ndufresne.ca>","Subject":"Re: [libcamera-devel] [PATCH v1] gstreamer: Fix spelling of the\n\twork manager used in a util function","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org,\n\tVedant Paranjape ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]