[{"id":19837,"web_url":"https://patchwork.libcamera.org/comment/19837/","msgid":"<20210924090957.GY4382@pyrite.rasen.tech>","date":"2021-09-24T09:09:57","subject":"Re: [libcamera-devel] [PATCH v1] test: gstreamer: Remove\n\tunnecessary header file includes","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Vedant,\n\nOn Fri, Sep 24, 2021 at 02:30:02PM +0530, Vedant Paranjape wrote:\n> Remove header files which were not being used in the test code.\n> The following files, libcamera/base/utils.h and\n> libcamera/internal/source_paths.h were removed from includes.\n> \n> Signed-off-by: Vedant Paranjape \n\nReviewed-by: Paul Elder \n\n> ---\n> test/gstreamer/gstreamer_single_stream_test.cpp | 4 ----\n> 1 file changed, 4 deletions(-)\n> \n> diff --git a/test/gstreamer/gstreamer_single_stream_test.cpp b/test/gstreamer/gstreamer_single_stream_test.cpp\n> index 4a12e7957725..a0dd12cfea84 100644\n> --- a/test/gstreamer/gstreamer_single_stream_test.cpp\n> +++ b/test/gstreamer/gstreamer_single_stream_test.cpp\n> @@ -8,10 +8,6 @@\n> #include \n> #include \n> \n> -#include \n> -\n> -#include \"libcamera/internal/source_paths.h\"\n> -\n> #include \n> \n> #include \"gstreamer_test.h\"\n> -- \n> 2.25.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 37957BDC71\n\tfor ;\n\tFri, 24 Sep 2021 09:10:07 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 514336918C;\n\tFri, 24 Sep 2021 11:10:06 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 70B8C69186\n\tfor ;\n\tFri, 24 Sep 2021 11:10:05 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D0C5145E;\n\tFri, 24 Sep 2021 11:10:03 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"vLNtADky\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1632474605;\n\tbh=IfGy0Mjmip2V6235leUBPCIB1/Iqi3C5OHsjKbzH2ac=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=vLNtADkyLWTvL3oDSrFNU/rhHtgnK/M59yTKPqu1KnQeBFzgijBRyOOP39AQj+6Ma\n\tzoO5p/CU4A2Fq6NMbQZ4n/oaCu3k2PtYCIkGjCORH0Z0pKWVPmGl3iSBIP9CWslTKM\n\tg8I8IhyPggrq+nqvhF/gdN3lE8Bh3OdeM+sjwJeU=","Date":"Fri, 24 Sep 2021 18:09:57 +0900","From":"paul.elder@ideasonboard.com","To":"Vedant Paranjape ","Message-ID":"<20210924090957.GY4382@pyrite.rasen.tech>","References":"<20210924090002.1901913-1-vedantparanjape160201@gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20210924090002.1901913-1-vedantparanjape160201@gmail.com>","Subject":"Re: [libcamera-devel] [PATCH v1] test: gstreamer: Remove\n\tunnecessary header file includes","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":19959,"web_url":"https://patchwork.libcamera.org/comment/19959/","msgid":"<009bc6df-1c8a-ad64-7cad-2e626fe40c03@ideasonboard.com>","date":"2021-09-29T06:23:43","subject":"Re: [libcamera-devel] [PATCH v1] test: gstreamer: Remove\n\tunnecessary header file includes","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hello,\n\nOn 9/24/21 2:39 PM, paul.elder@ideasonboard.com wrote:\n> Hi Vedant,\n>\n> On Fri, Sep 24, 2021 at 02:30:02PM +0530, Vedant Paranjape wrote:\n>> Remove header files which were not being used in the test code.\n>> The following files, libcamera/base/utils.h and\n>> libcamera/internal/source_paths.h were removed from includes.\n>>\n>> Signed-off-by: Vedant Paranjape \n> Reviewed-by: Paul Elder \n\n\nReviewed-by: Umang Jain \n>\n>> ---\n>> test/gstreamer/gstreamer_single_stream_test.cpp | 4 ----\n>> 1 file changed, 4 deletions(-)\n>>\n>> diff --git a/test/gstreamer/gstreamer_single_stream_test.cpp b/test/gstreamer/gstreamer_single_stream_test.cpp\n>> index 4a12e7957725..a0dd12cfea84 100644\n>> --- a/test/gstreamer/gstreamer_single_stream_test.cpp\n>> +++ b/test/gstreamer/gstreamer_single_stream_test.cpp\n>> @@ -8,10 +8,6 @@\n>> #include \n>> #include \n>> \n>> -#include \n>> -\n>> -#include \"libcamera/internal/source_paths.h\"\n>> -\n>> #include \n>> \n>> #include \"gstreamer_test.h\"\n>> -- \n>> 2.25.1\n>>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0A6B5C3243\n\tfor ;\n\tWed, 29 Sep 2021 06:23:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 44A0B69191;\n\tWed, 29 Sep 2021 08:23:50 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8A719602DD\n\tfor ;\n\tWed, 29 Sep 2021 08:23:49 +0200 (CEST)","from [192.168.1.104] (unknown [103.251.226.9])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5BC4ED87;\n\tWed, 29 Sep 2021 08:23:48 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"HB4OXjlH\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1632896629;\n\tbh=sD0XStYs3JaYF5iGu8nDRACPsvcfEIIAXu7CPTq2lyc=;\n\th=Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=HB4OXjlHw7nY+lfiC34eTU21Tsd9CTj9s8gBf94ODs0eurgH8oEx+xDdTimEF38fB\n\t7ASS99plYznlvGQqqRV4s5b4scwSKhVUdXLKpeB7BsWFIV9HxkCPHSlYG+AxLRuEet\n\tFW9yRSeEy1qd0/dg06T1SXtYRvJwizXZXobNczXE=","To":"paul.elder@ideasonboard.com,\n\tVedant Paranjape ","References":"<20210924090002.1901913-1-vedantparanjape160201@gmail.com>\n\t<20210924090957.GY4382@pyrite.rasen.tech>","From":"Umang Jain ","Message-ID":"<009bc6df-1c8a-ad64-7cad-2e626fe40c03@ideasonboard.com>","Date":"Wed, 29 Sep 2021 11:53:43 +0530","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.10.2","MIME-Version":"1.0","In-Reply-To":"<20210924090957.GY4382@pyrite.rasen.tech>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"7bit","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH v1] test: gstreamer: Remove\n\tunnecessary header file includes","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]