{"id":13910,"url":"https://patchwork.libcamera.org/api/patches/13910/?format=json","web_url":"https://patchwork.libcamera.org/patch/13910/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210923115558.31107-1-laurent.pinchart@ideasonboard.com>","date":"2021-09-23T11:55:58","name":"[libcamera-devel] libcamera: v4l2_videodevice: Don't move planes to construct FrameBuffer","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"4063b63365ecebfebad87a3b76935c9f99afe12e","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/13910/mbox/","series":[{"id":2553,"url":"https://patchwork.libcamera.org/api/series/2553/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2553","date":"2021-09-23T11:55:58","name":"[libcamera-devel] libcamera: v4l2_videodevice: Don't move planes to construct FrameBuffer","version":1,"mbox":"https://patchwork.libcamera.org/series/2553/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/13910/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/13910/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5FFE7BF01C\n\tfor ;\n\tThu, 23 Sep 2021 11:56:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 22A436918C;\n\tThu, 23 Sep 2021 13:56:05 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0CDD869189\n\tfor ;\n\tThu, 23 Sep 2021 13:56:04 +0200 (CEST)","from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A183F58B\n\tfor ;\n\tThu, 23 Sep 2021 13:56:03 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"vHw28Keu\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1632398163;\n\tbh=GP4xKjNS/jjGmogU1d2OQT9FAfcp+ypnZMWrIoe7SpE=;\n\th=From:To:Subject:Date:From;\n\tb=vHw28KeuQHZut7HKi3P9lKrYz6lGaqNDmYXjWeTUlz+UzA0QfKOSUEaKJK33T7PgY\n\t0zbtwQ7w77Q95kabg2dDBDYL2dmMcmkAblKarqI8FSQZglzhW0WopEcVIlf5Li431B\n\tmrkjC78d2eGV6MBz1H8HfLUi8s1dxwZFlBZPCpwk=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 23 Sep 2021 14:55:58 +0300","Message-Id":"<20210923115558.31107-1-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.32.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH] libcamera: v4l2_videodevice: Don't move\n\tplanes to construct FrameBuffer","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The FrameBuffer class has no constructor that takes an rvalue reference\nto planes. The std::move() is thus misleading as a copy will still take\nplace. Drop it to clarify the code, no functional change is introduced.\n\nSigned-off-by: Laurent Pinchart \n---\n src/libcamera/v4l2_videodevice.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\n\nbase-commit: 2cc4303b172a76ac5b431c4fb4df8a083f7d3fcf","diff":"diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp\nindex 9b3ee88757be..ba5f88cd41ed 100644\n--- a/src/libcamera/v4l2_videodevice.cpp\n+++ b/src/libcamera/v4l2_videodevice.cpp\n@@ -1376,7 +1376,7 @@ std::unique_ptr V4L2VideoDevice::createBuffer(unsigned int index)\n \t\t}\n \t}\n \n-\treturn std::make_unique(std::move(planes));\n+\treturn std::make_unique(planes);\n }\n \n FileDescriptor V4L2VideoDevice::exportDmabufFd(unsigned int index,\n","prefixes":["libcamera-devel"]}