[{"id":1833,"web_url":"https://patchwork.libcamera.org/comment/1833/","msgid":"<20190611060655.7myo4e7z3scygmhu@uno.localdomain>","date":"2019-06-11T06:06:55","subject":"Re: [libcamera-devel] [PATCH 3/3] libcamera: geometry: Fix\n\tSizeRange constructor style","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Kieran,\n\nOn Mon, Jun 10, 2019 at 11:07:59PM +0100, Kieran Bingham wrote:\n> Match the style of the SizeRange() which specifies the hStep and vStep,\n> and wrap the lines in pairs of min and max values.\n>\n> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n> ---\n>  src/libcamera/geometry.cpp | 3 ++-\n>  1 file changed, 2 insertions(+), 1 deletion(-)\n>\n> diff --git a/src/libcamera/geometry.cpp b/src/libcamera/geometry.cpp\n> index 97c367bcb454..fb8f628a0d8a 100644\n> --- a/src/libcamera/geometry.cpp\n> +++ b/src/libcamera/geometry.cpp\n> @@ -197,7 +197,8 @@ bool operator<(const Size &lhs, const Size &rhs)\n>   */\n>\n>  /**\n> - * \\fn SizeRange::SizeRange(unsigned int minW, unsigned int minH, unsigned int maxW, unsigned int maxH)\n> + * \\fn SizeRange::SizeRange(unsigned int minW, unsigned int minH,\n> + *\t\t\t    unsigned int maxW, unsigned int maxH)\n\nI was not sure Doxygen interpret line break correctly.\nI have generated the doc and it seems it does!\n\nThanks\nReviewed-by: Jacopo Mondi <jacopo@jmondi.org>\n\n>   * \\brief Construct an initialized size range\n>   * \\param[in] minW The minimum width\n>   * \\param[in] minH The minimum height\n> --\n> 2.20.1\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"<jacopo@jmondi.org>","Received":["from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net\n\t[217.70.183.194])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 58D8963080\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 11 Jun 2019 08:05:42 +0200 (CEST)","from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay2-d.mail.gandi.net (Postfix) with ESMTPSA id CD61940004;\n\tTue, 11 Jun 2019 06:05:41 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","Date":"Tue, 11 Jun 2019 08:06:55 +0200","From":"Jacopo Mondi <jacopo@jmondi.org>","To":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Cc":"LibCamera Devel <libcamera-devel@lists.libcamera.org>","Message-ID":"<20190611060655.7myo4e7z3scygmhu@uno.localdomain>","References":"<20190610220759.7192-1-kieran.bingham@ideasonboard.com>\n\t<20190610220759.7192-3-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"miijisjtloq53bf3\"","Content-Disposition":"inline","In-Reply-To":"<20190610220759.7192-3-kieran.bingham@ideasonboard.com>","User-Agent":"NeoMutt/20180716","Subject":"Re: [libcamera-devel] [PATCH 3/3] libcamera: geometry: Fix\n\tSizeRange constructor style","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Tue, 11 Jun 2019 06:05:42 -0000"}}]