[{"id":195,"web_url":"https://patchwork.libcamera.org/comment/195/","msgid":"<20190103212212.GG22790@bigcity.dyn.berto.se>","date":"2019-01-03T21:22:13","subject":"Re: [libcamera-devel] [PATCH 5/9] libcamera: device_enumerator: Fix\n\twording of log message","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your work.\n\nOn 2019-01-03 03:31:06 +0200, Laurent Pinchart wrote:\n> The log message still refers to the DeviceInfo class that has been\n> removed. Replace it with a reference to MediaDevice.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/device_enumerator.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/device_enumerator.cpp b/src/libcamera/device_enumerator.cpp\n> index bc55a12f2a4e..ecd51bc1d108 100644\n> --- a/src/libcamera/device_enumerator.cpp\n> +++ b/src/libcamera/device_enumerator.cpp\n> @@ -153,7 +153,7 @@ DeviceEnumerator::~DeviceEnumerator()\n> {\n> \tfor (MediaDevice *dev : devices_) {\n> \t\tif (dev->busy())\n> -\t\t\tLOG(Error) << \"Removing device info while still in use\";\n> +\t\t\tLOG(Error) << \"Removing media device while still in use\";\n> \n> \t\tdelete dev;\n> \t}\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lj1-x241.google.com (mail-lj1-x241.google.com\n\t[IPv6:2a00:1450:4864:20::241])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0321860B21\n\tfor ;\n\tThu, 3 Jan 2019 22:23:59 +0100 (CET)","by mail-lj1-x241.google.com with SMTP id u89-v6so30938524lje.1\n\tfor ;\n\tThu, 03 Jan 2019 13:23:59 -0800 (PST)","from localhost (89-233-230-99.cust.bredband2.com. [89.233.230.99])\n\tby smtp.gmail.com with ESMTPSA id\n\tn8-v6sm13010061lji.90.2019.01.03.13.22.13\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tThu, 03 Jan 2019 13:22:51 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=xZVFm+xWCytVHr7GoMzdmZBfx+MCeVYbAiczgpRM4p0=;\n\tb=iquK3HQgJzg4KLNDOAYssdD5cz68bE/G2YS7OrX/abnBU46tQ/kHAcz5mZQsJdjE8R\n\tGM61TVqbqZuxuqiSl6+/TYPJ/kjM8Fr0dhMliwJXGRBZKhEUhTm+5fZ2zXv2IgBgza4y\n\tIKXFkJIVktC+P7YwaZO/xhJ6J2zKLrLWUpW3RbqlyIMSdgPanirJBnGDZsoY5bXKGUUq\n\tmHPusWwsImyE3TNE1ATrInPZa7zrtRydG0T/paC0JNW81+BnNS21n/aV3nJEkMFfA67f\n\tj9r/ivcqAfi/sGcLrnUWZv5mow45lzoEr0wFEh84mrtxCUEh5Ry2OGIuSrO9ei7d762m\n\t47gg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=xZVFm+xWCytVHr7GoMzdmZBfx+MCeVYbAiczgpRM4p0=;\n\tb=bwREq+6M9fj21LZ8V0+/FY6cP4UugQ159YeiKRXL5Gkt6pSq93gqPgn+u0bPv4THPJ\n\tGnXiLEKLIdu1Sjy3gqQFOcjZ6O8AoTCDYsBEfhFwFHJ3lUXUkiuwAScb7D8leCs/quEq\n\tdEB98lUac9OkqDOBRPoOrU5wYfnyNgAUYYiwiQHzuUX+BALeMPiufU0butGXe3khyY3h\n\tOX/mpZkyxXBj+kjmCsOjpaWjaQ5W1JoTrlILHnYat+WbDmo3LWxIhKU6l6lizK1WMZVu\n\tcnAQTItpCdmE01OB6mFEL0bkbID6jCP0wp47Mj91fImfdNGsfQHct3rYazyZX0KkXRyO\n\tJoBg==","X-Gm-Message-State":"AA+aEWZhgsZRPV5yE5Vk/FfNnW1Nwr/8A3pxSmuUIuwkJPeOvE8QIk6P\n\t4s3wvns3W+Pda6IuUCJ1nD/1kQ==","X-Google-Smtp-Source":"ALg8bN45mlP89d3NTkt0k4ibLVlku/+oTMMEljPcBwlCRFMNvnPacJs2Z0XhXCxQXOCgAAzWAIvi9w==","X-Received":"by 2002:a2e:8187:: with SMTP id\n\te7-v6mr31292804ljg.67.1546550639290; \n\tThu, 03 Jan 2019 13:23:59 -0800 (PST)","Date":"Thu, 3 Jan 2019 22:22:13 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190103212212.GG22790@bigcity.dyn.berto.se>","References":"<20190103013110.6849-1-laurent.pinchart@ideasonboard.com>\n\t<20190103013110.6849-5-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190103013110.6849-5-laurent.pinchart@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 5/9] libcamera: device_enumerator: Fix\n\twording of log message","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 03 Jan 2019 21:24:00 -0000"}}]