{"id":139,"url":"https://patchwork.libcamera.org/api/patches/139/?format=json","web_url":"https://patchwork.libcamera.org/patch/139/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190103013110.6849-5-laurent.pinchart@ideasonboard.com>","date":"2019-01-03T01:31:06","name":"[libcamera-devel,5/9] libcamera: device_enumerator: Fix wording of log message","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"43ec7aac79557f711525f63f3fe9d2964f273971","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/139/mbox/","series":[{"id":51,"url":"https://patchwork.libcamera.org/api/series/51/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=51","date":"2019-01-03T01:31:02","name":"[libcamera-devel,1/9] libcamera: camera_manager: Remove put() method","version":1,"mbox":"https://patchwork.libcamera.org/series/51/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/139/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/139/checks/","tags":{},"headers":{"Return-Path":"<laurent.pinchart@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D44EF60B32\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu,  3 Jan 2019 02:30:14 +0100 (CET)","from avalon.bb.dnainternet.fi\n\t(dfj612ybrt5fhg77mgycy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:2e86:4862:ef6a:2804])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3595C505\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu,  3 Jan 2019 02:30:14 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1546479014;\n\tbh=/61PXmC3P9b4GEltJ+1ghHqGyn0VzoCbmbsoA0zglmM=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=tIwIBmiLB09KnkmD+eQNmzg/TGwHySL6HazKuU60AtgUqpgZW4L+Lp9Hp0DD8qLAZ\n\tu+AcKBqxDGaxICeaom0aHDqn2YYxq4O63RtcQggeisOCpcUJf04/Qi1iFgtYqKpHDp\n\tBYgzRNheAkVjOK+PbBw2QeYFJfajk85fFX/NXCAU=","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"libcamera-devel@lists.libcamera.org","Date":"Thu,  3 Jan 2019 03:31:06 +0200","Message-Id":"<20190103013110.6849-5-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.19.2","In-Reply-To":"<20190103013110.6849-1-laurent.pinchart@ideasonboard.com>","References":"<20190103013110.6849-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 5/9] libcamera: device_enumerator: Fix\n\twording of log message","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Thu, 03 Jan 2019 01:30:15 -0000"},"content":"The log message still refers to the DeviceInfo class that has been\nremoved. Replace it with a reference to MediaDevice.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/device_enumerator.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/device_enumerator.cpp b/src/libcamera/device_enumerator.cpp\nindex bc55a12f2a4e..ecd51bc1d108 100644\n--- a/src/libcamera/device_enumerator.cpp\n+++ b/src/libcamera/device_enumerator.cpp\n@@ -153,7 +153,7 @@ DeviceEnumerator::~DeviceEnumerator()\n {\n \tfor (MediaDevice *dev : devices_) {\n \t\tif (dev->busy())\n-\t\t\tLOG(Error) << \"Removing device info while still in use\";\n+\t\t\tLOG(Error) << \"Removing media device while still in use\";\n \n \t\tdelete dev;\n \t}\n","prefixes":["libcamera-devel","5/9"]}